From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Star Zeng <star.zeng@intel.com>, edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Jian J Wang <jian.j.wang@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [PATCH V3 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for AsyncInterruptTransfer
Date: Mon, 29 Oct 2018 10:19:45 +0800 [thread overview]
Message-ID: <ade7eb00-4973-b7dd-275c-93097ef5611b@Intel.com> (raw)
In-Reply-To: <1540561286-112684-1-git-send-email-star.zeng@intel.com>
On 10/26/2018 9:41 PM, Star Zeng wrote:
> V3: Thanks for Hao's feedback.
> 1. Match function parameter name and description between
> XhciSched.c and XhciSched.h, EhciSched.c and EhciSched.h.
> 2. Call XhcFreeUrb after XhcCreateTransferTrb fails in XhcCreateTrb.
>
>
> V2: Thanks for Ray's feedback.
> 1. Add the missing "FreePool (Data);".
> 2. Remove the unnecessary indentation change.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
>
> Please refer to the log message of each commit for more details.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> Star Zeng (4):
> MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function
> MdeModulePkg EhciDxe: Extract new EhciInsertAsyncIntTransfer function
> MdeModulePkg XhciDxe: Use common buffer for AsyncInterruptTransfer
> MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer
>
> MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 28 +----
> MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 114 +++++++++----------
> MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.h | 35 +++++-
> MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 38 ++++++-
> MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h | 33 +++---
> MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 19 +---
> MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 185 +++++++++++++++++--------------
> MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 55 +++++++--
> 8 files changed, 296 insertions(+), 211 deletions(-)
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@Intel.com>
--
Thanks,
Ray
prev parent reply other threads:[~2018-10-29 2:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 13:41 [PATCH V3 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for AsyncInterruptTransfer Star Zeng
2018-10-26 13:41 ` [PATCH V3 1/4] MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function Star Zeng
2018-10-26 13:41 ` [PATCH V3 2/4] MdeModulePkg EhciDxe: Extract new EhciInsertAsyncIntTransfer function Star Zeng
2018-10-26 13:41 ` [PATCH V3 3/4] MdeModulePkg XhciDxe: Use common buffer for AsyncInterruptTransfer Star Zeng
2018-10-27 7:47 ` Wu, Hao A
2018-10-26 13:41 ` [PATCH V3 4/4] MdeModulePkg EhciDxe: " Star Zeng
[not found] ` <CS1PR8401MB1189428C2915107C583C0A42B4CC0@CS1PR8401MB1189.NAMPRD84.PROD.OUTLOOK.COM>
2018-10-30 12:39 ` Ard Biesheuvel
2018-10-30 12:50 ` Leif Lindholm
2018-10-31 4:38 ` Zeng, Star
2018-10-31 12:08 ` Leif Lindholm
2018-11-01 1:12 ` Zeng, Star
2018-11-01 10:32 ` Leif Lindholm
2018-11-06 9:49 ` Ard Biesheuvel
2018-11-06 14:37 ` Zeng, Star
2018-11-07 15:00 ` Zeng, Star
2018-11-07 15:14 ` Ard Biesheuvel
2018-10-28 13:35 ` [PATCH V3 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe " Zeng, Star
2018-10-29 2:19 ` Ni, Ruiyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade7eb00-4973-b7dd-275c-93097ef5611b@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox