From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 04EF921184AA8 for ; Sun, 28 Oct 2018 19:18:31 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2018 19:18:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,438,1534834800"; d="scan'208";a="85217300" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 28 Oct 2018 19:18:29 -0700 To: Star Zeng , edk2-devel@lists.01.org Cc: Hao Wu , Jian J Wang , Jiewen Yao References: <1540561286-112684-1-git-send-email-star.zeng@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Mon, 29 Oct 2018 10:19:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1540561286-112684-1-git-send-email-star.zeng@intel.com> Subject: Re: [PATCH V3 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for AsyncInterruptTransfer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 02:18:33 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/26/2018 9:41 PM, Star Zeng wrote: > V3: Thanks for Hao's feedback. > 1. Match function parameter name and description between > XhciSched.c and XhciSched.h, EhciSched.c and EhciSched.h. > 2. Call XhcFreeUrb after XhcCreateTransferTrb fails in XhcCreateTrb. > > > V2: Thanks for Ray's feedback. > 1. Add the missing "FreePool (Data);". > 2. Remove the unnecessary indentation change. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 > > Please refer to the log message of each commit for more details. > > Cc: Ruiyu Ni > Cc: Hao Wu > Cc: Jian J Wang > Cc: Jiewen Yao > > Star Zeng (4): > MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function > MdeModulePkg EhciDxe: Extract new EhciInsertAsyncIntTransfer function > MdeModulePkg XhciDxe: Use common buffer for AsyncInterruptTransfer > MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer > > MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 28 +---- > MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 114 +++++++++---------- > MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.h | 35 +++++- > MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 38 ++++++- > MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h | 33 +++--- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 19 +--- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 185 +++++++++++++++++-------------- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 55 +++++++-- > 8 files changed, 296 insertions(+), 211 deletions(-) > Reviewed-by: Ruiyu Ni -- Thanks, Ray