public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Pete Batard <pete@akeo.ie>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application
Date: Thu, 24 Nov 2016 16:12:16 +0000	[thread overview]
Message-ID: <adea4665-6616-a541-7f18-d45e9420ffc0@akeo.ie> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386DA63E@shsmsx102.ccr.corp.intel.com>

On 2016.11.24 15:55, Yao, Jiewen wrote:
> I suddenly realize you added AppPkg/AppPkg.dec, too. That is another dependency violation.

You're right, I forgot to remove that dependency.

> I do not see any need to add this AppPkg.dec. Can you try to remove this from INF?

Just confirmed that it isn't needed.

However, while testing this, I found an issue when building X64, which I 
guess has to do with trying to return SHELL_STATUS instead of EFI_STATUS 
for InitializeEbcDebuggerConfig().

This didn't matter for v1, and I only tested v2 with IA32, so I didn't 
spot it earlier. But I guess EFI_STATUS and SHELL_STATUS don't have the 
same size on X64 (and likely AARCH64), so I have to ask:

Should the shell application return SHELL_STATUS or EFI_STATUS?

I was under the impression that, because the Shell error codes are 
expected to be positive, SHELL_STATUS is preferred over EFI_STATUS.
But then, I am not sure what is the right way to set an application 
entrypoint for an X64 app that returns SHELL_STATUS...

Once we agree on the return type, I can submit a new updated patch.

Regards,

/Pete




  reply	other threads:[~2016-11-24 16:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24 15:46 [PATCH v2 0/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application Pete Batard
2016-11-24 15:46 ` [PATCH v2 1/1] " Pete Batard
2016-11-24 15:55   ` Yao, Jiewen
2016-11-24 16:12     ` Pete Batard [this message]
2016-11-24 16:35       ` Yao, Jiewen
2016-11-24 16:38         ` Pete Batard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adea4665-6616-a541-7f18-d45e9420ffc0@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox