From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DA0D81E67 for ; Thu, 24 Nov 2016 08:12:19 -0800 (PST) Received: by mail-wm0-x233.google.com with SMTP id a197so119296965wmd.0 for ; Thu, 24 Nov 2016 08:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=iQBtxOI3Ct3GaEQ0PphMu/dhgPByt6P12bruOVfhkBg=; b=idJw36lHxxyPxMLeo74QWSMctsgVYfYa6holodEddhxXIR6xXAkGfHtdU3xLoW7q2T nmXrUSF46CwBwCFmbZtO/sadQDjtYITCELVTZ5FJZIPNoOxaOZ5ugMdW8+7az81gE5yu EP5OWoqjE8oqpcZwJ+VgWCbtdIeqGLpt6PwNUovpyM58YTZQlPHNCgwqjEnTKbOsZ6a+ vVzETyZCCDOj+BgDF0ixkoS9Q0Cu8jZYRVwIWm7l22svwYK078K2Z+JvqimV5ozsjFKm odlqZ8yCs96fr67joAD1RusI8kY662RXoIlpF3j0dG5w23sx0k7+tQfuNloGUv15/bTS y4YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=iQBtxOI3Ct3GaEQ0PphMu/dhgPByt6P12bruOVfhkBg=; b=jW48Qqi6B5x/5l7q6byKwYMDq7t2lrzAmKD7vUA7CYuLgms1b1X+6j7BK+aVhU9/7T Iz3YjzEHIv+hPAYx/9TcKdt2Kv0f2qEtcqXJJbyz5pYXP7V8RlHEEUWCZQul81KWGvEN zVIFJK9bKASgor0DwDD/bXAK+9TmW6IjJekNF7nnBEQUVVr5jVuBrvtjQPqXXKI7HV9i SYjT/0Dow+1UWP/aBZEJLSxd2m1ujg48o32ZMlkAvXFMEIxHYxyp370lKBatBoKCbjrh /neKX1eRtQsoCEXHPy3mAKoWb2ETfU77CTFm1Yr5b2L0e14hyKniYDeGXNfw76UsBzrG bzEA== X-Gm-Message-State: AKaTC01M3rfwQ9Nhsc3uUNFjuDjLpIK7SKHV06VkArepNRI8sjuwcUZzVHBNrXQ/hTSlMw== X-Received: by 10.194.238.163 with SMTP id vl3mr2953638wjc.169.1480003937927; Thu, 24 Nov 2016 08:12:17 -0800 (PST) Received: from [10.0.0.101] ([84.203.62.38]) by smtp.googlemail.com with ESMTPSA id f134sm8942974wmf.19.2016.11.24.08.12.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Nov 2016 08:12:17 -0800 (PST) To: "Yao, Jiewen" , "edk2-devel@lists.01.org" References: <20161124154601.8024-1-pete@akeo.ie> <20161124154601.8024-2-pete@akeo.ie> <74D8A39837DF1E4DA445A8C0B3885C50386DA63E@shsmsx102.ccr.corp.intel.com> From: Pete Batard Message-ID: Date: Thu, 24 Nov 2016 16:12:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386DA63E@shsmsx102.ccr.corp.intel.com> Subject: Re: [PATCH v2 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 16:12:20 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 2016.11.24 15:55, Yao, Jiewen wrote: > I suddenly realize you added AppPkg/AppPkg.dec, too. That is another dependency violation. You're right, I forgot to remove that dependency. > I do not see any need to add this AppPkg.dec. Can you try to remove this from INF? Just confirmed that it isn't needed. However, while testing this, I found an issue when building X64, which I guess has to do with trying to return SHELL_STATUS instead of EFI_STATUS for InitializeEbcDebuggerConfig(). This didn't matter for v1, and I only tested v2 with IA32, so I didn't spot it earlier. But I guess EFI_STATUS and SHELL_STATUS don't have the same size on X64 (and likely AARCH64), so I have to ask: Should the shell application return SHELL_STATUS or EFI_STATUS? I was under the impression that, because the Shell error codes are expected to be positive, SHELL_STATUS is preferred over EFI_STATUS. But then, I am not sure what is the right way to set an application entrypoint for an X64 app that returns SHELL_STATUS... Once we agree on the return type, I can submit a new updated patch. Regards, /Pete