From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web10.49608.1585573770320300401 for ; Mon, 30 Mar 2020 06:09:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=pc+i/vK9; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.68, mailfrom: pete@akeo.ie) Received: by mail-wr1-f68.google.com with SMTP id m17so21495880wrw.11 for ; Mon, 30 Mar 2020 06:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7LsXWJka6qToLA8Z2b5CE7AyQrNZCE+Cnbv19f69IZw=; b=pc+i/vK9s74q/HA0b0w1JnLnq+r6fEd1ltGvk1NQK+6TzdpXMzNv4dxymY6V54XRXT HYCpczDKxO1+3YslB9RAA6hxlGdkYPus2dlOZnI/9TtjVoPZhE/bZjQRyS851TVK9xst I294Z6I/1C4dU16WS3jrVz+jhHGvUtKrNvgOymqRxJFqy7084KOIYLKLm70Bm2uEze1U qb+2lN3II6pZ78EdH6Cd2ufuHXdazcTP06IjzvjC8u4+Q5n6jMUZ2Pu1DhpuFpKc/UnF rN2GPWp2K9IL8Y9rjhw/MvV9cYaNeMykn9jzMXh8CgqtBR5pEMTnak/kkV4ZWgPuEUb7 VN0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7LsXWJka6qToLA8Z2b5CE7AyQrNZCE+Cnbv19f69IZw=; b=YjhoXOcpnqp2rlicxWZIsZd30sN14UP9gHHS1x09IGK/HRrDBSHktbLfphJkmMi1kS VRha92mcaUZhbzaziSwAmQs+v8VCzNxHnUKImNccgnbv/ReO1mysUQbJVMMfyL0b2z4G dFk+evhz9mP6wWFOBs07opqyfout7JYNDc1eTUAH7kukFtrOJ2lh42PO7/112LLRj0Vq 6VIMOJcYYyt5BZQA6LuXebGTXRIuKRrGRsFkOXmhb1iWNSnESkW1FRt6LAe9hGY95JmG rmSQbnKqf1+KhoDDpoFSowBFBoQxbgOSyb/zmFGKMeLBlle7RZ1G14L3aBNL7YqWNtb8 +KMg== X-Gm-Message-State: ANhLgQ2OwrgYjnv9pvQw6n9w/zv1PKN+2yukvRbiRnuNNTRayhUyiLEp lR7gKScj38sDyEU8FdaBfxAAVRr5kfDz6Q== X-Google-Smtp-Source: ADFU+vvPKOysK0gTnwA4A/l2C1Qym0mMLEvcmG1Ew1+ZkdGc29WWxz0CDKBVwP/ot/qzCoQgAGNXxg== X-Received: by 2002:adf:e48a:: with SMTP id i10mr15745924wrm.71.1585573768915; Mon, 30 Mar 2020 06:09:28 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.45.232]) by smtp.googlemail.com with ESMTPSA id l17sm22811010wrm.57.2020.03.30.06.09.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2020 06:09:28 -0700 (PDT) Subject: Re: [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3 To: Ard Biesheuvel Cc: edk2-devel-groups-io , Leif Lindholm References: <20200327130117.11304-1-pete@akeo.ie> From: "Pete Batard" Message-ID: Date: Mon, 30 Mar 2020 14:09:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.03.30 14:06, Ard Biesheuvel wrote: > On Fri, 27 Mar 2020 at 14:06, Pete Batard wrote: >> >> Incidentally, this is not an [edk2-platform] patch, as the subject line >> from previous mail seemed to indicate, but an [edk2] patch. >> > > Do we have a user for this? Yes we do. I have a pachset lined up that updates the Raspberry Pi ACPI to 6.3, that has a dependency on this. Regards, /Pete > >> >> On 2020.03.27 13:01, Pete Batard wrote: >>> ACPI 6.3 added a 16-bit SPE overflow Interrupt field, replacing >>> 2 of the 3 reserved bytes that are defined at the end of the >>> GICC structure for 6.0. >>> >>> Add a new macro to initialise the new field. >>> >>> Signed-off-by: Pete Batard >>> --- >>> EmbeddedPkg/Include/Library/AcpiLib.h | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h b/EmbeddedPkg/Include/Library/AcpiLib.h >>> index 5c6e2075de79..57d7bd595584 100644 >>> --- a/EmbeddedPkg/Include/Library/AcpiLib.h >>> +++ b/EmbeddedPkg/Include/Library/AcpiLib.h >>> @@ -64,6 +64,14 @@ >>> {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE} \ >>> } >>> >>> +#define EFI_ACPI_6_3_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr, Flags, PmuIrq, \ >>> + GicBase, GicVBase, GicHBase, GsivId, GicRBase, Efficiency, SpeOvflIrq) \ >>> + { \ >>> + EFI_ACPI_6_0_GIC, sizeof (EFI_ACPI_6_0_GIC_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ >>> + GicId, AcpiCpuUid, Flags, 0, PmuIrq, 0, GicBase, GicVBase, GicHBase, \ >>> + GsivId, GicRBase, Mpidr, Efficiency, EFI_ACPI_RESERVED_BYTE, SpeOvflIrq \ >>> + } >>> + >>> #define EFI_ACPI_6_0_GIC_MSI_FRAME_INIT(GicMsiFrameId, PhysicalBaseAddress, Flags, SPICount, SPIBase) \ >>> { \ >>> EFI_ACPI_6_0_GIC_MSI_FRAME, sizeof (EFI_ACPI_6_0_GIC_MSI_FRAME_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ >>> >>