From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9F6FD941511 for ; Mon, 25 Sep 2023 09:19:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=h03Vj4In5Xzn8pL7gWeeiScwDjJaAkKuMoQPrG4yxec=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695633557; v=1; b=ZHFFfE0PcMorYyj90Jb0Jhm97AaxtCWDKyjKnYyHsWq9zun9RsZVb7DfDlcZP5pl3JUqqI6Q 1lghXWW8cLYMjo5Ynhp/BLHOsXHna/dQSFHXiSLRo36yjgjE3d6RN2i9ryZrQJB2OcuFeSTZcz1 wXBYsdgJy+UZ3E3l1ejLF5gE= X-Received: by 127.0.0.2 with SMTP id sfVKYY7687511xQtjvNCCqQo; Mon, 25 Sep 2023 02:19:17 -0700 X-Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.82]) by mx.groups.io with SMTP id smtpd.web11.57602.1695633555945616447 for ; Mon, 25 Sep 2023 02:19:16 -0700 X-Received: from DUZPR01CA0255.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::27) by AM9PR08MB5971.eurprd08.prod.outlook.com (2603:10a6:20b:2d9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 09:19:12 +0000 X-Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b5:cafe::66) by DUZPR01CA0255.outlook.office365.com (2603:10a6:10:4b5::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.35 via Frontend Transport; Mon, 25 Sep 2023 09:19:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.18 via Frontend Transport; Mon, 25 Sep 2023 09:19:12 +0000 X-Received: ("Tessian outbound 30c9f5e988c5:v175"); Mon, 25 Sep 2023 09:19:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ee8ec6a4e4eab401 X-CR-MTA-TID: 64aa7808 X-Received: from 8cdb75f124cd.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 984ED3AE-3A3E-438F-AE6F-831A2EF20F3B.1; Mon, 25 Sep 2023 09:19:06 +0000 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8cdb75f124cd.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Sep 2023 09:19:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWDYv5jxjdp2i6CRh9+IxwbfC3p+nSnPFP5RixzMYCTmHGirv1q3Tw26yJKUl0kbN0JbU99ENP9BXQF1TrngL5heXjU7Mb9wr+IEiViAKwLH84d4n8yQcIiq9nYkf/69O7uO69w67s2L0YEsvy3P4vZg6DvZ09q/4Zovy7uJD5JqWDiEGLiOS14Bxbbm9W2Z2qNsIoSef71HA7bGJoCuMfSTwANZNScjLXp2i9h8bxh/DDFbsc0zQPY7O8G80tMAO2wQ8y52tT7VHDUHb5Be3QQx5CO5VltiYMCSVHx8AhETlLgaCWgYN5KNOtc/HL7cDeZz/ggC3uyslW9nRqQ/lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=onkUDQTDbQjpU/3A3w4CAyfOran/ZjOohNaQYNvuuVI=; b=C37DEKLf6hS3yG5EBBVjsUjHgcdkI+0QDn9l6mouPd2tScuVI6KG7IRACphThbZIQCOs/IgGQyxEV+nRgOcdF27fqltnZCos07nvCwwquKNL2eQha7+pzgF/lna+oY79Up8yJAo+mKdaYkOnWLz3BO9yYZpApQeviYbzjneB05V/JfOYPAtSBDWlHIWWvCyaOH40L3LARwdTNkDFu+TLdyCieEQuoUJcRIC+7CU85AAquV3GZIMhqgOz0+Y2uN/Cj6AYdfzyc2T7cEFxy6a+NtBehgnEwb+9FW5ymCFP2bgFcKx53lK/HuGk2iXabJoSwS6HW4J8DaVl6vjrMEBKmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAVPR08MB9579.eurprd08.prod.outlook.com (2603:10a6:102:31a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 09:19:04 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce%4]) with mapi id 15.20.6813.027; Mon, 25 Sep 2023 09:19:04 +0000 Message-ID: Date: Mon, 25 Sep 2023 10:19:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: IORT generator updates for Rev E.e spec To: Swatisri Kantamsetti , devel@edk2.groups.io, pierre.gondois@arm.com, "nd@arm.com" References: <273efda2552363dd2ed5794b00b1b4e87b290909.1695418444.git.swatisrik@nvidia.com> From: "Sami Mujawar" In-Reply-To: <273efda2552363dd2ed5794b00b1b4e87b290909.1695418444.git.swatisrik@nvidia.com> X-ClientProxiedBy: LO4P265CA0224.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::8) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAVPR08MB9579:EE_|DBAEUR03FT058:EE_|AM9PR08MB5971:EE_ X-MS-Office365-Filtering-Correlation-Id: eb0b0585-d228-4048-aaa0-08dbbda87b7c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: deK2zVq4AtWtzcA8R0Fw+injVjQrBkLKS/6wE5/JHIPUPaBGg7Qy+e092MGNTuAEa/C7CQ+3LXodYTdM/DvuUXLeaiR+cgLbbUJT0gnqant/o2tedxq9d8wJFX8VHN4/cUDw5TP77sWFgd4OeuAF0M3bTIYWEYys1sY68fpdlFcrsnoVGsMAFco6rGLK8ozpwXLoQWFj9wJguEHKveRe8N5Zq0rfauTFYYhFOoDsOJxmNlsTAIC5QMKuCUkVQA1Da1SXbD8WVJVXlYjc7CPP8+dla2PqlJVJxcQ3V3L0zn179D/sY7h+FbV00pdxe9YumNel7EriZ9JK4tjfcBUJBed80ZXL6usH2W7mSmo9oTH/GV5t4ZW8ndZTUC9Ae0FMCZSAzjBEgVn24T74qEjTL3gYRPnQ6Damo5xojeBfC887s7WRTWSas4O+/3TZjA1tovE57xMrh8+pOf7GKY5MZJ2XsTT+7FBzSycfK5NEGAgXZUTR5K/ofHNViHbk8S8MM9iR7/L/ISmY+biDaraNvTQerk4IhPrN3JHS475lX+3F7S/N07GYSamN1KKttOBTfNWtYI3Ikz0b9y06KfZrQcWyIlC/BJT9Y4DSl55mDLMKeYasvgKZ3O8T2QnJrokmmVW1IDVCeF/JWOuz5bfqxGVhuoQ37uwo1CmryN6MmFxp6lYuUGE/kBWWX8NZkzF2 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(346002)(376002)(396003)(366004)(230922051799003)(186009)(1800799009)(451199024)(2616005)(6486002)(6506007)(26005)(6512007)(53546011)(38100700002)(36756003)(31696002)(86362001)(83380400001)(8936002)(8676002)(41300700001)(6636002)(316002)(66946007)(66476007)(44832011)(66556008)(5660300002)(110136005)(15650500001)(31686004)(2906002)(966005)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9579 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5468a631-0729-47d2-d586-08dbbda87660 X-Microsoft-Antispam-Message-Info: DWJepq9rNiX2CrlEUOXqy8rqN+d4QwbCKzT6Jh/1UYyBX0jmJOZN0DYGIgFtYC2NTvNMuPYOalgY0ssFsBvB/T0ej87NayZVTViDRWR+s81Myh8TG6BEfmCuEqqxSen4SQhzaMG1IVGaXLCrePaMy6s0j3cISo27OGv56MP4PnTRzUpYtE0MCbZF1FC2byF9g1pZ1rhmQZ+0nI+NP17O2qtM7AZSdhpb4jyL8ay05cUJG0+k/R5TbJ71yJ8t7Qc+k0T9wFCzjjsHr4HIRRwL6Jxl8urhn0HmzD6dtCOjym8D5ISafz2JJq3Hwx3iP8nOnBisrXSWeDrk6xQV4eW/tNzEk869gid27sXGD774N+0S9O/PIJxryF8lFYYglfIqWN5LGbHmrKuBcdLjLun6x1yipjtbJ7jqaV8fVUO2lRUK3IfLQcy7nFeNHfRKF1MzWQeCZznUlyu+AcU9AHZ9xVVyyWPgiewsXAICioHXICS4/xoKFu9EhNBAaO4dECgPgJvaMgLCNGWHnAgaujEHGFdwSV/MFiHkQB5PWnF86zGY0XEjh3XyGZf4lWsAAguJ2EoEmEjPtBjNGhZe1n6qEjlfN7onoWUmRfuqHV6B/b3vtlWGdh/mtVxbbaoLA4IgVtjYZgmzPltRnWEhTouWXeCdiqO3/+XFIIgiYOCpGRx0ffSligm7O2+5NVWVz/3Uw4s5LS6/+T7AQIqt4IWlbM0PP3z8Owo/CfjjxcRWmHrx4ci5HRxCgfZRccm9PDO126OU9ta2zM3fPltEV8nwBH7jbV1gJZEl6+74jS9l+qw= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 09:19:12.6824 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb0b0585-d228-4048-aaa0-08dbbda87b7c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5971 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ORLDEEd7ORMJASqLPQKy69f3x7686176AA= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZHFFfE0P; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Swatisri, Thank you for this patch. I believe this was reviewed intially at https://edk2.groups.io/g/devel/topic/96534672#99048 and I see you have addressed the feedback in this patch. I also see that patch 2/2 from your previous series was already merged. Can you increment the revision for the patch series (even if some patches get merged) in future, please? It helps keep track of the review history. Other than that this patch looks good to me and I will queue this for merging. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 22/09/2023 10:40 pm, Swatisri Kantamsetti wrote: > The IO Remapping Table, Platform Design Document, Revision E.e, > Sept 2022 (https://developer.arm.com/documentation/den0049/ee) > added flags in SMMUv3 node for validity of ID mappings for MSIs > related to control interrupts. > It makes one small addition to SMMUv3 nodes to > describe MSI support independently of wired GSIV support > > Therefore, update the IORT generator to: > - increment IORT table revision to 6 > - increment SMMUV3 node revision to 5 > - for SMMUV3 node revision >=3D5 check the DeviceID mapping index > valid flag to populate DeviceIdMappingIndex field > > Signed-off-by: Swatisri Kantamsetti > --- > .../Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 35 +++++++++++++++---- > 1 file changed, 28 insertions(+), 7 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerat= or.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c > index f28973c1a8..a6e4b49cb1 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c > @@ -5,7 +5,7 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent > > @par Reference(s): > - - IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022 > + - IO Remapping Table, Platform Design Document, Revision E.e, Sept 202= 2 > (https://developer.arm.com/documentation/den0049/) > > **/ > @@ -1554,9 +1554,14 @@ AddSmmuV3Nodes ( > { > SmmuV3Node->Node.Revision =3D 2; > SmmuV3Node->Node.Identifier =3D EFI_ACPI_RESERVED_DWORD; > - } else { > + } else if (AcpiTableInfo->AcpiTableRevision < > + EFI_ACPI_IO_REMAPPING_TABLE_REVISION_06) > + { > SmmuV3Node->Node.Revision =3D 4; > SmmuV3Node->Node.Identifier =3D NodeList->Identifier; > + } else { > + SmmuV3Node->Node.Revision =3D 5; > + SmmuV3Node->Node.Identifier =3D NodeList->Identifier; > } > > // SMMUv3 specific data > @@ -1577,11 +1582,27 @@ AddSmmuV3Nodes ( > SmmuV3Node->ProximityDomain =3D 0; > } > > - if ((SmmuV3Node->Event !=3D 0) && (SmmuV3Node->Pri !=3D 0) && > - (SmmuV3Node->Gerr !=3D 0) && (SmmuV3Node->Sync !=3D 0)) > + /* For older SMMUV3 nodes rev. < 5. > + If all the SMMU control interrupts are GSIV based, > + the DeviceID mapping index field is ignored. > + DeviceID mapping valid flag was introduced in IORT rev E.e > + for SMMUV3 nodes rev. > 5. > + If the DeviceID mapping index valid flag is set to 0, > + DeviceID mapping index field must be ignored. > + Where the SMMU uses message signaled interrupts for > + its control interrupts, DeviceId Mapping Index contains an > + index into the array of ID mapping. > + */ > + if (((SmmuV3Node->Node.Revision < 5) && > + (SmmuV3Node->Event !=3D 0) && > + (SmmuV3Node->Pri !=3D 0) && > + (SmmuV3Node->Gerr !=3D 0) && > + (SmmuV3Node->Sync !=3D 0) > + ) || > + ((SmmuV3Node->Node.Revision >=3D 5) && > + ((SmmuV3Node->Flags & EFI_ACPI_IORT_SMMUv3_FLAG_DEVICEID_VALID)= =3D=3D 0)) > + ) > { > - // If all the SMMU control interrupts are GSIV based, > - // the DeviceID mapping index field is ignored. > SmmuV3Node->DeviceIdMappingIndex =3D 0; > } else { > SmmuV3Node->DeviceIdMappingIndex =3D NodeList->DeviceIdMappingInd= ex; > @@ -2819,7 +2840,7 @@ ACPI_IORT_GENERATOR IortGenerator =3D { > // ACPI Table Signature > EFI_ACPI_6_4_IO_REMAPPING_TABLE_SIGNATURE, > // ACPI Table Revision supported by this Generator > - EFI_ACPI_IO_REMAPPING_TABLE_REVISION_05, > + EFI_ACPI_IO_REMAPPING_TABLE_REVISION_06, > // Minimum supported ACPI Table Revision > EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00, > // Creator ID IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109038): https://edk2.groups.io/g/devel/message/109038 Mute This Topic: https://groups.io/mt/101535844/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-