From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 37DFE740034 for ; Mon, 19 Feb 2024 20:30:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=A1cKs5QEhAxuz/Jv1111BYrcZScDg3e/w+sNIa3MNk4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708374641; v=1; b=X2spuvCxDqUaBrnIsOK0z/nrvX+0mWDiOt0E+Tsme18UH+8o81rfWiF4UzCPKZk+8qNypADj 2VqILvJs0jMAEwq5zm5qMaMQ7h6jqFhIvTp8YgXAfn6VGBjbMynYMdutAyEdE75nbkqwkF+jFVN FgcgQjbMp5PxyeCrf1KG/f0s= X-Received: by 127.0.0.2 with SMTP id i2FeYY7687511x6Qjkg1qyPy; Mon, 19 Feb 2024 12:30:41 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web10.36085.1708325077979372014 for ; Sun, 18 Feb 2024 22:44:38 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="13796960" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="13796960" X-Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 22:44:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="4789998" X-Received: from babios001.gar.corp.intel.com ([10.223.9.189]) by orviesa008.jf.intel.com with ESMTP; 18 Feb 2024 22:44:36 -0800 From: Gahan Saraiya To: devel@edk2.groups.io Cc: Gahan Saraiya Subject: [edk2-devel] [PATCH] Pkg-Module: OptionRomPkg, MinPlatformPkg, Silicon/Marvell Date: Mon, 19 Feb 2024 12:14:33 +0530 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gahan.saraiya@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9Rn2XxSVusFDLkbqQQoYTpd9x7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=X2spuvCx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4689 Bug 4689 - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data for UEFI Spec compliance 2.9 [mantis #1866] Signed-off-by: Gahan Saraiya --- Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h | 17 +++++++++-------- .../Test/Library/TestPointLib/DxeTestPointAip.c | 7 ++++--- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 1 + 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h b/Drivers/OptionR= omPkg/UndiRuntimeDxe/Undi32.h index 31c55a8e11..45c1f41414 100644 --- a/Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h +++ b/Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h @@ -350,23 +350,24 @@ VOID PxeUpdate (NIC_DATA_INSTANCE *NicPtr, PXE_SW_UND= I *PxePtr); =0D This function returns information of type InformationType from the adapt= er.=0D If an adapter does not support the requested informational type, then=0D - EFI_UNSUPPORTED is returned. =0D + EFI_UNSUPPORTED is returned.=0D =0D @param[in] This A pointer to the EFI_ADAPTER_INFORMAT= ION_PROTOCOL instance.=0D @param[in] InformationType A pointer to an EFI_GUID that defines= the contents of InformationBlock.=0D - @param[out] InforamtionBlock The service returns a pointer to the = buffer with the InformationBlock=0D + @param[out] InformationBlock The service returns a pointer to the = buffer with the InformationBlock=0D structure which contains details abou= t the data specific to InformationType.=0D - @param[out] InforamtionBlockSize The driver returns the size of the In= formationBlock in bytes.=0D + @param[out] InformationBlockSize The driver returns the size of the In= formationBlock in bytes.=0D =0D @retval EFI_SUCCESS The InformationType information was r= etrieved.=0D @retval EFI_UNSUPPORTED The InformationType is not known.=0D + @retval EFI_NOT_FOUND Information is not available for the = requested information type.=0D @retval EFI_DEVICE_ERROR The device reported an error.=0D @retval EFI_OUT_OF_RESOURCES The request could not be completed du= e to a lack of resources.=0D - @retval EFI_INVALID_PARAMETER This is NULL. =0D - @retval EFI_INVALID_PARAMETER InformationBlock is NULL. =0D + @retval EFI_INVALID_PARAMETER This is NULL.=0D + @retval EFI_INVALID_PARAMETER InformationBlock is NULL.=0D @retval EFI_INVALID_PARAMETER InformationBlockSize is NULL.=0D =0D -**/ =0D +**/=0D EFI_STATUS=0D EFIAPI=0D UndiAipGetInfo (=0D @@ -396,7 +397,7 @@ UndiAipGetInfo ( @retval EFI_INVALID_PARAMETER InformationBlock is NULL.=0D @retval EFI_WRITE_PROTECTED The InformationType cannot be modifie= d using EFI_ADAPTER_INFO_SET_INFO().=0D =0D -**/ =0D +**/=0D EFI_STATUS=0D EFIAPI=0D UndiAipSetInfo (=0D @@ -427,7 +428,7 @@ UndiAipSetInfo ( @retval EFI_INVALID_PARAMETER InfoTypesBufferCount is NULL.=0D @retval EFI_OUT_OF_RESOURCES There is not enough pool memory to sto= re the results.=0D =0D -**/ =0D +**/=0D EFI_STATUS=0D EFIAPI=0D UndiAipGetSupportedTypes (=0D diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTes= tPointAip.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTe= stPointAip.c index a7fe9530cf..95d8c02b5a 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointA= ip.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointA= ip.c @@ -12,7 +12,7 @@ =0D This function returns information of type InformationType from the adapt= er.=0D If an adapter does not support the requested informational type, then=0D - EFI_UNSUPPORTED is returned. =0D + EFI_UNSUPPORTED is returned.=0D =0D @param[in] This A pointer to the EFI_ADAPTER_INFORMAT= ION_PROTOCOL instance.=0D @param[in] InformationType A pointer to an EFI_GUID that defines= the contents of InformationBlock.=0D @@ -22,10 +22,11 @@ =0D @retval EFI_SUCCESS The InformationType information was r= etrieved.=0D @retval EFI_UNSUPPORTED The InformationType is not known.=0D + @retval EFI_NOT_FOUND Information is not available for the = requested information type.=0D @retval EFI_DEVICE_ERROR The device reported an error.=0D @retval EFI_OUT_OF_RESOURCES The request could not be completed du= e to a lack of resources.=0D - @retval EFI_INVALID_PARAMETER This is NULL. =0D - @retval EFI_INVALID_PARAMETER InformationBlock is NULL. =0D + @retval EFI_INVALID_PARAMETER This is NULL.=0D + @retval EFI_INVALID_PARAMETER InformationBlock is NULL.=0D @retval EFI_INVALID_PARAMETER InformationBlockSize is NULL.=0D =0D **/=0D diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c b/Silicon/Marvell/= Drivers/Net/Pp2Dxe/Pp2Dxe.c index 5e463ac932..517b21940d 100644 --- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c +++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c @@ -1394,6 +1394,7 @@ Pp2DxeSnpInstall ( =0D @retval EFI_SUCCESS The InformationType information was r= etrieved.=0D @retval EFI_UNSUPPORTED The InformationType is not known.=0D + @retval EFI_NOT_FOUND Information is not available for the = requested information type.=0D @retval EFI_DEVICE_ERROR The device reported an error.=0D @retval EFI_OUT_OF_RESOURCES The request could not be completed du= e to a lack of resources.=0D @retval EFI_INVALID_PARAMETER This is NULL.=0D --=20 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115608): https://edk2.groups.io/g/devel/message/115608 Mute This Topic: https://groups.io/mt/104454915/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-