From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.10172.1607588630277980006 for ; Thu, 10 Dec 2020 00:23:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K7y8wwE+; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607588629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+rLFfaE7726na4Nntfcohuu5gR8Qo0Hhg9MWw0rdBSs=; b=K7y8wwE+3DqyKBD+Pg8hw5uDC4DxdsgNRH47X1RrVGW9cjYVBHDtTVfYskRCtdh725ILkE T7EObm0cic8KV/yEo/5QCVCzhpwSRjWlQSQmGnQXOJp+ULLOgvscLXpGU1oQ69TgabjpsU yEulPxK/x96OKbUAirhCIVRgEDzLMlU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-WYv8e-NkMQiXDvoLQl5Pdg-1; Thu, 10 Dec 2020 03:23:41 -0500 X-MC-Unique: WYv8e-NkMQiXDvoLQl5Pdg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D81E9180A086; Thu, 10 Dec 2020 08:23:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-52.ams2.redhat.com [10.36.113.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 47819620DE; Thu, 10 Dec 2020 08:23:36 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg: start using the ECC plugin exception list To: Sean Brogan , Ard Biesheuvel , devel@edk2.groups.io, James Bottomley Cc: Jordan Justen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Tom Lendacky , "Leif Lindholm (Nuvia address)" References: <20201204032116.31321-1-lersek@redhat.com> <20201204032116.31321-2-lersek@redhat.com> <7c57b6dc-de1a-8f2b-9b40-c1faf9b46bfe@redhat.com> <6989494d-4dca-6a92-d748-9c413206e781@arm.com> <3b931320-5afb-0dae-e8d2-f2e56be88177@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 10 Dec 2020 09:23:35 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12/08/20 19:45, Sean Brogan wrote: > Laszlo, > > Trying to understand this. > > > On 12/7/2020 5:56 PM, Laszlo Ersek wrote: >> ... I would still much prefer of course if that patch (= the exception >> to GuidCheck) could simply be included in James's series. > > > The PR based CI runs on the entire series.  It does not run on > individual commits and thus you can add this to the series and in fact i > would suggest it get added to the series.  Any changes in the series > will take effect when running the CI. That sounds great, thank you. I must have misunderstood something in the past. I distinctly remember coming away from a discussion somewhere with the lesson that CI tweaking had to be done in a separate PR. Perhaps I mistook an explanation. I guess my mental image was that the CI run started on "master", grabbing its config from the files in "master", and then checking out or otherwise applying the patches for the subject series. If CI indeed *launches* while standing at the HEAD of the topic branch, then that's great. (I know from my local CI experimentation that it just runs on whatever commit I have checked out, modulo uncommitted changes per -- but I didn't know if the CI environment inside github / azure was the same.) > > This is great for how Project Mu uses "PR gates" because we squash merge > but in Edk2 with a patch series this can mean that commits in the middle > can break things.  It is on developer and reviewer to catch those types > of things. > > For this case why can't this change be part of the commit that > introduces the guid/global? I agree that it should be. > > Or if that is undesirable you should be able to add the ignore in a > commit prior to introduction and then you would never have a break. > Either way there is no reason this isn't part of a single series. Sounds great, thank you. I actually prefer it to be part of the same commit. Here's what I'm proposing / requesting: (1) Sean, could you please (pretty please :) ) submit the second patch Disable EccCheck for OvmfPkg CI from your demo PR at https://edk2.groups.io/g/devel/message/68541 https://github.com/tianocore/edk2/pull/1201 stand-alone to the list, so that Ard or myself can ACK it and merge it separately? (2) Subsequently, I'm going to take the 2nd patch of the present series, to which Ard's R-b applies as well: https://edk2.groups.io/g/devel/message/68451 and I'll *squash it* into James's [PATCH v3 3/6] OvmfPkg/AmdSev: add Grub Firmware Volume Package And then I'll merge that v3 series. Thank you! Laszlo