From: "David Woodhouse" <dwmw2@infradead.org>
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Ray Ni <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 7/7] OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled
Date: Tue, 25 Jun 2019 13:07:51 +0100 [thread overview]
Message-ID: <ae310e69c4711553a7a3f7b178c0594592db7d55.camel@infradead.org> (raw)
In-Reply-To: <a1164788-ee14-74c1-f838-c629c6045986@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
On Tue, 2019-06-25 at 01:50 +0200, Laszlo Ersek wrote:
> (1) Side request -- can you please set the "xfuncname" knob so that the
> diff hunk headers (@@) reflect the section name being modified?
>
> It's explained at
> <https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers>,
> and it can be automated by "BaseTools/Scripts/SetupGit.py".
Oops, sorry. Missed that part; will go set it up now for next time.
> (2) For the patch. I'd prefer
> - setting PcdPciMmio64Base to zero unconditionally, and
> - setting PcdPciMmio64Size unconditionally as well, just to different
> values, dependent on CSM_ENABLE.
I did that.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
prev parent reply other threads:[~2019-06-25 12:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 22:31 [PATCH 1/7] OvmfPkg/LegacyBios: set NumberBbsEntries to the size of BbsTable David Woodhouse
2019-06-21 22:31 ` [PATCH 2/7] OvmfPkg/LegacyBbs: Add boot entries for VirtIO and NVME devices David Woodhouse
2019-06-24 22:46 ` [edk2-devel] " Laszlo Ersek
2019-06-21 22:31 ` [PATCH 3/7] OvmfPkg: Don't build in QemuVideoDxe when we have CSM David Woodhouse
2019-06-21 22:31 ` [PATCH 4/7] MdeModulePkg/UefiBootManagerLib: export EfiBootManagerGetBootDescription() David Woodhouse
2019-06-24 22:36 ` [edk2-devel] " Laszlo Ersek
2019-06-25 2:00 ` Ni, Ray
2019-06-25 8:00 ` David Woodhouse
2019-06-21 22:31 ` [PATCH 5/7] OvmfPkg/LegacyBiosDxe: Use EfiBootManagerGetBootDescription() David Woodhouse
2019-06-24 23:03 ` [edk2-devel] " Laszlo Ersek
2019-06-21 22:31 ` [PATCH 6/7] MdeModulePkg/UefiBootManagerLib: describe VirtIO devices correctly David Woodhouse
2019-06-24 23:16 ` [edk2-devel] " Laszlo Ersek
2019-06-25 1:44 ` Ni, Ray
2019-06-25 7:40 ` David Woodhouse
2019-06-25 8:06 ` Ni, Ray
2019-06-25 8:28 ` David Woodhouse
2019-06-25 9:15 ` Ni, Ray
2019-06-25 9:28 ` David Woodhouse
2019-06-25 9:56 ` Ni, Ray
2019-06-25 11:27 ` David Woodhouse
2019-06-21 22:31 ` [PATCH 7/7] OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled David Woodhouse
2019-06-24 23:50 ` [edk2-devel] " Laszlo Ersek
2019-06-25 12:07 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae310e69c4711553a7a3f7b178c0594592db7d55.camel@infradead.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox