On Tue, 2019-06-25 at 01:50 +0200, Laszlo Ersek wrote:
> (1) Side request -- can you please set the "xfuncname" knob so that the
> diff hunk headers (@@) reflect the section name being modified?
> 
> It's explained at
> <https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers>,
> and it can be automated by "BaseTools/Scripts/SetupGit.py".


Oops, sorry. Missed that part; will go set it up now for next time.

> (2) For the patch. I'd prefer
> - setting PcdPciMmio64Base to zero unconditionally, and
> - setting PcdPciMmio64Size unconditionally as well, just to different
> values, dependent on CSM_ENABLE.

I did that.