From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by mx.groups.io with SMTP id smtpd.web11.8386.1585132344765061358 for ; Wed, 25 Mar 2020 03:32:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=qRuyqiIL; spf=pass (domain: oracle.com, ip: 156.151.31.86, mailfrom: liran.alon@oracle.com) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02PATDiJ021586; Wed, 25 Mar 2020 10:32:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=8CsQ9R8QNrA3NGEzbhW3xcOvjD/eNtA0rF2CGCA9eNo=; b=qRuyqiILVKa3DaxDoKQYfgkd15iQCiqLKjWSXpDRPw8xhflDkzM0OOH4u+3wxVYK+vsh Chom7o0nSF2/BG6mzbTyxaHItPjxuibuxZ1CdeVS4g0ltjHZbpsfZztPNjyObycFIdd7 sHW39mNwobgxRntwFbhLINDqXoXOdD4qBt9v5VxgsYwen1XUOc04HZa8ciUlNnPsBFl1 yzK5XHAlnd3/9TDP5RbRtMDaING7Rnrv6MASYwSV8IXMMqBDLDKcdMA7NZ9583dC+oJ+ l0aUCyDkVERdJYqeIdX4vn5TWupI/W269Jo+RRzH+gp9swJE1mX4OF6HmW3yv7MFHerp 6w== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2ywabr8yqx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Mar 2020 10:32:24 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02PAST58045148; Wed, 25 Mar 2020 10:32:23 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2yxw4r82e2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Mar 2020 10:32:23 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 02PAWMKh018947; Wed, 25 Mar 2020 10:32:22 GMT Received: from [192.168.14.112] (/109.67.220.136) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Mar 2020 03:32:22 -0700 Subject: Re: [edk2-devel] [PATCH 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit To: Laszlo Ersek , devel@edk2.groups.io Cc: nikita.leshchenko@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org References: <20200316150113.104630-1-liran.alon@oracle.com> <20200316150113.104630-10-liran.alon@oracle.com> <97fa0b88-b64e-7c1d-5210-7f56aa16df34@redhat.com> <6d12f888-6614-244a-8204-895100b6d6f6@oracle.com> <378e02ab-582a-01db-132e-3a7b5d56844a@redhat.com> From: "Liran Alon" Message-ID: Date: Wed, 25 Mar 2020 12:32:17 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <378e02ab-582a-01db-132e-3a7b5d56844a@redhat.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9570 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003250090 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9570 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003250090 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 25/03/2020 3:48, Laszlo Ersek wrote: > On 03/24/20 16:35, Liran Alon wrote: >> On 24/03/2020 17:14, Laszlo Ersek wrote: >>> On 03/16/20 16:01, Liran Alon wrote: >>> I'm going to stop reviewing this iteration now; please rework the rest >>> of the series for v2 with this resource management pattern. >>> >>> Thanks! >>> Laszlo >> Thanks for the very detailed review! >> >> I have read all your comments and understood them. I am working on >> creating a v2 patch-series with all these fixed. >> As the Init/UnInit logic is the only place in which this resource >> management pattern is done, and as patch-series is split >> to small well-defined quite independent patches, can I request that you >> will complete review of all v1 patches? >> >> I will understand if you are too busy for this, but it will allow me to >> take into account all your aggregated comments on v1 >> to hopefully create a perfect v2 patch-series. As I've tried taking into >> account all the comments you gave on Nikita's series. > I ended up doing a superficial run over the rest of the series, before > arriving at this email of yours. > > Unfortunately, in the most "meaty" patches, there are many style issues, > and they kept throwing me off. It's difficult to ping-pong between style > remarks and semantics. Basically, in those patches, I'm asking for style > fixes now, so I have a chance at a more substantial review with v2. > > Thanks > Laszlo > Thanks for reviewing also the other patches for style issues as-well. This is what I requested. This will assist me in submitting a much more ready v2 submission. I'm currently working on it and hope to have a v2 submission later today with all your fixes and suggestions applied. Highly appreciate your detailed review comments. Thanks, -Liran