From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smarthost01a.ixn.mail.zen.net.uk (smarthost01a.ixn.mail.zen.net.uk [212.23.1.20]) by mx.groups.io with SMTP id smtpd.web08.2102.1644528372720553266 for ; Thu, 10 Feb 2022 13:26:13 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=parse error for token &{10 18 sdn.klaviyomail.com}: permanent DNS error (domain: starlabs.systems, ip: 212.23.1.20, mailfrom: sean@starlabs.systems) Received: from [217.155.46.38] (helo=sean-StarBook.lan) by smarthost01a.ixn.mail.zen.net.uk with esmtp (Exim 4.90_1) (envelope-from ) id 1nIGx8-0000UU-GM; Thu, 10 Feb 2022 21:26:10 +0000 From: "Sean Rhodes" To: devel@edk2.groups.io Cc: hao.a.wu@intel.com, Matt DeVillier Subject: [PATCH 12/18] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal Date: Thu, 10 Feb 2022 21:26:08 +0000 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 X-Originating-smarthost01a-IP: [217.155.46.38] Feedback-ID: 217.155.46.38 Content-Transfer-Encoding: quoted-printable From: Matt DeVillier Recent model Chromebooks only return ACK, but not BAT_SUCCESS, which causes hanging and failed ps2k init. To mitigate this, make the absence of BAT_SUCCESS reply non-fatal, and reduce the no-reply timeout from 4s to 1s. Tested on google/dracia and purism/librem_14 Signed-off-by: Matt DeVillier --- MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c b/MdeModul= ePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c index 77dc226222..981309f8b0 100644 --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c @@ -1731,13 +1731,7 @@ InitKeyboard ( //=0D // wait for BAT completion code=0D //=0D - mWaitForValueTimeOut =3D KEYBOARD_BAT_TIMEOUT;=0D -=0D - Status =3D KeyboardWaitForValue (ConsoleIn, KEYBOARD_8048_RETURN_8042_= BAT_SUCCESS);=0D - if (EFI_ERROR (Status)) {=0D - KeyboardError (ConsoleIn, L"Keyboard self test failed!\n\r");=0D - goto Done;=0D - }=0D + KeyboardWaitForValue (ConsoleIn, KEYBOARD_8048_RETURN_8042_BAT_SUCCESS= );=0D =0D mWaitForValueTimeOut =3D KEYBOARD_WAITFORVALUE_TIMEOUT;=0D =0D --=20 2.32.0