From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DEF3181C0F for ; Thu, 12 Jan 2017 02:23:14 -0800 (PST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9535861B8E; Thu, 12 Jan 2017 10:23:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-42.phx2.redhat.com [10.3.116.42]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0CANDJW005466; Thu, 12 Jan 2017 05:23:14 -0500 To: Jiaxin Wu , edk2-devel@ml01.01.org References: <1484211156-94292-1-git-send-email-jiaxin.wu@intel.com> Cc: Ye Ting , Ruiyu Ni , Fu Siyuan , Gary Ching-Pang Lin From: Laszlo Ersek Message-ID: Date: Thu, 12 Jan 2017 11:23:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484211156-94292-1-git-send-email-jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 12 Jan 2017 10:23:15 +0000 (UTC) Subject: Re: [Patch 0/2] Enable the HTTP switch X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 10:23:15 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 01/12/17 09:52, Jiaxin Wu wrote: > If the value of PcdHttpEnable is TRUE, HTTP is enabled. Both the > "http://" and "https://" schemes are acceptable. Otherwise, HTTP > is disabled. The "http://" scheme will be denied. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Wu Jiaxin > > Jiaxin Wu (2): > NetworkPkg: Add PCD to enable the HTTP switch > Nt32Pkg.dsc: Add HTTP_ENABLE flag > > NetworkPkg/HttpBootDxe/HttpBootClient.c | 20 +++++++- > NetworkPkg/HttpBootDxe/HttpBootConfig.c | 81 ++++++++++++++++++++------------ > NetworkPkg/HttpBootDxe/HttpBootDxe.inf | 5 +- > NetworkPkg/HttpBootDxe/HttpBootSupport.c | 53 ++++++++++++++++++++- > NetworkPkg/HttpBootDxe/HttpBootSupport.h | 17 ++++++- > NetworkPkg/HttpDxe/HttpDxe.inf | 5 +- > NetworkPkg/HttpDxe/HttpImpl.c | 12 ++++- > NetworkPkg/NetworkPkg.dec | 8 +++- > Nt32Pkg/Nt32Pkg.dsc | 9 ++++ > 9 files changed, 173 insertions(+), 37 deletions(-) > What is the reasoning behind this change? If a platform doesn't want to support HTTP booting, it can just exclude the drivers from the build. Put differently, what use do HttpBootDxe and HttpDxe have if the PCD is set to FALSE (which is the default)? I'm asking because OVMF already has a HTTP_BOOT_ENABLE build flag, and it controls the inclusion of all of: NetworkPkg/DnsDxe/DnsDxe.inf NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf NetworkPkg/HttpDxe/HttpDxe.inf NetworkPkg/HttpBootDxe/HttpBootDxe.inf So what will this NetworkPkg change mean for OVMF, if OVMF is built with -D HTTP_BOOT_ENABLE? Thanks Laszlo