From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BE64581DF8 for ; Tue, 17 Jan 2017 12:13:25 -0800 (PST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6D3A83F46; Tue, 17 Jan 2017 20:13:26 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-70.phx2.redhat.com [10.3.116.70]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0HKDPOU032737; Tue, 17 Jan 2017 15:13:25 -0500 To: Jordan Justen , Gary Lin , edk2-devel@ml01.01.org, Qin Long References: <20170117045232.4765-1-glin@suse.com> <148464155549.31945.2690363917914543246@jljusten-ivb> From: Laszlo Ersek Message-ID: Date: Tue, 17 Jan 2017 21:13:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <148464155549.31945.2690363917914543246@jljusten-ivb> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 17 Jan 2017 20:13:26 +0000 (UTC) Subject: Re: [PATCH 0/3] Enable HTTPS Boot in OVMF X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 20:13:25 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 01/17/17 09:25, Jordan Justen wrote: > On 2017-01-16 20:52:29, Gary Lin wrote: >> This series adjusts the build files of OVMF in order to support HTTPS. >> It introdues a new build option, TLS_ENABLE, and makes OpenSSL a hard >> requirement to enable IPv6 support. >> >> Gary Lin (3): >> OvmfPkg: always resolve OpenSslLib, IntrinsicLib and BaseCryptLib > > Ok. I see that OpenSSL will still not be a dependency, unless one of > the dependent features is enabled. (And, they are all disabled by > default.) > > Series Reviewed-by: Jordan Justen > > But, I'll let Laszlo take a look too. My sincere apologies to you and Qin Long for missing your R-b tags. In retrospect, the Received headers in those messages are consistent with the Date fields, so the messages did arrive in time (before my commit / response) in my IMAP inbox. I must have missed them for one of two reasons: - my local OfflineIMAP sync glitched out temporarily (unlikely!), or - these messages appeared only in my edk2-devel list folder, and not in my INBOX (likely). In order to decrease the likelihood of such mess-ups on my end in the future, Gary, can you please ensure that you copy the complete set of Cc: tags from across the patches to the blurb? This is good for two goals: first, everyone CC'd on at least one patch will understand the big picture from the blurb; second, feedback from people who (correctly) hit "Reply All" on the blurb will reach everyone else too. (I recommend this practice in , under the last bullet.) Nonetheless, missing this feedback is my fault; I should have waited a bit longer, and double-checked the list folder right before pushing. I'm sorry! Laszlo > Thanks, > > -Jordan > >> OvmfPkg: correct the set of modules included for the IPv6 stack >> OvmfPkg: pull in TLS modules with -D TLS_ENABLE (also enabling HTTPS) >> >> OvmfPkg/OvmfPkgIa32.dsc | 29 ++++++++++++++++------------- >> OvmfPkg/OvmfPkgIa32.fdf | 8 ++++---- >> OvmfPkg/OvmfPkgIa32X64.dsc | 29 ++++++++++++++++------------- >> OvmfPkg/OvmfPkgIa32X64.fdf | 8 ++++---- >> OvmfPkg/OvmfPkgX64.dsc | 29 ++++++++++++++++------------- >> OvmfPkg/OvmfPkgX64.fdf | 8 ++++---- >> 6 files changed, 60 insertions(+), 51 deletions(-) >> >> -- >> 2.11.0 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >