From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.20230.1574166357606288996 for ; Tue, 19 Nov 2019 04:25:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hw6+uu3s; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574166356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pqxUumXOTxLn5W+FbCnqThb6gTp+7Wwzc7XmLLYDJCs=; b=hw6+uu3sG2FO+6TRiAVQjx+jUKKdJFrma5058ALIIH3EbgK+fjO+h4kkZfEnwA1KlxelQA 3v6MsvxzP59mycev9ymMZAECs7QnKVe/yFYXk2VFVUzHIRXHKvLoBee5x62cHDux/AIovS phT4zklu1hgaRCY5KucND4qJDrKicVQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-fnX8gJEnNLyuP77_bVH36Q-1; Tue, 19 Nov 2019 07:25:54 -0500 Received: by mail-wr1-f72.google.com with SMTP id w4so18194294wro.10 for ; Tue, 19 Nov 2019 04:25:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2tk4LD//QtOD8Aux5Wal9CFhqJfMIY5z01kVTfFJMGo=; b=rn5/x32z7/vLCVDYXb0kOW3+rhUWHEQsl5MOVESl1lZZecew/SN6wFW38Wnq9pY/ar W8jF7UWVmrcH74HdjcJRbadmZHjRjkUFZ4Fa66SRkbtU9tbWi785Csu9a47bK/+xwCxX u5KxR4AhCeERpjC2NrIH7N3aD+huFkihfJwj8NuuBY0gR1jgdV4BKgw9vrANf/lrk1XW WvfdwhmnR983V5VVKtk9kS0vD2a1uK974MHenGToqX75Wi17YxMZbpv/v5ZWrX46vUob FPl+SZ3ZTyVbCKYsCfsUV0pLlIn8MMVR0jj6dtP4bMA7QOWdxjHXKx6MUrV/NwZgUss3 g0Ew== X-Gm-Message-State: APjAAAUmeoH5w7776yVtVSg5w+ELunqaRpvD32+af70KH5DnK+F9/VB2 d9/IPmPHrm1D5rZAxAeL/A2e6gXIgG53pFtkFoH7hVnNUc7Ty82jEX6/gM8NELtkTgrVN6XHhQ8 4xV/EOR7ChNnmzg== X-Received: by 2002:a5d:570a:: with SMTP id a10mr15520689wrv.107.1574166353472; Tue, 19 Nov 2019 04:25:53 -0800 (PST) X-Google-Smtp-Source: APXvYqw3Svps/IgVjOIuuoJYgZnQUDSiJj8kmMkTMDZQvMK8ZtWNTEehDMm2D7yq06LRw0drkCET4Q== X-Received: by 2002:a5d:570a:: with SMTP id a10mr15520669wrv.107.1574166353257; Tue, 19 Nov 2019 04:25:53 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id 65sm31488092wrs.9.2019.11.19.04.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2019 04:25:52 -0800 (PST) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/7] Platform/RPi: Add missing model name To: Leif Lindholm , devel@edk2.groups.io Cc: Pete Batard , ard.biesheuvel@linaro.org, samer.el-haj-mahmoud@arm.com, Laszlo Ersek References: <20191119113809.2472-1-pete@akeo.ie> <20191119113809.2472-2-pete@akeo.ie> <23bdf10d-77fd-542e-2e99-65827d09a4ba@redhat.com> <20191119121408.GA7323@bivouac.eciton.net> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 19 Nov 2019 13:25:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191119121408.GA7323@bivouac.eciton.net> X-MC-Unique: fnX8gJEnNLyuP77_bVH36Q-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/19/19 1:14 PM, Leif Lindholm wrote: > On Tue, Nov 19, 2019 at 01:02:20PM +0100, Philippe Mathieu-Daud=C3=A9 wro= te: >> On 11/19/19 12:38 PM, Pete Batard wrote: >>> From: Samer El-Haj-Mahmoud >>> >>> Add a missing entry for the "Raspberry Pi Compute Module 3+" in >>> RpiFirmwareGetModelName (). >>> >>> Signed-off-by: Leif Lindholm >> >> I feel really lost with how the S-o-b are handled. >=20 > Signed-off-by, as per https://developercertificate.org/, starts off > with "By making a contribution to this project, I certify that:". >=20 > That is only a valid statement at the point of contributing code to a > project. It is also only a valid statement when given by the person > contributing it. Samer has authored this code, but he has not > contributed it. >=20 > My own litmus test is the legal usefulness of the statament > "Samer said he signed the contract.". I just asked clarification on another thread and now see this reply. Now I understand that while being the author, Samer did not contributed=20 his code to the project. Then by forwarding his work, Pete is a=20 contributor signing the certificate. If Samer did not sign the=20 certificate in front of the project (by posting his work), then Pete can=20 not sign on his behalf. Phew. >> I'd have expected, Samer as the author, signs it. Pete forwards it, then >> Leif refactors a bit by extracting a part of the previous bigger patch. >> So: >> >> Signed-off-by: Samer El-Haj-Mahmoud >> Signed-off-by: Pete Batard >> Signed-off-by: Leif Lindholm >=20 > What might be confusing you is where a set is collaboratively > developed, or where multiple patch sets are smashed together to be > merged atomically; when someone other than the poster has previously > contributed a given patch to the project but it is being *reposted* by > someone else to the same project, it is customary to include the > original Signed-off-by, since it still applies. Correct. > Similarly, when non-trivial changes are made by a maintainer (or > whoever reposted the patches), the maintainer *should* add their own > S-o-b - something that is usually done after a line briefly explaining > [which changes were done] Yes, agreed. > . >=20 > (You will however find that different maintainers have different > opinion of what constitutes "trivial".) Thanks for the clear explanation! Phil.