From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.3460.1610726395811125270 for ; Fri, 15 Jan 2021 07:59:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bW2CH6C0; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610726395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pn4Rd4OV5vwOpSQzPpXvfAJ4DerPBGc/hnPBJd6Tp8I=; b=bW2CH6C0Kez6n2NIOCysBFLLtPs1us5bTNNcAxiEYFe9EyKqEwykuvRMW3uCaF3aLtSeP1 KC9TCRY35nusHQvxlLwKPYrNKQR45ujw6jZNUJ4G5y8utmamuOvpIqlAtBXwFNl6JsdGzM P1lzA9eXajazZEdaRlgFN/eohsN1g0g= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-m1eya8JVO_66ENdaPuyzBg-1; Fri, 15 Jan 2021 10:59:49 -0500 X-MC-Unique: m1eya8JVO_66ENdaPuyzBg-1 Received: by mail-ej1-f71.google.com with SMTP id f26so3752161ejy.9 for ; Fri, 15 Jan 2021 07:59:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pn4Rd4OV5vwOpSQzPpXvfAJ4DerPBGc/hnPBJd6Tp8I=; b=dqc8Fhq0LcoQROSvJyydrRzorpLn/IQ9fQCsonviYD0u3vg6n2+KbTRhaEF+sm42H8 7NcDw99D70P/pouskfpupbG2dADY0Tv8CJvHbv3OPkQXGkTfZsMg9NlF8aFas3e2KZix tWBXgOYqqnh+nM774i67UX5cU9qnK7XWvPSGGa609S2Ud+m4up3YXnQPNyFn2wE9y12u tGfrOFEfTPDbK42d234T+rdulWZ+DqpvaWgip8sEIwoVXi7OFWyma0NigCAM/dvNiNwg b/1sX7CxHTPYRBkVVq4nOLnDlDZ/HTstDQjO+xgOkL2aIXlnOxe7P7ZWeb3N4A1S5YBw A40g== X-Gm-Message-State: AOAM531/hwbNRfIqsoBSey0X2xs+QsyMnFz0X7mxBTspJEo+hcEbT1XI XtQYW6rLqdh/G9g6aBJe8Lvyf5osqK3uExW/6503pajWoTGw0PVZqXomygHurssTRXGLf0l3/NP RTgGttdQG92YICg== X-Received: by 2002:a17:906:d8a3:: with SMTP id qc3mr9514053ejb.443.1610726387965; Fri, 15 Jan 2021 07:59:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8E61Nx3+t5c3XaZ+MvtnAkofhtXU03DCvX0yx/AVeLgGg27uTPVUyfzj/RGlrZ/S13VpyMg== X-Received: by 2002:a17:906:d8a3:: with SMTP id qc3mr9514047ejb.443.1610726387822; Fri, 15 Jan 2021 07:59:47 -0800 (PST) Return-Path: Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id f5sm3736419ejz.70.2021.01.15.07.59.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jan 2021 07:59:47 -0800 (PST) Subject: Re: [PATCH v2 03/10] ArmVirtPkg: raise PcdShellFileOperationSize to 128KB To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm References: <20210113085453.10168-1-lersek@redhat.com> <20210113085453.10168-4-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Fri, 15 Jan 2021 16:59:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113085453.10168-4-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 1/13/21 9:54 AM, Laszlo Ersek wrote: > Some UEFI shell commands read and write files in chunks. The chunk size is > given by "PcdShellFileOperationSize", whose default in > "ShellPkg/ShellPkg.dec" is 4KB (0x1000). > > The virtio-fs daemon of QEMU advertizes a 128KB maximum buffer size by > default, for the FUSE_WRITE operation. > > By raising PcdShellFileOperationSize 32-fold, the number of FUSE write > requests shrinks proportionately, when writing large files. And when a > Virtio Filesystem is not used, a 128KB chunk size is still not > particularly wasteful. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3125 > Signed-off-by: Laszlo Ersek > Acked-by: Ard Biesheuvel > --- > > Notes: > v2: > - no changes > - pick up Ard's A-b > > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > 2 files changed, 2 insertions(+) (Similar comment that OVMF patch, QEMU should advertise properly the maximum buffer size). Reviewed-by: Philippe Mathieu-Daude