public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Qingyu" <qingyu.shang@intel.com>
To: devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
	Zhichao Gao <zhichao.gao@intel.com>, Chao Li <lichao@loongson.cn>
Subject: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx
Date: Mon, 11 Mar 2024 16:41:14 +0800	[thread overview]
Message-ID: <aea814f75bb429abf1f2769edd195ad8810f2aed.1710145917.git.qingyu.shang@intel.com> (raw)
In-Reply-To: <cover.1710145917.git.qingyu.shang@intel.com>

Refer to Uefi spec 2.10 section 13.3.3, Add a new retval
EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx
and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke().

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Qingyu <qingyu.shang@intel.com>
---
 ShellPkg/Application/Shell/ConsoleWrappers.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Application/Shell/ConsoleWrappers.c b/ShellPkg/Application/Shell/ConsoleWrappers.c
index eae11370e4e0..dbffae30cdf5 100644
--- a/ShellPkg/Application/Shell/ConsoleWrappers.c
+++ b/ShellPkg/Application/Shell/ConsoleWrappers.c
@@ -67,7 +67,9 @@ FileBasedSimpleTextInReset (
   @param[in] This      A pointer to the SimpleTextIn structure.
   @param[in, out] Key  A pointer to the Key structure to fill.
 
-  @retval   EFI_SUCCESS The read was successful.
+  @retval EFI_SUCCESS      The read was successful.
+  @retval EFI_UNSUPPORTED  The device does not support the ability to read
+                           keystroke data.
 **/
 EFI_STATUS
 EFIAPI
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116682): https://edk2.groups.io/g/devel/message/116682
Mute This Topic: https://groups.io/mt/104886872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-03-12 15:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11  8:41 [edk2-devel] [PATCH 0/4] Update the comments of ReadKeyStroke and ReadKeyStrokeEx Qingyu
2024-03-11  8:41 ` [edk2-devel] [PATCH 1/4] MdeModulePkg: " Qingyu
2024-03-11  8:41 ` Qingyu [this message]
2024-03-13  2:12   ` [edk2-devel] [PATCH 2/4] ShellPkg: " Chao Li
2024-03-25  6:15     ` Gao, Zhichao
2024-03-25  6:12   ` Gao, Zhichao
2024-03-11  8:41 ` [edk2-devel] [PATCH 3/4] EmbeddedPkg: " Qingyu
2024-03-11  8:41 ` [edk2-devel] [PATCH 4/4] EmulatorPkg: " Qingyu
2024-03-13  4:54 ` 回复: [edk2-devel] [PATCH 0/4] " gaoliming via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aea814f75bb429abf1f2769edd195ad8810f2aed.1710145917.git.qingyu.shang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox