Re: [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support

[Pete Batard <pete@akeo.ie>]

Awesome!

Thanks a lot to all the people on this list who helped with the review 
process, provided advice, or tested this series.

Regards,

/Pete

On 2019-02-15 12:05, Ard Biesheuvel wrote:
> On Fri, 15 Feb 2019 at 11:27, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>
>> On Wed, 13 Feb 2019 at 04:50, Jeremy Linton <jeremy.linton@arm.com> wrote:
>>>
>>> the
>>> Hi,
>>>
>>> On 2/5/19 10:25 AM, Pete Batard wrote:
>>>> Changes for v5:
>>>>
>>>> * Raspberry/Pi3 -> RaspberryPi/RPi3
>>>> * Remove VirtualRealTimeClockLib as well as BUILD_EPOCH macro (use the upcoming
>>>>     EmbeddedPkg Virtual RTC from EDK2 instead)
>>>> * Use $(PLATFORM_NAME) where possible in .dsc and .fdf
>>>> * Update Readme to remove build instructions, describe ACPI limitations, fix
>>>>     ATF Readme link and split OS installation & test notes into a separate file.
>>>> * Add -Wl,--fix-cortex-a53-843419 to LINK_FLAGS
>>>>
>>>> IMPORTANT: Due to the removal of VirtualRealTimeClockLib this series requires
>>>> https://lists.01.org/pipermail/edk2-devel/2019-February/036301.html to have
>>>> been applied to your edk2 repository.
>>>
>>> I would just like to congratulate everyone working on this port. It is
>>> crazy awesome! I just applied these patches, followed the readme
>>> instructions for the SD card. Then grabbed a USB DVD drive, and a USB
>>> SSD, plugged in a keyboard/mouse/monitor/network and booted the fedora
>>> 29 1.2 install ISO. The graphical installer ran as expected, system
>>> installed as expected, and other than the nextboot not being reset (had
>>> to update it via the BDS, as is documented) it "just worked".
>>>
>>> There are a few rough edges here/there but the idea that we have another
>>> ARM machine that almost behaves like one expects a modern computing
>>> device to behave, is wonderful. The only real gocha continues to be the
>>> rpi's well known shortcomings, including the fact that it took nearly 6
>>> hours to install.
>>>
>>>
>>> so,
>>>
>>> Tested-by: Jeremy Linton <jeremy.linton@arm.com>
>>>
>>
>> Thanks Jeremy.
>>
>> I fully agree, and I am quite happy to have an example to point to the
>> next time someone wants to contribute some 96boards UEFI port that
>> looks like u-boot and only runs on the serial port
> 
> For the series
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> edk2-non-osi pieces pushed as
> 
> 863a3237a74c Platform/RaspberryPi/RPi3: Add ATF binaries
> 9c52bc5c0f14 Platform/RaspberryPi/RPi3: Add Device Tree binaries
> 635f97e09aaa Platform/RaspberryPi/RPi3: Add logo driver
> 
> edk2-platforms pieces pushed as 06454982de98..94d6843f1a90
> 
> Thanks again, Pete, and everyone else for the excellent work.
> 
> /me goes and updates his blog
>