From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BDC3620886F36 for ; Fri, 15 Feb 2019 06:56:52 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id l5so9563271wrw.6 for ; Fri, 15 Feb 2019 06:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0V32Eo1KrBkW0LM+994UPDkYZBl9FhF2iH/mktMe/K4=; b=S11h8TJNSxZsyVZggsrKArDHXf+fbSrXAWDivaPmHlRWXSoh+Hb0uWDLm76F/mnM6Y /dGqsCpFpDmlMv5jP15oUBfrU/NLcvAbbEveeCYVXo5ee+rxu4vR8YBCl1I379WMbAST LRjxNjizAmtALBMmD9gwOC5B5zUZvTqRfFPZGaHu2VcbFOSA0HfZSLn4C29AHUPAgABa KHZb2ZapjcLBlM3Q/9qkMMW/JZY0NQSuUtMdDNzADvBWteI6hjkknQIBqkELuwsXS6KX EQdhQpyZe0PSlXuEOMYhvXK5BTJc8GhNmJprsd+iR5GY/ME2NAw8lZv5nVEQwRVIKWyB X12A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0V32Eo1KrBkW0LM+994UPDkYZBl9FhF2iH/mktMe/K4=; b=DV41PuBX21gqyqeyq99i6DdF2xaFys29gw/OkNG8TRstEkq5YXU8bPVmunxu+6Ozh0 Q0E8JUssZnNQFS7w8l7Ydi1TzIfrTkKDaRYJwy1YxlQFl/ZrNCZXUY//3B1gIgHRt9zK Cb9wx8AYnFBKqt8A7IvE8fHyooDtmh64qLc7A5LJaF6eRj6SSYC1fZkiGyJIod7u0mea n7oIQkr3AMJ4B7xfr+NQ2p68qLrwvZg5oB5Glb/Qbi/CjiFa+YhvoE47OcgGytZfJh/n KEWCkOMu35QXrBcPV992+P0y01gmKX07rHaAo9oMyYoM55N46NbMfCx7H01ViZkrv+k1 hcnA== X-Gm-Message-State: AHQUAuY1mkvfZb2TiRV/NRmS8dX9MM912jNk6q+7jteXQplH8dbWtz08 7UoYjhEG3sIYipnDPkGiZzI7uBPbIUE= X-Google-Smtp-Source: AHgI3IbJbhciC1Mwn9q6Yl92VpdjcCiDdSG7yqITCT62JIOnXhmeETo+G66j8JECEsyjWeaO206m2Q== X-Received: by 2002:adf:f28f:: with SMTP id k15mr7374500wro.272.1550242610449; Fri, 15 Feb 2019 06:56:50 -0800 (PST) Received: from [192.168.0.10] (gge44-1-78-198-200-53.fbx.proxad.net. [78.198.200.53]) by smtp.googlemail.com with ESMTPSA id p9sm1329392wmc.14.2019.02.15.06.56.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 06:56:49 -0800 (PST) To: Ard Biesheuvel , Jeremy Linton Cc: "edk2-devel@lists.01.org" References: <20190205162537.6472-1-pete@akeo.ie> From: Pete Batard Message-ID: Date: Fri, 15 Feb 2019 15:56:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 X-List-Received-Date: Fri, 15 Feb 2019 14:56:53 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Awesome! Thanks a lot to all the people on this list who helped with the review process, provided advice, or tested this series. Regards, /Pete On 2019-02-15 12:05, Ard Biesheuvel wrote: > On Fri, 15 Feb 2019 at 11:27, Ard Biesheuvel wrote: >> >> On Wed, 13 Feb 2019 at 04:50, Jeremy Linton wrote: >>> >>> the >>> Hi, >>> >>> On 2/5/19 10:25 AM, Pete Batard wrote: >>>> Changes for v5: >>>> >>>> * Raspberry/Pi3 -> RaspberryPi/RPi3 >>>> * Remove VirtualRealTimeClockLib as well as BUILD_EPOCH macro (use the upcoming >>>> EmbeddedPkg Virtual RTC from EDK2 instead) >>>> * Use $(PLATFORM_NAME) where possible in .dsc and .fdf >>>> * Update Readme to remove build instructions, describe ACPI limitations, fix >>>> ATF Readme link and split OS installation & test notes into a separate file. >>>> * Add -Wl,--fix-cortex-a53-843419 to LINK_FLAGS >>>> >>>> IMPORTANT: Due to the removal of VirtualRealTimeClockLib this series requires >>>> https://lists.01.org/pipermail/edk2-devel/2019-February/036301.html to have >>>> been applied to your edk2 repository. >>> >>> I would just like to congratulate everyone working on this port. It is >>> crazy awesome! I just applied these patches, followed the readme >>> instructions for the SD card. Then grabbed a USB DVD drive, and a USB >>> SSD, plugged in a keyboard/mouse/monitor/network and booted the fedora >>> 29 1.2 install ISO. The graphical installer ran as expected, system >>> installed as expected, and other than the nextboot not being reset (had >>> to update it via the BDS, as is documented) it "just worked". >>> >>> There are a few rough edges here/there but the idea that we have another >>> ARM machine that almost behaves like one expects a modern computing >>> device to behave, is wonderful. The only real gocha continues to be the >>> rpi's well known shortcomings, including the fact that it took nearly 6 >>> hours to install. >>> >>> >>> so, >>> >>> Tested-by: Jeremy Linton >>> >> >> Thanks Jeremy. >> >> I fully agree, and I am quite happy to have an example to point to the >> next time someone wants to contribute some 96boards UEFI port that >> looks like u-boot and only runs on the serial port > > For the series > > Reviewed-by: Ard Biesheuvel > > edk2-non-osi pieces pushed as > > 863a3237a74c Platform/RaspberryPi/RPi3: Add ATF binaries > 9c52bc5c0f14 Platform/RaspberryPi/RPi3: Add Device Tree binaries > 635f97e09aaa Platform/RaspberryPi/RPi3: Add logo driver > > edk2-platforms pieces pushed as 06454982de98..94d6843f1a90 > > Thanks again, Pete, and everyone else for the excellent work. > > /me goes and updates his blog >