public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Abdul Lateef Attar <abdattar@amd.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Zhichao Gao <zhichao.gao@intel.com>,
	nd <nd@arm.com>
Subject: Re: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser
Date: Mon, 22 Nov 2021 17:54:03 +0000	[thread overview]
Message-ID: <aeb9c49a-090e-9772-80fe-c0983ea57b09@arm.com> (raw)
In-Reply-To: <20211122102116.22635-1-abdattar@amd.com>

Hi Abdul,

Thank you for this patch series.

This series looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 22/11/2021 10:21 AM, Abdul Lateef Attar wrote:
> Hi Sami, Zhichao,
>     Addressed all review comments.
> Created two different patches, one for bitfield parser and
> another for FADT Flags parser.
>
> Thanks
> AbduL
>
> REF : https://github.com/abdattar/edk2/tree/FadtFlagsParser
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> Abdul Lateef Attar (2):
>    ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser
>    ShellPkg/AcpiView: PrintFormatter for FADT Flags field
>
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  45 +++++
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              | 177 ++++++++++++++++++++
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c |  59 ++++++-
>   3 files changed, 280 insertions(+), 1 deletion(-)
>


  parent reply	other threads:[~2021-11-22 17:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 10:21 [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Abdul Lateef Attar
2021-11-22 10:21 ` [PATCH v3 1/2] " Abdul Lateef Attar
2021-11-22 10:21 ` [PATCH v3 2/2] ShellPkg/AcpiView: PrintFormatter for FADT Flags field Abdul Lateef Attar
2021-11-22 17:54 ` Sami Mujawar [this message]
2021-12-14 11:18   ` [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Attar, AbdulLateef (Abdul Lateef)
2021-12-14 12:04     ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeb9c49a-090e-9772-80fe-c0983ea57b09@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox