From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.56]) by mx.groups.io with SMTP id smtpd.web10.1271.1637603666988919941 for ; Mon, 22 Nov 2021 09:54:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=pPXrToqP; spf=pass (domain: arm.com, ip: 40.107.6.56, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S65pfOezrsXdsxK6ZlFgB0097CYBEg3+Lrz03RtWQgg=; b=pPXrToqPY42e3tQLFIEz7oFKOSuIpZ1yFzc1xQpkVQhJ8T1VMukBTtE1WPSsf/eJhH833UU2jUZFmz0hnHKN5GajVRW+GzvTv1SoJd/QmhH1BygXtliTp0REioaAPd0zttgQb3LQ4G9X7C58YY/b6GQwlOPZOBnecpoGg8R5FLg= Received: from AM6P195CA0059.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::36) by AM9PR08MB6674.eurprd08.prod.outlook.com (2603:10a6:20b:302::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Mon, 22 Nov 2021 17:54:19 +0000 Received: from VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:87:cafe::28) by AM6P195CA0059.outlook.office365.com (2603:10a6:209:87::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Mon, 22 Nov 2021 17:54:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT063.mail.protection.outlook.com (10.152.18.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Mon, 22 Nov 2021 17:54:19 +0000 Received: ("Tessian outbound de6049708a0a:v110"); Mon, 22 Nov 2021 17:54:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c99ab9c329e35ed5 X-CR-MTA-TID: 64aa7808 Received: from bbbeca3d8574.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F9CEE679-95C6-4708-B4E8-4BFCDC604405.1; Mon, 22 Nov 2021 17:54:12 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bbbeca3d8574.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 22 Nov 2021 17:54:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hh+fMz3sE+70kfNlAH+1C5m5fs1ZJ7KjhYIC/bfUiMnlGqXDQb2Mwx9NUKwWANlRtQrW1gbNKYBBvwJYJei/ZqQhK1Mlz/iFbi6R0eFb2HZuuoWfcgwuQHQo4UqARbPBgqmssyGSVFNrk5mutCLrDqCcCkaQF8RpmtjSnHfP1irE82BddC+zT6kgchrU1jym7fu4yDX91R0AsFJNqEHnuwLoxK2Q+ThpwMpu7SbAtlLJYMffFpiGCIwI+9vnwyid84bj2sLp+NzS7NSSGKI4H0wBhYz8WPNWNV3pczZ+9c07iqxgxg1D7DKXpk2hOvLMIqwNBZ7kGIADnJmygV4/jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S65pfOezrsXdsxK6ZlFgB0097CYBEg3+Lrz03RtWQgg=; b=kcujSqu3xwM87FEHgAtuqT8hfMcBOW7CdLwn08Dh40mLOUFduDCvyznWGmJRbXGm8RtQGhtW0U9Aez9VAGSExj3mH5uU9sv3BJh8QcGT7QYFHCurEXQkrjP/Ihe95FKzS8+cM7d14MbXwOfbsTQgJ2csL0frxY/CPM4lL687hVAy470GY1RbtrWzuvwa1r8PFYxRFtNWY2D/yHPB/WVtLP/cs5L+lbqIdhUMDQGPXGRPcyN1KFc6OUA5VRyInOzNcncMCKb6u2qGbbMI5skphNAvoCH0pg/Zf5m/CGvLcHDMTpN03yrtNK8LfYEc4JOcUhR6+Eoi4DFdmuQKizimgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S65pfOezrsXdsxK6ZlFgB0097CYBEg3+Lrz03RtWQgg=; b=pPXrToqPY42e3tQLFIEz7oFKOSuIpZ1yFzc1xQpkVQhJ8T1VMukBTtE1WPSsf/eJhH833UU2jUZFmz0hnHKN5GajVRW+GzvTv1SoJd/QmhH1BygXtliTp0REioaAPd0zttgQb3LQ4G9X7C58YY/b6GQwlOPZOBnecpoGg8R5FLg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB5078.eurprd08.prod.outlook.com (2603:10a6:20b:e7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Mon, 22 Nov 2021 17:54:03 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4713.025; Mon, 22 Nov 2021 17:54:03 +0000 Subject: Re: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Ray Ni , Zhichao Gao , nd References: <20211122102116.22635-1-abdattar@amd.com> From: "Sami Mujawar" Message-ID: Date: Mon, 22 Nov 2021 17:54:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211122102116.22635-1-abdattar@amd.com> X-ClientProxiedBy: LO2P265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::21) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Mon, 22 Nov 2021 17:54:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bc32bdf-0140-4a6c-cc3b-08d9ade11b9c X-MS-TrafficTypeDiagnostic: AM6PR08MB5078:|AM9PR08MB6674: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:3173;OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YNJVbwHV/Dwct2hTBhwQGpsXPNwCqbi2Oor2y99kkZFBGaBrKVkjy5CUcVlaIN2/h31vnVOrNOa4lXjayyKRzdJ31bX5KHwJRwGU8nzi0KXZlGSl85H9M+W+0FuomMAmX3mS+4FX5ydP7Odw1/bdj3Ae0CKRaSZ/DYMip9R5eh7QXaZKzENo9ebqrqY4z1SqlvkoQpnGNMmBRMQc1OLtCcpWr46B8tTIT8oXu30d4xemyK2CErB7Q66dLTIU0o2Qzl57uhvMpbKdpD2ax0hSvvruhQTdcKPBy2cNFs0Cj96X2GF7RTAKknoXg3qzLrOGzEuT3b2WTuKE7vqRz/BMAAeyReAamQlSi0gEQiTjFK76pRF2Gw/qwtZwD3I52dsbTi0qiz6w+E+zR7W73FQKqK7Clmy0Q2D99opFXMXGu4awLgglgvDZ7qL6tEyQqJ/DxOarE563nTJtdz54M/Eq11dt0HCnjweMePtZuCRixHKpcCjf0EgmBX0r2n0vAkYToaNqvDRjQ5+TsB4kCmuLGN+I0ksnV10+F/5kOom7OgZ3gMfwn+tvI75FcBqM8WuboNTb9++p+abbLRhRCILSSVzUm20O8gY6eZfSoIbiiu7ygCoLyT4BPWs3RujEMElzHNOVKfbZIwdeJUHokIXItAeDKkUnXCWpbU4pZl9UZyk35UvXZ1xXv21Q1+lLwA/2Ak66AmaMFH91a24N2VKk5dc45B42HA6/K5yjVvONPR5TXMTrWLc56EqPTAzWgntQCQywR1wy+hHcAh2bIeP9qBRciy6yTxVRlKkgfQRCBk0H1wfXIDuGHPaYzu9Su/83WTcqt02duCL5YA/5j7MheqmUgkPuyHzRGIySALoiuUA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(66476007)(8676002)(16576012)(36756003)(44832011)(52116002)(53546011)(6486002)(66946007)(186003)(508600001)(26005)(2906002)(31696002)(4326008)(8936002)(86362001)(83380400001)(38100700002)(316002)(956004)(2616005)(54906003)(31686004)(966005)(38350700002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5078 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 89cc2df3-68f3-4ff7-5b04-08d9ade111ee X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ItmY39x8hNN3FYuJ2PIGsayqp8NsXkLrrMagsK/Y6d2fTa2eJlehFsL2pnM3EnJb/AuQ7WmcvMTiYmovXNMw1z7ABxhPt+DqiE8eyCM7bxkQ+3RidOs5DHV964VT6352yT+uLyzO3J5jbtld52vzKZsxePrE1eFbBeW0k6XN2qUJGW82gZ1nNJ+jaKzJI8z9WyZNtfcODy071bnX1RSg1H93gQTyL72LHevlB24tushkCN8EyTLY415FqS97M4RfIii5MW7dJHxkZmOcsQ0cJQ6doFRdnAFpokRGY6r/H9Z2Dqv+0mlZmh9/FwOOUJKa1LPZXl7LW2L0m1Ht1AXodVPUQDSrStbzAr90U8ViJOTt3EHuu5pPEEmTod+WHZ8bRmD1ThCvQ8m1e0n0sgbrRBGIfYalhTYIRnIt9s3PAyT5KSERLwFymsYsm0NKfdMRWZcBWjedOxXMdVceOTLtHPNP8Uhs8SibitNUiXbIoOY/rpA15mSd+yDPSKaMoT4nCny7nNoXWifQh+yAvCfC+tPKRvYslIuYa2f1x5S5BsRsN0sv5nX1gaJ3n51fPw3/LcyZ4FgEA9Cn4O4ijEmA5Bb36WPCRurQLVkTpXZAPyOgi1RBqDJ93e4DXqlhU9XyXoyEytxvW3gJgO+WyE9UcvtB05NnT0cAwDLH+mslurs40zFAPsmut1WSNDagiRoy/oiw7XK2gGWAcQbc6oegC1f7BOAeFHbclv5Px5HEr+c3qKELkHS3iyZWQWDAxTRLcxed8UmEbIFqO1FE63XItS0ZG8Oxz0EPgY7A1R5VN0PBT0svVpZlfgU0wVfF6Kk3 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2616005)(83380400001)(16576012)(956004)(316002)(44832011)(53546011)(356005)(186003)(54906003)(4326008)(26005)(81166007)(2906002)(8676002)(47076005)(70586007)(31696002)(36860700001)(8936002)(86362001)(6486002)(31686004)(36756003)(966005)(70206006)(508600001)(5660300002)(82310400003)(336012)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 17:54:19.1063 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc32bdf-0140-4a6c-cc3b-08d9ade11b9c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6674 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Abdul, Thank you for this patch series. This series looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 22/11/2021 10:21 AM, Abdul Lateef Attar wrote: > Hi Sami, Zhichao, > Addressed all review comments. > Created two different patches, one for bitfield parser and > another for FADT Flags parser. > > Thanks > AbduL > > REF : https://github.com/abdattar/edk2/tree/FadtFlagsParser > > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > Signed-off-by: Abdul Lateef Attar > Abdul Lateef Attar (2): > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > ShellPkg/AcpiView: PrintFormatter for FADT Flags field > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 45 +++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 177 ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 59 ++++++- > 3 files changed, 280 insertions(+), 1 deletion(-) >