* [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH
@ 2021-08-21 19:55 Marvin Häuser
2021-08-23 1:30 ` Yuwei Chen
2021-08-23 13:02 ` [edk2-devel] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Marvin Häuser @ 2021-08-21 19:55 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao, Yuwei Chen, Vitaly Cheptsov
Use the correct X64 path for CLANGPDB RCPATH.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>
Signed-off-by: Marvin Häuser <mhaeuser@posteo.de>
---
BaseTools/Conf/tools_def.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index 2e6b382ab623..de13fb0732db 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -2806,7 +2806,7 @@ NOOPT_CLANGPDB_IA32_DLINK2_FLAGS =
*_CLANGPDB_X64_VFRPP_PATH = DEF(CLANGPDB_X64_PREFIX)clang
*_CLANGPDB_X64_ASLCC_PATH = DEF(CLANGPDB_X64_PREFIX)clang
*_CLANGPDB_X64_ASLPP_PATH = DEF(CLANGPDB_X64_PREFIX)clang
-*_CLANGPDB_X64_RC_PATH = DEF(CLANGPDB_IA32_PREFIX)llvm-rc
+*_CLANGPDB_X64_RC_PATH = DEF(CLANGPDB_X64_PREFIX)llvm-rc
*_CLANGPDB_X64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m64 -fno-lto DEF(CLANGPDB_X64_TARGET)
*_CLANGPDB_X64_ASM_FLAGS = DEF(GCC_ASM_FLAGS) -m64 DEF(CLANGPDB_X64_TARGET)
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH
2021-08-21 19:55 [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH Marvin Häuser
@ 2021-08-23 1:30 ` Yuwei Chen
2021-08-23 13:02 ` [edk2-devel] " Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Yuwei Chen @ 2021-08-23 1:30 UTC (permalink / raw)
To: Marvin Häuser, devel@edk2.groups.io
Cc: Feng, Bob C, Liming Gao, Vitaly Cheptsov
This patch looks good to me.
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: Marvin Häuser <mhaeuser@posteo.de>
> Sent: Sunday, August 22, 2021 3:56 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>;
> Vitaly Cheptsov <vit9696@protonmail.com>
> Subject: [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH
>
> Use the correct X64 path for CLANGPDB RCPATH.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Vitaly Cheptsov <vit9696@protonmail.com>
> Signed-off-by: Marvin Häuser <mhaeuser@posteo.de>
> ---
> BaseTools/Conf/tools_def.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 2e6b382ab623..de13fb0732db 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2806,7 +2806,7 @@ NOOPT_CLANGPDB_IA32_DLINK2_FLAGS =
> *_CLANGPDB_X64_VFRPP_PATH = DEF(CLANGPDB_X64_PREFIX)clang
>
> *_CLANGPDB_X64_ASLCC_PATH = DEF(CLANGPDB_X64_PREFIX)clang
>
> *_CLANGPDB_X64_ASLPP_PATH = DEF(CLANGPDB_X64_PREFIX)clang
>
> -*_CLANGPDB_X64_RC_PATH = DEF(CLANGPDB_IA32_PREFIX)llvm-rc
>
> +*_CLANGPDB_X64_RC_PATH = DEF(CLANGPDB_X64_PREFIX)llvm-rc
>
>
>
> *_CLANGPDB_X64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m64 -
> fno-lto DEF(CLANGPDB_X64_TARGET)
>
> *_CLANGPDB_X64_ASM_FLAGS = DEF(GCC_ASM_FLAGS) -m64
> DEF(CLANGPDB_X64_TARGET)
>
> --
> 2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH
2021-08-21 19:55 [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH Marvin Häuser
2021-08-23 1:30 ` Yuwei Chen
@ 2021-08-23 13:02 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-08-23 13:02 UTC (permalink / raw)
To: devel, mhaeuser; +Cc: Bob Feng, Liming Gao, Yuwei Chen, Vitaly Cheptsov
On 8/21/21 9:55 PM, Marvin Häuser wrote:
> Use the correct X64 path for CLANGPDB RCPATH.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Vitaly Cheptsov <vit9696@protonmail.com>
> Signed-off-by: Marvin Häuser <mhaeuser@posteo.de>
Fixes: 15330934dc86 ("BaseTools tools_def: Add CLANG9 tool chain to
directly generate PE image")
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-23 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-21 19:55 [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH Marvin Häuser
2021-08-23 1:30 ` Yuwei Chen
2021-08-23 13:02 ` [edk2-devel] " Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox