From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Luo, Heng" <heng.luo@intel.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test
Date: Sun, 19 Jan 2020 06:46:37 +0000 [thread overview]
Message-ID: <af1d238351c346eb81ccd7c5e54f7787@intel.com> (raw)
In-Reply-To: <20200114085412.2060-1-heng.luo@intel.com>
Heng:
The change is good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>
Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo
Sent: 2020年1月14日 16:54
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2463
Perform Data and Address line test only if not ignore memory test.
Signed-off-by: Heng Luo <heng.luo@intel.com>
---
.../MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c
index ce9e5e659b..fe24e490d4 100644
--- a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c
+++ b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemory
+++ Test.c
@@ -1,6 +1,6 @@
/** @file - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>+ Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent @@ -677,10 +677,12 @@ GenMemoryTestFinished (
Private = GENERIC_MEMORY_TEST_PRIVATE_FROM_THIS (This); //- // Perform Data and Address line test+ // Perform Data and Address line test only if not ignore memory test //- Status = PerformAddressDataLineTest (Private);- ASSERT_EFI_ERROR (Status);+ if (Private->CoverLevel != IGNORE) {+ Status = PerformAddressDataLineTest (Private);+ ASSERT_EFI_ERROR (Status);+ } // // Add the non tested memory range to system memory map through GCD service--
2.24.0.windows.2
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#53222): https://edk2.groups.io/g/devel/message/53222
Mute This Topic: https://groups.io/mt/69692450/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] -=-=-=-=-=-=
next prev parent reply other threads:[~2020-01-19 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 8:54 [PATCH] MdeModulePkg: Perform test only if not ignore memory test Heng Luo
2020-01-19 6:46 ` Liming Gao [this message]
2020-02-05 13:26 ` [edk2-devel] " Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af1d238351c346eb81ccd7c5e54f7787@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox