From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.539.1579416399893913984 for ; Sat, 18 Jan 2020 22:46:40 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2020 22:46:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,337,1574150400"; d="scan'208";a="269906598" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 18 Jan 2020 22:46:39 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 18 Jan 2020 22:46:38 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 19 Jan 2020 14:46:37 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Sun, 19 Jan 2020 14:46:37 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Luo, Heng" CC: "Wu, Hao A" , "Ni, Ray" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test Thread-Index: AQHVytiOC1zZONYWNky5nmyl8m7GCafxkoMw Date: Sun, 19 Jan 2020 06:46:37 +0000 Message-ID: References: <20200114085412.2060-1-heng.luo@intel.com> In-Reply-To: <20200114085412.2060-1-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Heng: The change is good to me. Reviewed-by: Liming Gao Thanks Liming -----Original Message----- From: devel@edk2.groups.io On Behalf Of Heng Luo Sent: 2020=1B$BG/=1B(B1=1B$B7n=1B(B14=1B$BF|=1B(B 16:54 To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore= memory test REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2463 Perform Data and Address line test only if not ignore memory test. Signed-off-by: Heng Luo --- .../MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMe= moryTest.c b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMe= moryTest.c index ce9e5e659b..fe24e490d4 100644 --- a/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemoryTes= t.c +++ b/MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/LightMemory +++ Test.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2006 - 2018, Intel Corporation. All rights rese= rved.
+ Copyright (c) 2006 - 2020, Intel Corporation. All rights reserv= ed.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -677,10 +677,12 = @@ GenMemoryTestFinished ( Private =3D GENERIC_MEMORY_TEST_PRIVATE_FROM_THIS (This); //- // Per= form Data and Address line test+ // Perform Data and Address line test onl= y if not ignore memory test //- Status =3D PerformAddressDataLineTest (P= rivate);- ASSERT_EFI_ERROR (Status);+ if (Private->CoverLevel !=3D IGNORE= ) {+ Status =3D PerformAddressDataLineTest (Private);+ ASSERT_EFI_ERR= OR (Status);+ } // // Add the non tested memory range to system memor= y map through GCD service--=20 2.24.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53222): https://edk2.groups.io/g/devel/message/53222 Mute This Topic: https://groups.io/mt/69692450/1759384 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] -= =3D-=3D-=3D-=3D-=3D-=3D