From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.48286.1585569695533835689 for ; Mon, 30 Mar 2020 05:01:35 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.43, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: WDuYJs8EraLZuKIEmN9+ZIyM79Wb78rFRzoaKpdd10F93NLU8xVr990OssE979J1yElpb1hZ1v UOaSbs6La7NA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 05:01:35 -0700 IronPort-SDR: DzufXQuowZesRujCNZXAOsPzGn53vaY2kYCbkeTEx9Wd/VGTRiSm4lDVX9q8LCb2rikUpO5a6P 5tDCqAH0DiGw== X-IronPort-AV: E=Sophos;i="5.72,324,1580803200"; d="scan'208";a="448245654" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.213.6.151]) ([10.213.6.151]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 05:01:33 -0700 Subject: Re: [edk2-devel] [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Jiaxin Wu , Siyuan Fu References: <20200327015629.2588-1-zhichao.gao@intel.com> <20200327015629.2588-7-zhichao.gao@intel.com> From: "Maciej Rabeda" Message-ID: Date: Mon, 30 Mar 2020 14:01:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200327015629.2588-7-zhichao.gao@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: pl Reviewed-by: Maciej Rabeda On 27-Mar-20 02:56, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682 > > iSCSI driver required the MD5 function. Change the PcdMD5Enable > to TRUE when NETWORK_ISCSI_ENABLE is TURE. > > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Zhichao Gao > --- > NetworkPkg/NetworkPcds.dsc.inc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/NetworkPkg/NetworkPcds.dsc.inc b/NetworkPkg/NetworkPcds.dsc.inc > index f874b382ef..7a81f0cb2d 100644 > --- a/NetworkPkg/NetworkPcds.dsc.inc > +++ b/NetworkPkg/NetworkPcds.dsc.inc > @@ -5,7 +5,7 @@ > # by using "!include NetworkPkg/NetworkPcds.dsc.inc" to specify PCD settings > # according to the value of flags described in "NetworkDefines.dsc.inc". > # > -# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -14,3 +14,6 @@ > !if $(NETWORK_ALLOW_HTTP_CONNECTIONS) == TRUE > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > !endif > +!if $(NETWORK_ISCSI_ENABLE) == TRUE > + gEfiCryptoPkgTokenSpaceGuid.PcdMD5Enable|TRUE > +!endif