From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68BDE74003A for ; Fri, 26 Jul 2024 14:07:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pA1Z8KH/yTNapULso10UUPlDB1Sjw4p4E45BXzON/Ig=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:To:From:Subject:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1722002866; v=1; b=dKrRPwYSgzjhCKgw1Ks4UveRIgIN5zxRad81socFKquK4Vti6txgmcIb6iRLj3n2LzIBZYbX 7LdGbtckgiwwxENRTPweaKGFd/YjvEtPH3mTc5B4QlpuNkxYAYfIrgcnHtqqafOvJB70+fJb/Cv BUNTc5xkATLGqWMhzWyB8smVhkJuexeMseRpCzE2Ydm4BFGetMjsg2gHPJ3cPRRSSmebnMPjo1i rU4omHWZ1iZIaSxOWg5Ot6NwXe3zL01KCs12QI3Pn2SIAyWf0ZPD5o9LVaadIlxY4PdAUHTLRFM OWI6NM/pzZkpDkui9gQ6rsjqYWWsNHFZpsoZP4bkZqTYg== X-Received: by 127.0.0.2 with SMTP id dGL1YY7687511xeN0j0EY6Qq; Fri, 26 Jul 2024 07:07:44 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.62339.1722002864357221983 for ; Fri, 26 Jul 2024 07:07:44 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.10]) by linux.microsoft.com (Postfix) with ESMTPSA id 95E7E20B7165 for ; Fri, 26 Jul 2024 07:07:43 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95E7E20B7165 Message-ID: Date: Fri, 26 Jul 2024 10:07:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: "devel@edk2.groups.io" From: "Michael Kubacki" Subject: [edk2-devel] CodeQL Failures in PR Checks Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 26 Jul 2024 07:07:44 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yNd7b9IpeEmnHYstVFTRbNMEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=dKrRPwYS; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io TLDR: If CodeQL failed in a PR. Rebase your PR branch on master and push. --- edk2 uses an application called the CodeQL CLI to run CodeQL in CI builds. https://github.com/github/codeql-cli-binaries/ A fixed version of the application is used to allow controlled updates=20 where the version is tracked in YAML files like this: https://github.com/tianocore/edk2/blob/master/BaseTools/Plugin/CodeQL/codeq= lcli_ext_dep.yaml Yesterday, a new CodeQL CLI version was released v2.18.1: https://github.com/github/codeql-cli-binaries/releases/tag/v2.18.1 CodeQL uses queries to find issues that target certain CodeQL CLI=20 versions. v2.18.1 published a new set of queries incompatible with the=20 CodeQL CLI version fixed in edk2. Last month, this PR intended to fix the queries as well to prevent the=20 CLI from using an incompatible (latest) query set, but it wasn't merged=20 due to some mergify issues. It eventually fell off the radar. https://github.com/tianocore/edk2/pull/5720 --- Actions Taken: To solve the immediate issue, the CodeQL CLI issue is updated in edk2 so=20 it is compatible with the latest queries moving the project to the=20 latest release and fixing the PR status checks. This was done in=20 https://github.com/tianocore/edk2/commit/6589843cc619b3a5e2d2c0e5b12451b11a= 3f2288. I will recreate 5720 to account for this new CodeQL version in a new PR=20 to prevent this from happening in the future. Thanks, Michael -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120049): https://edk2.groups.io/g/devel/message/120049 Mute This Topic: https://groups.io/mt/107561854/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-