From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EF6D6AC0C1D for ; Mon, 29 Jan 2024 11:22:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=72mF6tjkUbBqBDs3vjrWSmDr+aI9EE60OIPqDFlT7G0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706527334; v=1; b=VgSfmoNXoNsGrMbQUrOFt2DPXT8BRHDPXRzVkTJ7zugSiQsc8d/XwQn4yU/rqp33ay/m7xQ5 4zp77DGHZdR7z34Vt1MJhnASoPQ9WEKRiso+fFaQv9jPVZzDPZoQaS0PXF8C7sYxpDGtGmUCrmU 3G8Mvqa6ygu8F8yV6JT/Bk2s= X-Received: by 127.0.0.2 with SMTP id vqO3YY7687511xPHETjiZtth; Mon, 29 Jan 2024 03:22:14 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.12251.1706527333769727167 for ; Mon, 29 Jan 2024 03:22:13 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-1YiWDmJ6OcyHxcB1vbmj-g-1; Mon, 29 Jan 2024 06:22:09 -0500 X-MC-Unique: 1YiWDmJ6OcyHxcB1vbmj-g-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A4FE3811E81; Mon, 29 Jan 2024 11:22:08 +0000 (UTC) X-Received: from [10.39.193.158] (unknown [10.39.193.158]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 551BEA26; Mon, 29 Jan 2024 11:22:07 +0000 (UTC) Message-ID: Date: Mon, 29 Jan 2024 12:22:06 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/ResetVector: send post codes to qemu debug console To: Gerd Hoffmann Cc: Erdem Aktas , Tom Lendacky , devel@edk2.groups.io, Jiewen Yao , Ard Biesheuvel , Michael Roth , Min Xu , Oliver Steffen References: <20240124153107.2112760-1-kraxel@redhat.com> <67da33f7-5038-6732-455a-2576f641f1c0@redhat.com> <4d8b55a7-0898-4ab3-90d0-394b3bd533de@amd.com> <05f60909-a4ef-7497-5925-775b3ad71797@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uULGOGcZAuOSaIeWhJIt0Jvbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VgSfmoNX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/26/24 14:25, Gerd Hoffmann wrote: > On Thu, Jan 25, 2024 at 08:47:56PM +0100, Laszlo Ersek wrote: >> On 1/25/24 08:50, Gerd Hoffmann wrote: >>> On Wed, Jan 24, 2024 at 05:43:29PM -0800, Erdem Aktas wrote: >>>> Same for TDX, I did not run it but it should cause failure >>>> as debugShowPostCode is called OvmfPkg/ResetVector/Ia32/IntelTdx.asm b= efore >>>> actually the #VE handlers are installed. >>>> >>>>> Had a meeting get canceled and so got a chance to test this. As I tho= ught, >>>>> this causes SEV-ES/SEV-SNP guest failures. >>> >>> Hmm, I guess that pretty much kills the idea. The first post code is >>> sent before probing for TDX/SEV happens ... >> >> Can we salvage it, but make it depend on a minimal source code tweak >> (ungating)? Changing a single line for debugging (non-TDX / non-SEV-ES >> guests, anyway) is much easier than coming up with this patch from zero, >> whenever needed. >> >> Can we add "DebugCon.asm" to the tree, plus a *comment* near >> >> %include "DebugDisabled.asm" >> >> about "DebugCon.asm"? >=20 > Sure, can do that. I assume the concern about the slowdown is moot if > this requires an source code patch to be enabled? Yes, absolutely! Since it's not enabled by default, only for dedicated debugging sessions, the perf hit (if any) should be fine, IMO. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114684): https://edk2.groups.io/g/devel/message/114684 Mute This Topic: https://groups.io/mt/103933942/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-