From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00010702.pphosted.com (mx0b-00010702.pphosted.com [148.163.158.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 14FAA80400 for ; Thu, 16 Mar 2017 08:11:49 -0700 (PDT) Received: from pps.filterd (m0098779.ppops.net [127.0.0.1]) by mx0b-00010702.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v2GF6SUN025770; Thu, 16 Mar 2017 10:11:42 -0500 Received: from ni.com (skprod3.natinst.com [130.164.80.24]) by mx0b-00010702.pphosted.com with ESMTP id 297udh8adf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Mar 2017 10:11:42 -0500 Received: from us-aus-exch1.ni.corp.natinst.com (us-aus-exch1.ni.corp.natinst.com [130.164.68.11]) by us-aus-skprod3.natinst.com (8.16.0.17/8.16.0.17) with ESMTPS id v2GFBfA2030626 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 16 Mar 2017 10:11:41 -0500 Received: from us-aus-exch3.ni.corp.natinst.com (130.164.68.13) by us-aus-exch1.ni.corp.natinst.com (130.164.68.11) with Microsoft SMTP Server (TLS) id 15.0.1156.6; Thu, 16 Mar 2017 10:11:41 -0500 Received: from us-aus-exhub1.ni.corp.natinst.com (130.164.68.41) by us-aus-exch3.ni.corp.natinst.com (130.164.68.13) with Microsoft SMTP Server (TLS) id 15.0.1156.6; Thu, 16 Mar 2017 10:11:41 -0500 Received: from jmw-lm181.amer.corp.natinst.com (130.164.49.7) by us-aus-exhub1.ni.corp.natinst.com (130.164.68.41) with Microsoft SMTP Server id 15.0.1156.6 via Frontend Transport; Thu, 16 Mar 2017 10:11:41 -0500 Date: Thu, 16 Mar 2017 10:11:41 -0500 From: Jeff Westfahl X-X-Sender: jwestfah@jmw-lm181 To: CC: , , Ruiyu Ni Leif Lindholm , Dong Wei , "Michael D Kinney" , Jiewen Yao , "Jaben Carsey" In-Reply-To: <20170309234942.11956-3-evan.lloyd@arm.com> Message-ID: References: <20170309234942.11956-1-evan.lloyd@arm.com> <20170309234942.11956-3-evan.lloyd@arm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-03-16_12:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703160121 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-03-16_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=30 priorityscore=1501 malwarescore=0 suspectscore=4 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=30 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703160121 Subject: Re: [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2017 15:11:49 -0000 Content-Type: text/plain; format=flowed; charset="US-ASCII" Hi Evan, I really appreciate this work, I've missed this functionality in the EFI shell. Just a few minor things that I noticed: 1. In AcpiView.c, you use '\t' in a few places. For some reason, on my Intel PC, these tabs are displayed as a reverse color '?'. I'm not sure where the fault lies here. It seems like tab characters should be pretty universally understood, but I also don't see any tab characters in other parts of the shell code that are printed to the console. 2. In MadtParser.c, the error message at line 270 needs a newline. (No, my Intel PC doesn't have a GIC :) Regards, Jeff