Re: [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables

[Jeff Westfahl <jeff.westfahl@ni.com>]

Hi Sami,

Just another note, acpiview doesn't currently build on Windows, at least 
not with Visual Studio 2015. This isn't a problem for me as I don't 
usually build the shell on Windows, I just happened to notice it.

Regards,

Jeff Westfahl

On Fri, 17 Mar 2017, Sami Mujawar wrote:

> Hi Jeff,
>
> Thank you for letting us know these issues. I will provide an update to fix this soon.
>
> Regards,
>
> Sami Mujawar
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff Westfahl
> Sent: 16 March 2017 03:12
> To: Evan Lloyd
> Cc: Ruiyu Ni Leif Lindholm; edk2-devel@ml01.01.org; Jaben Carsey; Jiewen Yao; Michael D Kinney; linaro.org@ml01.01.org; Dong Wei
> Subject: Re: [edk2] [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables
>
> Hi Evan,
>
> I really appreciate this work, I've missed this functionality in the EFI shell.
>
> Just a few minor things that I noticed:
>
> 1. In AcpiView.c, you use '\t' in a few places. For some reason, on my Intel PC, these tabs are displayed as a reverse color '?'. I'm not sure where the fault lies here. It seems like tab characters should be pretty universally understood, but I also don't see any tab characters in other parts of the shell code that are printed to the console.
>
> 2. In MadtParser.c, the error message at line 270 needs a newline. (No, my Intel PC doesn't have a GIC :)
>
> Regards,
> Jeff
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>