From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00010702.pphosted.com (mx0a-00010702.pphosted.com [148.163.156.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8201A21DFA7B5 for ; Tue, 28 Mar 2017 12:49:54 -0700 (PDT) Received: from pps.filterd (m0098780.ppops.net [127.0.0.1]) by mx0a-00010702.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v2SJjxEL013175; Tue, 28 Mar 2017 14:49:48 -0500 Received: from ni.com (skprod2.natinst.com [130.164.80.23]) by mx0a-00010702.pphosted.com with ESMTP id 29dp2pmcaa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Mar 2017 14:49:48 -0500 Received: from us-aus-exch1.ni.corp.natinst.com (us-aus-exch1.ni.corp.natinst.com [130.164.68.11]) by us-aus-skprod2.natinst.com (8.16.0.17/8.16.0.17) with ESMTPS id v2SJnlWt004378 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 28 Mar 2017 14:49:47 -0500 Received: from us-aus-exhub2.ni.corp.natinst.com (130.164.68.32) by us-aus-exch1.ni.corp.natinst.com (130.164.68.11) with Microsoft SMTP Server (TLS) id 15.0.1156.6; Tue, 28 Mar 2017 14:49:47 -0500 Received: from jmw-lm181.amer.corp.natinst.com (130.164.49.7) by us-aus-exhub2.ni.corp.natinst.com (130.164.68.32) with Microsoft SMTP Server id 15.0.1156.6 via Frontend Transport; Tue, 28 Mar 2017 14:49:47 -0500 Date: Tue, 28 Mar 2017 14:49:47 -0500 From: Jeff Westfahl X-X-Sender: jwestfah@jmw-lm181 To: Sami Mujawar CC: Jeff Westfahl , Evan Lloyd , Ruiyu Ni Leif Lindholm , "edk2-devel@ml01.01.org" , Jaben Carsey , Jiewen Yao , Michael D Kinney , "linaro.org@ml01.01.org" , Dong Wei In-Reply-To: Message-ID: References: <20170309234942.11956-1-evan.lloyd@arm.com> <20170309234942.11956-3-evan.lloyd@arm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703280066 X-Proofpoint-Virus-Version: vendor=nai engine=5600 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-03-28_16:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=30 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703280162 Subject: Re: [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 19:49:54 -0000 Content-Type: text/plain; charset="US-ASCII"; format=flowed Hi Sami, Just another note, acpiview doesn't currently build on Windows, at least not with Visual Studio 2015. This isn't a problem for me as I don't usually build the shell on Windows, I just happened to notice it. Regards, Jeff Westfahl On Fri, 17 Mar 2017, Sami Mujawar wrote: > Hi Jeff, > > Thank you for letting us know these issues. I will provide an update to fix this soon. > > Regards, > > Sami Mujawar > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff Westfahl > Sent: 16 March 2017 03:12 > To: Evan Lloyd > Cc: Ruiyu Ni Leif Lindholm; edk2-devel@ml01.01.org; Jaben Carsey; Jiewen Yao; Michael D Kinney; linaro.org@ml01.01.org; Dong Wei > Subject: Re: [edk2] [edk2-staging][PATCH 2/2] ShellPkg: Add acpiview tool to dump ACPI tables > > Hi Evan, > > I really appreciate this work, I've missed this functionality in the EFI shell. > > Just a few minor things that I noticed: > > 1. In AcpiView.c, you use '\t' in a few places. For some reason, on my Intel PC, these tabs are displayed as a reverse color '?'. I'm not sure where the fault lies here. It seems like tab characters should be pretty universally understood, but I also don't see any tab characters in other parts of the shell code that are printed to the console. > > 2. In MadtParser.c, the error message at line 270 needs a newline. (No, my Intel PC doesn't have a GIC :) > > Regards, > Jeff > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. >