From: Jeff Westfahl <jeff.westfahl@ni.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>,
Jeff Westfahl <jeff.westfahl@ni.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH] ShellPkg/ShellCommandLib: Update DumpHex to print {|}~
Date: Wed, 26 Apr 2017 14:37:47 -0500 [thread overview]
Message-ID: <alpine.DEB.2.20.1704261436360.19449@jmw-lm181> (raw)
In-Reply-To: <7a8b3c50-10ed-8eb7-7653-f37a63430a01@redhat.com>
Hi Laszlo,
I liked your description so much that I copied it basically word for word
in my PATCH v2 commit description. Is there some way I can attribute this
to you in the commit description?
Regards,
Jeff
On Wed, 26 Apr 2017, Laszlo Ersek wrote:
> On 04/26/17 20:00, Carsey, Jaben wrote:
>> I think that this is a correct change, but I do not understand the problem this solves.
>
> The problem is presumably that, if you have a string like
>
> {xizzy}~{foo|bar}~{quux}
>
> in the dumped data, it will not appear as such in the *-delimited ASCII
> column to the right, but as
>
> .xizzy...foo.bar...quux.
>
> which is less than ideal.
>
> Thanks,
> Laszlo
>
>>
>> -Jaben
>>
>>> -----Original Message-----
>>> From: Jeff Westfahl [mailto:jeff.westfahl@ni.com]
>>> Sent: Wednesday, April 26, 2017 10:41 AM
>>> To: edk2-devel@lists.01.org
>>> Cc: Jeff Westfahl <jeff.westfahl@ni.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
>>> Carsey, Jaben <jaben.carsey@intel.com>
>>> Subject: [edk2][PATCH] ShellPkg/ShellCommandLib: Update DumpHex to
>>> print {|}~
>>> Importance: High
>>>
>>> ASCII characters {|}~ should be printed by DumpHex.
>>>
>>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>>> Cc: Jaben Carsey <jaben.carsey@intel.com>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com>
>>> ---
>>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
>>> b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
>>> index a2ebc8f..bd14878 100644
>>> --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
>>> +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
>>> @@ -1745,7 +1745,7 @@ DumpHex (
>>> Val[Index * 3 + 0] = Hex[TempByte >> 4];
>>> Val[Index * 3 + 1] = Hex[TempByte & 0xF];
>>> Val[Index * 3 + 2] = (CHAR8) ((Index == 7) ? '-' : ' ');
>>> - Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > 'z') ? '.' :
>>> TempByte);
>>> + Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > '~') ? '.' :
>>> TempByte);
>>> }
>>>
>>> Val[Index * 3] = 0;
>>> --
>>> 2.7.4
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
>>
>
>
next prev parent reply other threads:[~2017-04-26 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 17:40 [PATCH] ShellPkg/ShellCommandLib: Update DumpHex to print {|}~ Jeff Westfahl
2017-04-26 18:00 ` Carsey, Jaben
2017-04-26 18:12 ` Laszlo Ersek
2017-04-26 18:51 ` Jeff Westfahl
2017-04-26 19:37 ` Jeff Westfahl [this message]
2017-04-26 19:46 ` Laszlo Ersek
2017-04-26 19:47 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704261436360.19449@jmw-lm181 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox