From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00010702.pphosted.com (mx0a-00010702.pphosted.com [148.163.156.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B8BE42194D389 for ; Wed, 26 Apr 2017 12:37:50 -0700 (PDT) Received: from pps.filterd (m0098780.ppops.net [127.0.0.1]) by mx0a-00010702.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v3QJUoAK021567; Wed, 26 Apr 2017 14:37:49 -0500 Received: from ni.com (skprod3.natinst.com [130.164.80.24]) by mx0a-00010702.pphosted.com with ESMTP id 2a2jp40d9t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Apr 2017 14:37:49 -0500 Received: from us-aus-exch2.ni.corp.natinst.com (us-aus-exch2.ni.corp.natinst.com [130.164.68.12]) by us-aus-skprod3.natinst.com (8.16.0.17/8.16.0.17) with ESMTPS id v3QJbmWE022361 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 26 Apr 2017 14:37:48 -0500 Received: from us-aus-exch7.ni.corp.natinst.com (130.164.68.17) by us-aus-exch2.ni.corp.natinst.com (130.164.68.12) with Microsoft SMTP Server (TLS) id 15.0.1156.6; Wed, 26 Apr 2017 14:37:48 -0500 Received: from us-aus-exhub2.ni.corp.natinst.com (130.164.68.32) by us-aus-exch7.ni.corp.natinst.com (130.164.68.17) with Microsoft SMTP Server (TLS) id 15.0.1156.6; Wed, 26 Apr 2017 14:37:47 -0500 Received: from jmw-lm181.amer.corp.natinst.com (130.164.49.7) by us-aus-exhub2.ni.corp.natinst.com (130.164.68.32) with Microsoft SMTP Server id 15.0.1156.6 via Frontend Transport; Wed, 26 Apr 2017 14:37:47 -0500 Date: Wed, 26 Apr 2017 14:37:47 -0500 From: Jeff Westfahl X-X-Sender: jwestfah@jmw-lm181 To: Laszlo Ersek CC: "Carsey, Jaben" , Jeff Westfahl , "edk2-devel@lists.01.org" , "Ni, Ruiyu" In-Reply-To: <7a8b3c50-10ed-8eb7-7653-f37a63430a01@redhat.com> Message-ID: References: <1493228430-15322-1-git-send-email-jeff.westfahl@ni.com> <7a8b3c50-10ed-8eb7-7653-f37a63430a01@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-04-26_13:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704260327 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-04-26_13:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=30 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704260327 Subject: Re: [PATCH] ShellPkg/ShellCommandLib: Update DumpHex to print {|}~ X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 19:37:50 -0000 Content-Type: text/plain; charset="US-ASCII"; format=flowed Hi Laszlo, I liked your description so much that I copied it basically word for word in my PATCH v2 commit description. Is there some way I can attribute this to you in the commit description? Regards, Jeff On Wed, 26 Apr 2017, Laszlo Ersek wrote: > On 04/26/17 20:00, Carsey, Jaben wrote: >> I think that this is a correct change, but I do not understand the problem this solves. > > The problem is presumably that, if you have a string like > > {xizzy}~{foo|bar}~{quux} > > in the dumped data, it will not appear as such in the *-delimited ASCII > column to the right, but as > > .xizzy...foo.bar...quux. > > which is less than ideal. > > Thanks, > Laszlo > >> >> -Jaben >> >>> -----Original Message----- >>> From: Jeff Westfahl [mailto:jeff.westfahl@ni.com] >>> Sent: Wednesday, April 26, 2017 10:41 AM >>> To: edk2-devel@lists.01.org >>> Cc: Jeff Westfahl ; Ni, Ruiyu ; >>> Carsey, Jaben >>> Subject: [edk2][PATCH] ShellPkg/ShellCommandLib: Update DumpHex to >>> print {|}~ >>> Importance: High >>> >>> ASCII characters {|}~ should be printed by DumpHex. >>> >>> Cc: Ruiyu Ni >>> Cc: Jaben Carsey >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Jeff Westfahl >>> --- >>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c >>> b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c >>> index a2ebc8f..bd14878 100644 >>> --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c >>> +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c >>> @@ -1745,7 +1745,7 @@ DumpHex ( >>> Val[Index * 3 + 0] = Hex[TempByte >> 4]; >>> Val[Index * 3 + 1] = Hex[TempByte & 0xF]; >>> Val[Index * 3 + 2] = (CHAR8) ((Index == 7) ? '-' : ' '); >>> - Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > 'z') ? '.' : >>> TempByte); >>> + Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > '~') ? '.' : >>> TempByte); >>> } >>> >>> Val[Index * 3] = 0; >>> -- >>> 2.7.4 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel >> > >