From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.4265.1615524963969016398 for ; Thu, 11 Mar 2021 20:56:04 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: colin.xu@intel.com) IronPort-SDR: lzN2MlE6wEXsCB9qacibgRGstK9SoEBB6WZFBaet9PqdXIW440mf7ee5ZSjxRHAF90zu+8RRiD OIEc/s7ZfLJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="168700322" X-IronPort-AV: E=Sophos;i="5.81,242,1610438400"; d="scan'208";a="168700322" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 20:56:01 -0800 IronPort-SDR: ztzBuFH14XS0Ym0HAOMSw0z2XvEj64Fd7zttGGtb5a6U9vYt7TOy6YUYo+JTzi/GBZG0f9KpY7 BHqvFop5cSqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,242,1610438400"; d="scan'208";a="377595093" Received: from unknown (HELO coxu-arch-shz) ([10.239.160.25]) by fmsmga007.fm.intel.com with ESMTP; 11 Mar 2021 20:55:59 -0800 Date: Fri, 12 Mar 2021 12:55:59 +0800 (CST) From: "Colin Xu" X-X-Sender: coxu_arch@coxu-arch-shz To: devel@edk2.groups.io, rebecca@bsdio.com cc: lersek@redhat.com, colin.xu@intel.com, Gerd Hoffmann , Alex Williamson Subject: Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg/IntelGvtGopDxe: Intel GVT-g GOP Implementation. In-Reply-To: <1d2bf78f-6194-fe3e-0afe-6ebd3aa30839@bsdio.com> Message-ID: References: <714af4f188644d03cbb93eb7621c34a6386dff32.1614924813.git.colin.xu@intel.com> <60a24d26-e332-c907-61fe-648957708793@redhat.com> <1d2bf78f-6194-fe3e-0afe-6ebd3aa30839@bsdio.com> User-Agent: Alpine 2.22 (LNX 419 2020-04-12) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Fri, 12 Mar 2021, Rebecca Cran wrote: > On 3/5/2021 6:19 AM, Laszlo Ersek wrote: > >> (3) There's a whole lot of style issues in the code, and I absolutely >> don't see myself identifying every single one of those for you, in a >> 4000+ line driver. >> >> (EFI_D_xxx macro usage, line wrapping issues with multi-line function >> calls, comment style problems, an assumption of varargs support with >> function-like macros on all edk2 toolchains, building the driver only >> for X64, ...) > > The other style issue I noticed was the leading double underscores in the > include guards - e.g.: > Thanks Rebecca. I'll fix them. Best Regards, Colin > diff --git a/OvmfPkg/IntelGvtGopDxe/Common.h > b/OvmfPkg/IntelGvtGopDxe/Common.h > new file mode 100644 > index 000000000000..cf30752eb8f3 > --- /dev/null > +++ b/OvmfPkg/IntelGvtGopDxe/Common.h > @@ -0,0 +1,45 @@ > +/** @file > + Component name for the QEMU video controller. > + > + Copyright (c) 2021, Intel Corporation. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef __COMMON_H_ > > -- > Rebecca Cran > > > > > > > >