From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.82]) by mx.groups.io with SMTP id smtpd.web11.10231.1624373419294952269 for ; Tue, 22 Jun 2021 07:50:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=HA9XpoP/; spf=pass (domain: arm.com, ip: 40.107.6.82, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afAb7bSVY4HDR0A6K48TZDjSTzKbL24T/GyG+XnDtq4=; b=HA9XpoP/0BkC5dnrNXkxhftudL1JQWUjxBlhAhdO0od2jRBxF3kNiaqcPRorn1jqWpPSP+psC4pe29qV/hDXtl1Rj+GTPbI2yoVCgG/xNfn3L6pjDNvJBgNMzR96vu8EZeD16Ac+MSa+ntrxsO8H4XKl9fCsEAcpb2ScwEGmChk= Received: from AS8PR05CA0024.eurprd05.prod.outlook.com (2603:10a6:20b:311::29) by AM4PR08MB2787.eurprd08.prod.outlook.com (2603:10a6:205:d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.22; Tue, 22 Jun 2021 14:50:11 +0000 Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::e1) by AS8PR05CA0024.outlook.office365.com (2603:10a6:20b:311::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18 via Frontend Transport; Tue, 22 Jun 2021 14:50:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.16 via Frontend Transport; Tue, 22 Jun 2021 14:50:10 +0000 Received: ("Tessian outbound 7f55dcc5b33a:v96"); Tue, 22 Jun 2021 14:50:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fd7436e9869448cf X-CR-MTA-TID: 64aa7808 Received: from aec21be2fcbf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5F0EB48D-3EED-43B0-841F-88FA76698DB4.1; Tue, 22 Jun 2021 14:49:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aec21be2fcbf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Jun 2021 14:49:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSt4L+DVrIKonk9okGNl8Jk4MxOyVLXdzHXO+nYhWAbAhS+uG03hGH5QlvgVU/+g+mgs07R2eOLdsiBj393+Hzo9oU0Ne8cdBVY5K14rxx6ev0EWwcB8QaI2tf1ehspf+7wUYlz70g7aOgEgQAKnBZKjgOQnfHfPJXlLHuqQ8IJSuJOWl0f2fucJCmQorgIZ8Tyzwb74mCdPam3Cp+sH2Q459phrwiq43I8K5ragmNC5jfBEuXgP52Dzd+mqRmiDfvgQUfr4CXc33jFw1e22iDXwhffZm+DiYIkyXAlGUUYmGQQt34tgAa+XeWlNmhloaVViQjNYZE+1tiqo4y5c6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afAb7bSVY4HDR0A6K48TZDjSTzKbL24T/GyG+XnDtq4=; b=NA2rqnJMDtUUhl2Hgd7omEZVTyZ6g3l01IWb0se+GKxDWGg7OHHHi7jzJtOGFWPvLxDwoRuPXhP0Nt8hkAFJGZVJKZGggb4CbyHE3ejSYqpYDRP22hGBc3Mt8PAKhrCVhTrVS9zLYOPqVflEJ4OO5LNaVFptPrl47xDGNU8+AaXoQXb7zxH0zZzcHjCOUtTW1Op7TqBeYywQkcDOie7X+jhQvvMYWGXE6/yzFsLowzxz6H/BSp7KBK3oDpX0mUibzC2MFzjekmmY9W3p1tHFCHAM6o/sb41YqEVubwZWyl/A2CbmI8Ecb5yEKlDgccolo9S+QN+CjGKO5SvHMvy0RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afAb7bSVY4HDR0A6K48TZDjSTzKbL24T/GyG+XnDtq4=; b=HA9XpoP/0BkC5dnrNXkxhftudL1JQWUjxBlhAhdO0od2jRBxF3kNiaqcPRorn1jqWpPSP+psC4pe29qV/hDXtl1Rj+GTPbI2yoVCgG/xNfn3L6pjDNvJBgNMzR96vu8EZeD16Ac+MSa+ntrxsO8H4XKl9fCsEAcpb2ScwEGmChk= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4021.eurprd08.prod.outlook.com (2603:10a6:20b:aa::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18; Tue, 22 Jun 2021 14:49:31 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5c0d:142c:27df:c52b]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5c0d:142c:27df:c52b%5]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 14:49:31 +0000 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 2/4] Platform/ARM/N1Sdp: Introduce platform DXE driver To: devel@edk2.groups.io, khasim.mohammed@arm.com, nd References: <20210602124701.18045-1-khasim.mohammed@arm.com> <20210602124701.18045-3-khasim.mohammed@arm.com> From: "Sami Mujawar" Message-ID: Date: Tue, 22 Jun 2021 15:49:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210602124701.18045-3-khasim.mohammed@arm.com> X-Originating-IP: [217.140.106.54] X-ClientProxiedBy: LO2P265CA0270.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.54) by LO2P265CA0270.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.16 via Frontend Transport; Tue, 22 Jun 2021 14:49:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6fc77c51-66a5-4bde-d98d-08d9358d0903 X-MS-TrafficTypeDiagnostic: AM6PR08MB4021:|AM4PR08MB2787: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zmb3NkUkQJSMjInLoB2dsJZMyKwhYTwUacoNi82WkYXDGuZWcn1czUbgtUh689zsAKLCCZTKSrIwN8QYRjW7szuE0vBPR4Q+XbW/prPPmvg0wlZO7SF5RBd3Ak7KCCEhOgdr8gdVhvwWwWXJYWPbIFu7Dzoi2Ft7JICiSjwENk9js6ABbYTub7zj07cxgumYdSN6/E1+re80cY7cqZDZqId97quLjkkjqBw6zY6zTAWjy78v53SvstSa3WXkCH2GtGtTBb7q36GeUNy1d/yMJkRj/peYIXp0rgie6KrVsL31iODtxXLgmjvtlgORFw6jxtmuGlrZRR2lT6WwLgU0ckhqRe+hMxJckzsFHrQ90ehL1HZU/v/RDXAIPq8iLKlXiP/3/plINuX+JchRdXzVWVCLAxqb4kk9GtHA7jP24QhKol4NKY6IwP5amhy4gc4OZvXjEiQO4/Bfd3UEo2SMZVlB+p6iZvwHjepG9d4YaR5hE1icuGZ9+3E3+kxsC7EvoM88ztqtMp0ZyXcoQWPOz9d7Ddjdg4rguHCU+eSLLZwaZ/iyVBPaFg2hkjuLyGgoTNwlo7fMZpMUR95OiQGH+/Y4Z7weL6xtT3bBXPNUku0EimqiFLspENRvglnLU+dKYXX/NcKsbQvdHJQ8VZeH1Ks/7VaA/9XI5Svr4e8lbvFPUsfZ/pVK6VxzbFv4sThDh5DB1mgCa58Cljm0kome8w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(6636002)(478600001)(6862004)(19627235002)(6486002)(66556008)(44832011)(2616005)(956004)(66946007)(8936002)(16576012)(316002)(37006003)(8676002)(5660300002)(66476007)(86362001)(31686004)(2906002)(186003)(16526019)(26005)(53546011)(52116002)(83380400001)(38350700002)(31696002)(36756003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGx4VDZ1dThwWjRzSXcybHNIdWZGUlpJaEFsQXRDUnBaY3oyTFJ1dVY3S21I?= =?utf-8?B?a2Y5T0NUQlFxWllta2hJMXBrakdkemZxV2NFRy9XaEw4Y09uUy9hQmE0V2FE?= =?utf-8?B?U2QwY0lKVGcxSmhJNmdEYnRCdW9XNHFUSjlkV0hHYkdqZG1oMktmUFR5dEts?= =?utf-8?B?UmRETFJyb1pkQ25oczhyY1ZPdERxaWRWQW5uT0pYTkdnS1VQek41TW1RSElt?= =?utf-8?B?RVc3SDc0bGtJVFNXRmdVMTN0Mzg1dGdtQ3Z4ZDZuNjNsY0pNMWQ3TW1mTzNJ?= =?utf-8?B?ZnVXME1hU1VrdEg2N1dHa2RKVW9vK2NSeWN1azREZFlqWW1EbndtcnBjT2Ft?= =?utf-8?B?aFdzOVNtQ2lqQXdCUWJTcjcwQXpaNUdoVzBvVCtSTVQ3b1AveTA4ZlVLK1lv?= =?utf-8?B?THZXVERtd3kxVmpmZWIxbEZDb1ZQOU5QcHN6MkdBVTZEQVZXVlBzUjNTa2ho?= =?utf-8?B?Y25VM1pqbDh2VFowL3pGTEp0TGk4djBWR2FoOFRJZ3pGUW51c1NIYnl1NnA3?= =?utf-8?B?ZEw0MXFFQXdFQnpoRVlLYXRkaVJEekVwbkNtK1k4MndBRlVUelo4QW80TzlX?= =?utf-8?B?Ti9hNExDODFhcU9iSlVDOW5lTUpvWjAycklVemt5M0MyZHZ1VW1Td2k0b0k2?= =?utf-8?B?Z080R3poMGd6NTI4UmNZR3BFVTVmejZSZDkybldQTVpFTzh1OWdNbWdIMXN5?= =?utf-8?B?ckx0eUVFTklVRmo0L1B6Ymg1Zy9Jalo2QjQrQ2hoUEpweVJ2Um14UVpRZjRT?= =?utf-8?B?ZG5xbnJCZFcwelVESFMzR3g1MGRTYVNIM2dONEI3QWY3YkN2OWJZR0FGZXZ6?= =?utf-8?B?T3VqY3hXaStPZ0J1ZTVnMzBGcHhxZHJsejZtSCt6djJZWmtxQ0xpZkcrVHVv?= =?utf-8?B?QVE1eWNQM1Zyc1VGTUJpcmtJR3RydGhYT2lnMjNvSXJKVGlPRVBEYkFyZ00v?= =?utf-8?B?aG03VFN1dVhPd0J4czlUcFd6b1NOOFRwdE1TT0hQanpudWZuUkVCSFVyRGFS?= =?utf-8?B?dWd5ckcxb0tRRkpBRFE3cWVmOW5WaHhkTnl1V0M5YzdTZlFFK1dNb3o0ajNk?= =?utf-8?B?cHBCa1lkbFdoc0FnbnBSZEI2TU0rSmk1TVlsOHRwb2IyL20rZlV1bFdmNk1k?= =?utf-8?B?clBTd1ZRWWJuYTN6MjFrVFdHTXBYZnlxYnJPUzV4TUNLZ0FZdnJNbmR6bDFy?= =?utf-8?B?dHQ5cGx3VEFtajFMcVZoVERqRWxMUVZGb1FqalpRMWlXNTMraE9SSEU5UWNa?= =?utf-8?B?eDMrZVlvdlpBeW1iK1pUSHlzaWNoRkdwMllaektJT3VSSEljbXAyRFQ1SmJr?= =?utf-8?B?NElrZE9TK2JVTGdLZE5GOE0zK210SEpyREl3ZUljYk9QNVZONnJnNHUySWVC?= =?utf-8?B?VUdRMTlTU0wyVytaZURodlgweUVSYmEyNnpaV1V2YjdLb1plcVdqTEVUUFNa?= =?utf-8?B?VEFwU1VRanR4ODdHUGNKUTBHWXpJRFFmeE84VWdrZXZZeXZDZm9MR0x2eEhX?= =?utf-8?B?Qnp5c1cyZlcvNjk3U3hKZUp0Vlh5ZFdJemVGVFlKZHVvb0FXc0RPWCsybEJV?= =?utf-8?B?UkpaK1ZLNXJyWm11dG1vTmZvUDBTVmhuSjB1OXJpN3ZZVThqWDBERzdFeUw2?= =?utf-8?B?VDlzY1hBaHloblhmQVc0VTUxQlVpN3o0TENaR1hFVFpVQ2R4OTFUQUl4dHRh?= =?utf-8?B?MWdDUHcwZlIwclk1dmJEZzFGbTMwa3cvWkdMRzI1emFFODF3Sk9xcDBSNVFD?= =?utf-8?Q?hfM6gjPlUTsLKOi+2svDNFJ3e/W4iKoxA7p5Ykn?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4021 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c96ecfe6-06d7-4fe2-0e66-08d9358cf0cd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d+/jWLHvuFBrVM+Gv5MbEDQ7YQjiE0nvg4W4OTwRJ+QX6veFr/tm+KNvM+otyOWu0HZZIrl+qX4c2Fuy0MEnDbpNZYIZ8oM2obyMiYnovt28exYXBFA0HQ/m8+M4edkVIiJkJj5y2UZsM/hcAazTCH9v38zg2FdR5NKC3DwPYypns5sOsH2CLFFH5Cetuay6BUOVeRfRInBtcdVsE8VgBLjk5/WIZ7MWeU4z2gLRx5JjlmnM8OCUkFHbAN34e/ZTCIeH3Z/7UbZAFI3QA5PN16BwaFYafXq8cHRsR3zU31liGEhU+Lw5O0V01hA618Gi8VqMFEBUGnerUG8XLgaTrxRdx8cpgxBrhNjoHYxl5nCyHvnyo44vL18o9ia7aDccTtz5qvkR4WXFs+3+EJEF1/QJ0sbN+GQGXoqD5MBy5PVIiNHm3ShcBWnvfyA4Dsy8emb6PJml4Ikj20wRw6RnV2qOzLa2MT1NnNxpXtnRsL4zcK4LP0WTDwFOF8FY2CdmP8rfL7sJnrx4VE5yqLwSGKm8DpCCpvoRG3X0MdG1jpFaxyWXEAJVg+71saN5j24FheAt8KpLAVPg13zQfX5ta6vAVtwBIlNxn5lb9Bn2L6lqyvh9P4S4Uuul/meLgmp+SNdW/eJKfssasuqf0L5z6f54X2RHLl5CRki9tRDJc/efrxkT3SjM2Sd8VrpEUfDm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(136003)(39860400002)(376002)(396003)(46966006)(36840700001)(53546011)(83380400001)(19627235002)(47076005)(86362001)(478600001)(36756003)(44832011)(26005)(16526019)(8676002)(2616005)(186003)(2906002)(6636002)(31686004)(956004)(31696002)(5660300002)(82740400003)(336012)(356005)(8936002)(6862004)(37006003)(82310400003)(316002)(16576012)(70586007)(6486002)(36860700001)(81166007)(70206006)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2021 14:50:10.6780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6fc77c51-66a5-4bde-d98d-08d9358d0903 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2787 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Khasim, I can see that some changes to the PlatformDxe are in the last patch of this series. Do they belong here? Other than that, please find my response inline marked [SAMI]. Regards, Sami Mujawar On 02/06/2021 01:46 PM, Khasim Mohammed via groups.io wrote: > Add an initial platform DXE driver and support for ramdisk devices. > > Signed-off-by: Deepak Pandey > Signed-off-by: Khasim Syed Mohammed > --- > Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf | 44 +++++++++++= ++++++ > Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c | 51 +++++++++++= +++++++++ > 2 files changed, 95 insertions(+) > > diff --git a/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf b/Pla= tform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > new file mode 100644 > index 000000000000..925bde4063cc > --- /dev/null > +++ b/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > @@ -0,0 +1,44 @@ > +## @file > +# Platform DXE driver for N1Sdp > +# > +# Copyright (c) 2021, ARM Limited. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION =3D 0x0001001B > + BASE_NAME =3D PlatformDxe > + FILE_GUID =3D 11fc8b5a-377d-47a8-aee9-0093d3d3407= f > + MODULE_TYPE =3D DXE_DRIVER > + VERSION_STRING =3D 1.0 > + ENTRY_POINT =3D ArmN1SdpEntryPoint > + > +[Sources.common] > + PlatformDxe.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + ArmPlatformPkg/ArmPlatformPkg.dec > + EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + Platform/ARM/N1Sdp/N1SdpPlatform.dec > + > +[LibraryClasses] > + HobLib > + UefiDriverEntryPoint > + > +[Protocols] > + gEfiRamDiskProtocolGuid > + > +[FeaturePcd] > + gArmN1SdpTokenSpaceGuid.PcdRamDiskSupported > + > +[FixedPcd] > + gArmN1SdpTokenSpaceGuid.PcdRamDiskBase > + gArmN1SdpTokenSpaceGuid.PcdRamDiskSize > + > +[Depex] > + gEfiRamDiskProtocolGuid > diff --git a/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c b/Platf= orm/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c > new file mode 100644 > index 000000000000..e0b89556d40d > --- /dev/null > +++ b/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c > @@ -0,0 +1,51 @@ > +/** @file > + > + Copyright (c) 2021, ARM Limited. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > + > +/** > + Entrypoint of Platform Dxe Driver > + > + @param ImageHandle[in] The firmware allocated handle for the EF= I image. > + @param SystemTable[in] A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The entry point is executed successfully= . > +**/ > +EFI_STATUS > +EFIAPI > +ArmN1SdpEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + EFI_RAM_DISK_PROTOCOL *RamDisk; > + EFI_DEVICE_PATH_PROTOCOL *DevicePath; > + > + Status =3D EFI_UNSUPPORTED; > + if (FeaturePcdGet (PcdRamDiskSupported)) { > + Status =3D gBS->LocateProtocol (&gEfiRamDiskProtocolGuid, NULL, (VOI= D**) &RamDisk); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: Couldn't find the RAM Disk protocol - %r= \n", __FUNCTION__, Status)); > + return Status; > + } > + > + Status =3D RamDisk->Register ( > + (UINTN)PcdGet32(PcdRamDiskBase), > + (UINTN)PcdGet32(PcdRamDiskSize), [SAMI] Space needed between PcdGet32 and opening bracket. Please check at other places in this patch series. > + &gEfiVirtualCdGuid, > + NULL, > + &DevicePath); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: Failed to register RAM Disk - %r\n", __F= UNCTION__, Status)); > + } > + } > + return Status; > +} IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.