From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by mx.groups.io with SMTP id smtpd.web11.37859.1641846837490337685 for ; Mon, 10 Jan 2022 12:33:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=mFybshTB; spf=pass (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1641846837; x=1673382837; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to; bh=Y/tinbEAJCrrQ6mU0AbM1TQqaT3rKXUbm+7/jdmjSg8=; b=mFybshTBvi5HbzMcuLw7MIiI5i4cuypQar5cnZi3SrqQEW02T4/g5y/l ltqLR9Lz12+zYNHY+ym23SocC/Buy11J/oHDWkKfbZC1MiJcFDx7hpn+r 9f1fGOA/qgkw7u8h2PA9A0wQCT1PdbrL5Kna6TxUZXRZZLYmBdOUbaaUL s=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 10 Jan 2022 12:33:56 -0800 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 12:33:55 -0800 Received: from [10.110.110.167] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 10 Jan 2022 12:33:55 -0800 Message-ID: Date: Mon, 10 Jan 2022 13:33:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 To: Marcin Wojtas CC: Ard Biesheuvel , edk2-devel-groups-io , Ard Biesheuvel , Samer El-Haj-Mahmoud , Leif Lindholm , Sami Mujawar , Masami Hiramatsu , Graeme Gregory , Radoslaw Biernacki References: <20211215000324.11591-1-rebecca@nuviainc.com> <34eb1118-89a1-7d4d-3705-d9915d5ae859@nuviainc.com> From: "Rebecca Cran" In-Reply-To: Return-Path: quic_rcran@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Type: multipart/alternative; boundary="------------Ui6N1Cw6jk313efwfNxsrnUx" Content-Language: en-US --------------Ui6N1Cw6jk313efwfNxsrnUx Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Thanks! It looks like the existing changes covered Platform/Marvell/Cn913xDb/Cn913xDbA.dsc and Armada7k8kCapsule isn't something that would be broken by my changes. -- Rebecca Cran On 12/19/21 03:32, Marcin Wojtas wrote: > Hi, > > czw., 16 gru 2021 o 23:09 Rebecca Cran napisał(a): >> On 12/16/21 6:16 AM, Ard Biesheuvel wrote: >>> There were some changes a while ago to support standalone MM in 32-bit >>> mode, but I don't think any of the Platform/ARM platforms implement >>> that. So the best fix here is to simply stop lying about ARM support. >>> >>> As for RdkQemu - I think it is time we just remove that. >> During the work I found that the following list of platforms didn't build: >> >> >> o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due to OptionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf. >> >> o Features/Ext4Pkg/Ext4Pkg.dsc for ARM: edk2-platforms/Features/Ext4Pkg/Ext4Dxe/Inode.c:341: undefined reference to `__aeabi_uidivmod') >> >> o Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc for ARM >> >> o Platform/Hisilicon/{D03,D05,D06} for AARCH64: Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c:50:18: error: ‘EmHilink0Hccs1X8Width16’ undeclared here (not in a function)) >> >> o Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc for AARCH64 and ARM: error C0DE: Unknown fatal error when processing [Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc] >> > It is expected behavior. In order to succeed, proper -D FIRMWARE_IMAGE > and -D PLATFORM_NAME must be passed. > >> o Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc for ARM. >> >> o Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc for ARM. >> >> o Platform/ARM/SgiPkg/RdN2/RdN2.dsc for ARM. >> >> o Platform/ARM/SgiPkg/RdV1/RdV1.dsc for ARM. >> >> o Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc for ARM. >> >> o Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc for ARM. >> >> o Platform/Comcast/RDKQemu/RDKQemu.dsc for AARCH64 and ARM due to ACPI >> issue. >> >> o Platform/Marvell/Cn913xDb/Cn913xDbA.dsc for AARCH64 and ARM: tries to >> use literal $(PLATFORM_NAME). >> > The build is expected to fail - the user must explicitly pick the SoC > variant with -D flag, see the .dsc excerpt: > [Defines] > !if $(CN9130) > PLATFORM_NAME = Cn9130DbA > !elseif $(CN9131) > PLATFORM_NAME = Cn9131DbA > !elseif $(CN9132) > PLATFORM_NAME = Cn9132DbA > !endif > > Thanks, > Marcin > >> o Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc for AARCH64 >> and ARM: VariablePolicyHelperLib issue. >> >> o Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc for AARCH64 and ARM: >> T91 not found. >> >> -- >> Rebecca Cran >> --------------Ui6N1Cw6jk313efwfNxsrnUx Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit

Thanks! It looks like the existing changes covered Platform/Marvell/Cn913xDb/Cn913xDbA.dsc and Armada7k8kCapsule isn't something that would be broken by my changes.


--

Rebecca Cran


On 12/19/21 03:32, Marcin Wojtas wrote:
Hi,

czw., 16 gru 2021 o 23:09 Rebecca Cran <rebecca@nuviainc.com> napisał(a):

On 12/16/21 6:16 AM, Ard Biesheuvel wrote:

There were some changes a while ago to support standalone MM in 32-bit
mode, but I don't think any of the Platform/ARM platforms implement
that. So the best fix here is to simply stop lying about ARM support.

As for RdkQemu - I think it is time we just remove that.

During the work I found that the following list of platforms didn't build:


o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due to OptionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf.

o Features/Ext4Pkg/Ext4Pkg.dsc for ARM: edk2-platforms/Features/Ext4Pkg/Ext4Dxe/Inode.c:341: undefined reference to `__aeabi_uidivmod')

o Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc for ARM

o Platform/Hisilicon/{D03,D05,D06} for AARCH64: Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c:50:18: error: ‘EmHilink0Hccs1X8Width16’ undeclared here (not in a function))

o Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc for AARCH64 and ARM: error C0DE: Unknown fatal error when processing [Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc]


It is expected behavior. In order to succeed, proper -D FIRMWARE_IMAGE
and -D PLATFORM_NAME must be passed.


o Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc for ARM.

o Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc for ARM.

o Platform/ARM/SgiPkg/RdN2/RdN2.dsc for ARM.

o Platform/ARM/SgiPkg/RdV1/RdV1.dsc for ARM.

o Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc for ARM.

o Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc for ARM.

o Platform/Comcast/RDKQemu/RDKQemu.dsc for AARCH64 and ARM due to ACPI
issue.

o Platform/Marvell/Cn913xDb/Cn913xDbA.dsc for AARCH64 and ARM: tries to
use literal $(PLATFORM_NAME).


The build is expected to fail - the user must explicitly pick the SoC
variant with -D flag, see the .dsc excerpt:
[Defines]
!if $(CN9130)
  PLATFORM_NAME                  = Cn9130DbA
!elseif $(CN9131)
  PLATFORM_NAME                  = Cn9131DbA
!elseif $(CN9132)
  PLATFORM_NAME                  = Cn9132DbA
!endif

Thanks,
Marcin


o Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc for AARCH64
and ARM: VariablePolicyHelperLib issue.

o Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc for AARCH64 and ARM:
T91 not found.

--
Rebecca Cran
--------------Ui6N1Cw6jk313efwfNxsrnUx--