Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: support >=1TB high RAM, and discontiguous high RAM

[Laszlo Ersek <lersek@redhat.com>]

On 08/05/17 02:17, Jordan Justen wrote:
> On 2017-08-04 16:00:43, Laszlo Ersek wrote:

>> +    if (E820Entry.Type == EfiAcpiAddressRangeMemory &&
>> +        E820Entry.BaseAddr >= BASE_4GB) {
>> +      if (MaxAddress == NULL) {
>> +        UINT64 Base;
>> +        UINT64 End;
>> +
>> +        //
>> +        // Round up the start address, and round down the end address.
>> +        //
>> +        Base = ALIGN_VALUE (E820Entry.BaseAddr, (UINT64)EFI_PAGE_SIZE);
>> +        End = (E820Entry.BaseAddr + E820Entry.Length) &
>> +              ~(UINT64)EFI_PAGE_MASK;
> 
> I had set non-aligned Base/End one level out, and then rounded them here.
> 
>> +        if (Base < End) {
>> +          AddMemoryRangeHob (Base, End);
>> +          DEBUG ((
>> +            DEBUG_VERBOSE,
>> +            "%a: AddMemoryRangeHob [0x%Lx, 0x%Lx)\n",
>> +            __FUNCTION__,
>> +            Base,
>> +            End
>> +            ));
>> +        }
>> +      } else {
>> +        UINT64 Candidate;
>> +
>> +        Candidate = E820Entry.BaseAddr + E820Entry.Length;
> 
> Therefore I already had End here.
> 
>> +        if (Candidate > *MaxAddress) {
>> +          *MaxAddress = Candidate;
>> +          DEBUG ((
>> +            DEBUG_VERBOSE,
>> +            "%a: MaxAddress=0x%Lx\n",
>> +            __FUNCTION__,
>> +            *MaxAddress
>> +            ));
>> +        }
> 
> I just had:
> 
>         *MaxAddress = MAX(*MaxAddress, End);

Whenever you go to the trouble of coding up your suggestions, please
post them too! I'd welcome and appreciate that. I might even answer with
an R-b, and then it's faster for everyone. (And it's nice to have some
patches with dual S-o-b's :) )

> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Thank you, pushed as commit 1fceaddb12b5.

Laszlo