From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mx.groups.io with SMTP id smtpd.web08.3217.1623987066446475273 for ; Thu, 17 Jun 2021 20:31:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=VJYv9kL8; spf=pass (domain: gmail.com, ip: 209.85.214.179, mailfrom: emergingsiva@gmail.com) Received: by mail-pl1-f179.google.com with SMTP id x19so3986161pln.2 for ; Thu, 17 Jun 2021 20:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Rt5I1UOPJw7qU9pMdAJb9MWEN5Oxxve9YP2ZPYDJdYQ=; b=VJYv9kL8gzRTJ4I0jTrhD+/WezGbq+8sIUBBLpiIS4WbSfirve7AykJkipjOixNgG0 NT2deCrOtmYzXNsJ5tTxVG1oQEwZqawH/NCgU/7uihogDRc/QXDiLZ0pSsG2Km0FVv9g vm0jE0NmUW/duzL2rupf1+ZmwMDeJQsqFYVv6Gak0c/ZH2Lige8/P3PHdha7KY1DXnmy Yk8W6w5fHG4tIRAhpKt5cjuBoAP1ENJxy9CLNdLSvI6HWzezUmzLdkIfaAaDNyRinWsg shiW9Oe9FA7S39fv0lTocBY8bhU7ZuYDvQilO990ygwcaq/ocv0Qsd+XPziAxxlfUSE1 /O0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Rt5I1UOPJw7qU9pMdAJb9MWEN5Oxxve9YP2ZPYDJdYQ=; b=djiDqlGF3h7zUnBKzSGVs+OzCfS1CbuRhHVStV589nuyYypmB9T8yEH7V6unfl5D9v vTeO0hFkPurtF7Oq0f1fMq7eWYSqprauyEkwHqNIR3AhVafEWBllqrktstt4/81EtaY3 ihSxrHCV+KRoBsHAHZNJEDtnYDS7kr439paYRlGYyZO5be/KMlPAMG2UNJ02yANha78l EB6HaQVVrSnWZQyAvH7yZsUkfqsT0D3y+NRYpFriaHqeH7T6yPwuQOkK75xervQx3px/ iQ6H0xWRvrz3KUYW/HKSZBjWPgt2N/1C1M8I50bVPhGRRVtLFcZBw7v3q59meh4Ly+D+ PPcA== X-Gm-Message-State: AOAM532+DyxtGW+2rPbxskzaMASmEnl7QzToMxdVKe4Rf4WPKOouuEHT jX2YftAirmyovsrT3M0qDpye5fADLRghzw== X-Google-Smtp-Source: ABdhPJytsOjhAK3P89JUHZ5ZaUP2lg17UqT1TBo4nquxFkZiGswN1t6KeuribfgyCI4/C7VjeUykIQ== X-Received: by 2002:a17:90a:bb91:: with SMTP id v17mr2823999pjr.102.1623987065805; Thu, 17 Jun 2021 20:31:05 -0700 (PDT) Return-Path: Received: from UTILFW-8301.in.megatrends.com ([171.78.170.117]) by smtp.gmail.com with ESMTPSA id z24sm6606271pfk.149.2021.06.17.20.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 20:31:05 -0700 (PDT) From: "INDIA\\sivaramann" X-Google-Original-From: "INDIA\\sivaramann" To: devel@edk2.groups.io Cc: Sivaraman Subject: [PATCH] NetworkPkg: Addressed static code analyzer issues Date: Fri, 18 Jun 2021 09:00:45 +0530 Message-Id: X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver. In this function allowed events are Dhcp4RcvdOffer, Dhcp4SelectOffer, Dhcp4SendDiscover, Dhcp4RcvdAck. If any other event comes as input it will exit in beginning itself. Later below switch case handling the default case which is not reachable. I assume this code is a not reachable code and can be removed Signed-off-by: Sivaraman --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe= /PxeBcDhcp4.c index fb63cf61a9..c0d8211ea0 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c @@ -1331,8 +1331,6 @@ PxeBcDhcp4CallBack ( }=0D break;=0D =0D - default:=0D - break;=0D }=0D =0D return Status;=0D --=20 2.28.0.windows.1