From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C7ADB7803CF for ; Mon, 23 Oct 2023 17:12:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CB5COBKDhgBsuaS8r0dhTQuh2pcGZVV1/gq+HO3Z8S4=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698081172; v=1; b=LDN/RdchWlzlHpsky5fGs2oociqv3TXaSWJ0iUTm3fVk2OzquGoMZg/fA5kIhC/e4oNrmQ6R yZiMIWwSTuKrv9FytG6wq9X4adp2aLcITlBx/4Alk14gL9u9czeP5t7ndGU8h3rIUGtPw+cbjcT T8FGRliDOlhzua6DAJpH1cDg= X-Received: by 127.0.0.2 with SMTP id dadOYY7687511xwHy0B8zLB6; Mon, 23 Oct 2023 10:12:52 -0700 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.53]) by mx.groups.io with SMTP id smtpd.web11.126928.1698081171501074480 for ; Mon, 23 Oct 2023 10:12:52 -0700 X-Received: from AS4P250CA0008.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5df::9) by AM8PR08MB5715.eurprd08.prod.outlook.com (2603:10a6:20b:1d7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Mon, 23 Oct 2023 17:12:47 +0000 X-Received: from AM4PEPF00025F9C.EURPRD83.prod.outlook.com (2603:10a6:20b:5df:cafe::13) by AS4P250CA0008.outlook.office365.com (2603:10a6:20b:5df::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29 via Frontend Transport; Mon, 23 Oct 2023 17:12:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00025F9C.mail.protection.outlook.com (10.167.16.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.0 via Frontend Transport; Mon, 23 Oct 2023 17:12:46 +0000 X-Received: ("Tessian outbound 80b6fe5915e6:v215"); Mon, 23 Oct 2023 17:12:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: df026301a4827a56 X-CR-MTA-TID: 64aa7808 X-Received: from 30f9c963ff1a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5A76FAAF-FB7C-4670-9211-AC62555551F9.1; Mon, 23 Oct 2023 17:12:36 +0000 X-Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 30f9c963ff1a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 Oct 2023 17:12:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DSDvwhBlcb4Hn0KSnSkJkCHzlSPgIvFq4KWsSzcsfHqdDxTEfOYF3JDet75kn4q66VYt19ZphKRxLmjaB/6NyEiBDkpL2Re3RxmV2DMaQJhQZAdRJjWmLSQjtZ5rl1Ue8sTG4bvD8vxHwjX12qyCmRVCntVTXlLOzjYTVa+Vih00kSE7jl31R/TFbORYZdjPTL97stxI5jJvfFLNdh2ruxmw0uuPk/LxdE5h4lhHDLLc4fxuFsCLD60H4jviNxsoDALu+OXw9W4Q3+uv5TSczvCeQ8d46wUuQ+/O1XzQz6T+87/j/obLeoOcypFRCgiljs01jNZWnZ5DxocYG8m1GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4X7oKs+EK/jvzZIpBMZwuPEzgxd0Fr8h/vc3XlA4yMk=; b=h2e9ki/M8uHiwf9fgX2dkwgICfaGE1Ko0ByPntlmxhVjcAhdqyW2+U09c0ZjCOtG3lkjt90P5AhmaB06qT4ue5JGRQFuPx+pYas5KwSoqCAmOTe0zSFKQh2tAYLCmVShR/GoxjhW1baz+gXFC9E4R1obyxib5zwBgRYelT/LubOExaDmrvz+Wq07hw1r8bS8BaM+Fxpx31/3i+wYZ0eoqDQSVUw8vls/8NhM9oC8S+9uf7lKei7R2mh1wJk14gQ+RVViYjsbsi6M6+qCWaiACoLwmWNb4exS1078XtgMSISKZ2eauRD5VY21f6v/XqmoQNHgMscRPebDXaG5l5aFOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS4PR08MB8168.eurprd08.prod.outlook.com (2603:10a6:20b:58f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Mon, 23 Oct 2023 17:12:32 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7ae6:cb5f:525a:9afd]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7ae6:cb5f:525a:9afd%7]) with mapi id 15.20.6907.032; Mon, 23 Oct 2023 17:12:30 +0000 Message-ID: Date: Mon, 23 Oct 2023 18:12:29 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2] DynamicTablesPkg/AmlLib: Enumerate memory attributes To: Jeshua Smith , devel@edk2.groups.io Cc: pierre.gondois@arm.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, "nd@arm.com" References: <62418e30e2f01cd9234caa783e22fd6a18613d06.1696453749.git.jeshuas@nvidia.com> From: "Sami Mujawar" In-Reply-To: <62418e30e2f01cd9234caa783e22fd6a18613d06.1696453749.git.jeshuas@nvidia.com> X-ClientProxiedBy: LO4P265CA0205.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::19) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS4PR08MB8168:EE_|AM4PEPF00025F9C:EE_|AM8PR08MB5715:EE_ X-MS-Office365-Filtering-Correlation-Id: c68f6a45-2888-4f7e-2945-08dbd3eb46f2 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FtIsAv+kLtzzY7EbVr+qdiFjvbfLvfR/rhYQwLEwuhYWG6JhWK5+u1nbRx5xApUbKIUxLv9thsLayruAM1fVh2L9PE2LV7gSLQKKR74HRQYROS0hMoV92LyWCT4JHAYMMcIYDk4V6obiozQUuTP8Ky4mwEdXCTN5c8W4bSkHHoKNrx97fHKoQMKjkxEdFL8SaxfNwKLIAz3abS2jPlWGM9PUMxh3S2pHCXezo35OCwMWgPmRs3CEpwS9aSW1aJf+AZ+XnpQmO2rY5FCstVXeMwy+xWNDt61qX/8eCtRliIWRQNLonW5jVBQFB9tbMmTxGXW7lEPlQYnXosFKG/7aUNJfY2iM2w491HQOgMUjeM8mxqWtrsnUvn+/XheDPNvcHuIBt8Tiol7bx1/+JHUHSx9KVhHPH1g4ls9XT0LZ6piyekMxL6S1GkI25xm1PiAqn40BknRmJEpXihfvy677Q2C6tCoN6jq5Z2maaJ8WMNL8T8rVZ5Lx6WwCXJAFiKldkDDuoArZC3nXv1jY/RndyVMSQeNaOs6gEtNhlBaCXzs1Tr4NWlwhl01jnD47JHVvsx11jGBBqSrnrt22CitDEYG3n0wz/8OLoPuB1iy+Oz4P0plkRd3ir1HyYJuG0dtCATEmPv8Rg1H4BKDv9nraXg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(396003)(366004)(376002)(39860400002)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(6512007)(31686004)(8936002)(8676002)(316002)(66556008)(66476007)(66946007)(4326008)(86362001)(26005)(31696002)(6486002)(5660300002)(19627235002)(478600001)(6506007)(44832011)(53546011)(41300700001)(36756003)(2616005)(83380400001)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8168 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00025F9C.EURPRD83.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f0ad6673-52e3-4016-0845-08dbd3eb3d5c X-Microsoft-Antispam-Message-Info: zY1MiQ/NnF/wgrg+us17p37bJoRU7vpwtIr8D4UKXl5DELdsdbWXfB3/ZNf0808hQV4K8ACb6d41dSH38l7HSQEaL8A4H6x8C7Lf6SfKO3LjaZTYqE0ZuCF58deJqngpgIFQTIzxXZvQa51DHrRhsX4HnBKF+bcbwqQUbXcP6mazBV+hX/NxX3h503v59lh6SnjlomKwvpTY4kjCrsBTm7d9OVCZYGW2WROq4LcWHLxuEpSLkVIZR2e2n4ErBNo8bnHCyz0cOeMscXF22oB68UvO7iaSkAw9SoeAdm9Kqvd6JFpwPxcImtbeyoEw4dnpoxqhLg3UlW8QG+PCGaOoX4ZDxBOFC5Z4Fcqa98Qwx8cXXP/gahwIu3hYGA5Vw0HHZIuYIWkm0BNhjIiicCwONc/g7/6cnQCkNf9lavfwbMqdNFR5WIRJtPgzn5KKaoH7/puRe6G2UAXPBFoGIUUgRc2y9dwGHNUq3shhG5LoVQmDIMRPKxE6lh/2SirmRchmSmrYpfE3ViSJZyzg6RAlOFxcONDBm3/GXiMYg3SECML8WDfHk1OI2fGqjGLzLr8xXqlnCYRpZRjOuAdv9O5i9F2hi2v8V83/oOQZ89GW9nbOU5yGJHMh/oxK4UG6ny3qxoPr2ny/XhoUgyRazDcP4Sn7Djk/adhz6yUXY+YDRa1BhD4cEk4uFe43391CuqTGG/itCdc77xbO5urq5iUU/GRNYklVdcZkAuwV3DoR8DZ4M3AMw43a2w/u4p4pFVQJt+nZigkOyOI0U3eiHTxgdA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 17:12:46.3482 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c68f6a45-2888-4f7e-2945-08dbd3eb46f2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F9C.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5715 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BWQ0Zl8m2hTKYxnH1DkPnI3rx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="LDN/Rdch"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jeshua, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/10/2023 05:38 pm, Jeshua Smith wrote: > AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable > and MemoryRangeType parameters treat specific values as having > specific meanings as defined by the spec. This change adds enums to map > those meanings to their corresponding values. > > Signed-off-by: Jeshua Smith > --- > > Notes: > v2: based on comments from Pierre Gondois > - Added documentation reference > - Changed enum type and member names to closer align with documentatio= n > - Changed enum member names to CamelCase > - Added *Max members to enums > - Updated the signatures of relevant functions to use the enum types > instead of UNIT8 > > .../Include/Library/AmlLib/AmlLib.h | 49 +++++++++++++++++-- > .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 12 ++--- > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 8 +-- > 3 files changed, 55 insertions(+), 14 deletions(-) > > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTa= blesPkg/Include/Library/AmlLib/AmlLib.h > index 510c79a399..71e8539b30 100644 > --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > @@ -59,6 +59,47 @@ typedef void *AML_DATA_NODE_HANDLE; > =20 > #endif // AML_HANDLE > =20 > +/** Memory attributes, _MEM (2 bits) > + > + Possible values are: > + 0-The memory is non-cacheable > + 1-The memory is cacheable (DEPRECATED) > + 2-The memory is cacheable and supports > + write combining (DEPRECATED) > + 3-The memory is cacheable and prefetchable > + > + @par Reference(s): > + - ACPI 6.5, s6.4.3.5.5 "Resource Type Specific Flags" > + > +**/ > +typedef enum { > + AmlMemoryNonCacheable =3D 0, > + AmlMemoryCacheable =3D 1, > + AmlMemoryCacheableWriteCombine =3D 2, > + AmlMemoryCacheablePrefetch =3D 3, > + AmlMemoryCacheablityMax =3D 4 > +} AML_MEMORY_ATTRIBUTES_MEM; > + > +/** Memory attributes, _MTP (2 bits) > + > + Possible values are: > + 0-AddressRangeMemory > + 1-AddressRangeReserved > + 2-AddressRangeACPI > + 3-AddressRangeNVS > + > + @par Reference(s): > + - ACPI 6.5, s6.4.3.5.5 "Resource Type Specific Flags" > + > +**/ > +typedef enum { > + AmlAddressRangeMemory =3D 0, > + AmlAddressRangeReserved =3D 1, > + AmlAddressRangeACPI =3D 2, > + AmlAddressRangeNVS =3D 3, > + AmlAddressRangeMax =3D 4 > +} AML_MEMORY_ATTRIBUTES_MTP; > + > /** Parse the definition block. > =20 > The function parses the whole AML blob. It starts with the ACPI DSDT/= SSDT > @@ -578,7 +619,7 @@ AmlCodeGenRdDWordMemory ( > IN BOOLEAN IsPosDecode, > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > - IN UINT8 Cacheable, > + IN AML_MEMORY_ATTRIBUTES_MEM Cacheable, > IN BOOLEAN IsReadWrite, > IN UINT32 AddressGranularity, > IN UINT32 AddressMinimum, > @@ -587,7 +628,7 @@ AmlCodeGenRdDWordMemory ( > IN UINT32 RangeLength, > IN UINT8 ResourceSourceIndex, > IN CONST CHAR8 *ResourceSource, > - IN UINT8 MemoryRangeType, > + IN AML_MEMORY_ATTRIBUTES_MTP MemoryRangeType, > IN BOOLEAN IsTypeStatic, > IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL > OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL > @@ -809,7 +850,7 @@ AmlCodeGenRdQWordMemory ( > IN BOOLEAN IsPosDecode, > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > - IN UINT8 Cacheable, > + IN AML_MEMORY_ATTRIBUTES_MEM Cacheable, > IN BOOLEAN IsReadWrite, > IN UINT64 AddressGranularity, > IN UINT64 AddressMinimum, > @@ -818,7 +859,7 @@ AmlCodeGenRdQWordMemory ( > IN UINT64 RangeLength, > IN UINT8 ResourceSourceIndex, > IN CONST CHAR8 *ResourceSource, > - IN UINT8 MemoryRangeType, > + IN AML_MEMORY_ATTRIBUTES_MTP MemoryRangeType, > IN BOOLEAN IsTypeStatic, > IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL > OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci= eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci= eGenerator.c > index 9ddaddc198..72873709aa 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera= tor.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera= tor.c > @@ -566,7 +566,7 @@ GeneratePciCrs ( > IsPosDecode, > TRUE, > TRUE, > - TRUE, > + AmlMemoryCacheable, > TRUE, > 0, > AddrMapInfo->PciAddress, > @@ -575,7 +575,7 @@ GeneratePciCrs ( > AddrMapInfo->AddressSize, > 0, > NULL, > - 0, > + AmlAddressRangeMemory, > TRUE, > CrsNode, > NULL > @@ -588,7 +588,7 @@ GeneratePciCrs ( > IsPosDecode, > TRUE, > TRUE, > - TRUE, > + AmlMemoryCacheable, > TRUE, > 0, > AddrMapInfo->PciAddress, > @@ -597,7 +597,7 @@ GeneratePciCrs ( > AddrMapInfo->AddressSize, > 0, > NULL, > - 0, > + AmlAddressRangeMemory, > TRUE, > CrsNode, > NULL > @@ -718,7 +718,7 @@ ReserveEcamSpace ( > TRUE, > TRUE, > TRUE, > - FALSE, // non-cacheable > + AmlMemoryNonCacheable, > TRUE, > 0, > AddressMinimum, > @@ -727,7 +727,7 @@ ReserveEcamSpace ( > AddressMaximum - AddressMinimum + 1, > 0, > NULL, > - 0, > + AmlAddressRangeMemory, > TRUE, > CrsNode, > NULL > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDa= taCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDat= aCodeGen.c > index 9c6700b9e0..0bc1c1d119 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeG= en.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeG= en.c > @@ -570,7 +570,7 @@ AmlCodeGenRdDWordMemory ( > IN BOOLEAN IsPosDecode, > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > - IN UINT8 Cacheable, > + IN AML_MEMORY_ATTRIBUTES_MEM Cacheable, > IN BOOLEAN IsReadWrite, > IN UINT32 AddressGranularity, > IN UINT32 AddressMinimum, > @@ -579,7 +579,7 @@ AmlCodeGenRdDWordMemory ( > IN UINT32 RangeLength, > IN UINT8 ResourceSourceIndex, > IN CONST CHAR8 *ResourceSource, > - IN UINT8 MemoryRangeType, > + IN AML_MEMORY_ATTRIBUTES_MTP MemoryRangeType, > IN BOOLEAN IsTypeStatic, > IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL > OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL > @@ -1161,7 +1161,7 @@ AmlCodeGenRdQWordMemory ( > IN BOOLEAN IsPosDecode, > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > - IN UINT8 Cacheable, > + IN AML_MEMORY_ATTRIBUTES_MEM Cacheable, > IN BOOLEAN IsReadWrite, > IN UINT64 AddressGranularity, > IN UINT64 AddressMinimum, > @@ -1170,7 +1170,7 @@ AmlCodeGenRdQWordMemory ( > IN UINT64 RangeLength, > IN UINT8 ResourceSourceIndex, > IN CONST CHAR8 *ResourceSource, > - IN UINT8 MemoryRangeType, > + IN AML_MEMORY_ATTRIBUTES_MTP MemoryRangeType, > IN BOOLEAN IsTypeStatic, > IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL > OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109934): https://edk2.groups.io/g/devel/message/109934 Mute This Topic: https://groups.io/mt/101780411/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-