From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.9766.1620722009002857694 for ; Tue, 11 May 2021 01:33:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Fn8RO+8w; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620722008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/wZSqfxOkFxqt6E8QQI2fN4lc8zW0Gs/rQaM7euYkQ0=; b=Fn8RO+8wr0E+pOWH0I4EBAsCzikEX+Sa/cDQiDXmugQJZmM8C54xnFSjWP92h05k6UBiXf SfyEz+5w32fLHOwrbR2G/yTlpGWw+18YKg9sLDte5PGVgwK6EBSDSLCpKjM9a++Af2hgfL WKUJpHKEpZDPQ+nbzmMKha4R3ktgBbo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-W5SGLKxaMzWylCTc_VJBMQ-1; Tue, 11 May 2021 04:32:44 -0400 X-MC-Unique: W5SGLKxaMzWylCTc_VJBMQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 731AC107ACC7; Tue, 11 May 2021 08:32:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-233.ams2.redhat.com [10.36.112.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E59DE2DA; Tue, 11 May 2021 08:32:39 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 01/13] MdePkg/Register/Amd: expand the SEV MSR to include the SNP definition To: devel@edk2.groups.io, brijesh.singh@amd.com Cc: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu References: <20210507203838.23706-1-brijesh.singh@amd.com> <20210507203838.23706-2-brijesh.singh@amd.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 11 May 2021 10:32:38 +0200 MIME-Version: 1.0 In-Reply-To: <20210507203838.23706-2-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/07/21 22:38, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Define the SEV-SNP MSR bits. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Brijesh Singh > --- > MdePkg/Include/Register/Amd/Fam17Msr.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Register/Amd/Fam17Msr.h > index e4db09c5184c..716d52fd508d 100644 > --- a/MdePkg/Include/Register/Amd/Fam17Msr.h > +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h > @@ -87,7 +87,12 @@ typedef union { > /// > UINT32 SevEsBit:1; > > - UINT32 Reserved:30; > + /// > + /// [Bit 2] Secure Nested Paging (SevSnp) is enabled > + /// > + UINT32 SevSnpBit:1; > + > + UINT32 Reserved2:29; > } Bits; > /// > /// All bit fields as a 32-bit value > Reviewed-by: Laszlo Ersek