From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by mx.groups.io with SMTP id smtpd.web08.260.1615917402492473217 for ; Tue, 16 Mar 2021 10:56:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=iKGKXY7A; spf=pass (domain: oracle.com, ip: 141.146.126.78, mailfrom: ankur.a.arora@oracle.com) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12GHt2RH065384; Tue, 16 Mar 2021 17:56:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=69dXEYHFbV8YJEI+Y0RoWsK5+XKY2jQV6cj6IybSP3Y=; b=iKGKXY7As0X0LC3Y52okwQEupBqqkNoppiM55xPSnC01SwXHm1M06TTQ2e815LABRJXB 9V5nsw3H/Jgs4K3mmrd/5dEao2wbMXJU4A9M20+uSHySvHnVoGW/jdxyLRLpBSEr/GJj ZHCiwE1CTI1hduoTV9LtuZ6dIfyq22bR1J3OsnoMAgdBXNr/68aqlJ4RSI5JYPjxa5zf tZe09B0KcslRLOEnPWQRO5R2KYA70geNEOPcX4ewR/mPktrxlqhR90rEjhP2QEvTcIjH 8aoHiUqGTw6ATjgCSgxdc2u1YAmrXphNxTmtkbZ7IAwFmWysn4IjpHo3fQwsZ66H10Nd Ow== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 378nbm96j0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 17:56:41 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12GHtLrK174111; Tue, 16 Mar 2021 17:56:40 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175]) by userp3020.oracle.com with ESMTP id 37a4et948r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 17:56:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ND2gdzeUMJipGAEik0sOAPiE7FX2t+y8flfbLqXHLg0q0tj4sYtZQ/HgsE5pjP6oBW8nwbku3c9ZrSv2HLUFaUxBDdYMwD1P2EyDRaDJQmfwX2UxbbwnHDAKBvt9egwIuWUNu/Vaunl5Z2FLqT3uqaFPsfmIyQrKP2+exICgHCOJIavV9E+5IUT6jNZFepw77Jd70JNXJ9HJ0YIyP95vLkdPernB2dCvx+oFYYrdVFXEYQQgWrkv9g8wZqZCda3Xif8B9Nbh0C5e1JAhFs7nzi7/eZTLU6ZXCEyxab9RTsNn73wwxunlGAbnuzev8dR6XTLGCxfrpEnFiC3gJq8KtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=69dXEYHFbV8YJEI+Y0RoWsK5+XKY2jQV6cj6IybSP3Y=; b=VvZhWLwfkTyo8phxsFLzNjdstExFcRA3LRVQns5Z8QpuoodWqHx7kliHPZpiPHm5nkPomRccs7IU3JTGc19tJ8I8Gga3SrTl4CT5IwYTt8hg9bYogBY2UioXtOu5ywiAOoRRZITUFa/S5IGG2QgSnJZsHT1+Rl64y6e8mb9MK2N18QJZcUDfmZuftj090PU1vwtcy9PBTGZygynAThNyk84/sdC3Osyrm6CFKRTFjubUFwiLbQnVj7NLE2zlKX6DhwZpw4YbTfdvM3BPpIEELMK44dytTuLQrFwARUzXYblgnv/0TiUp4yA/bDOVWYDi/W8ttp1C8DtHa8Uv3qnYuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=69dXEYHFbV8YJEI+Y0RoWsK5+XKY2jQV6cj6IybSP3Y=; b=n8xmnu73FOu7GBP0wvyevB5yhIiUu23NvXqJHFXQ605YxiKCADp/ZsPJTFaC3rbM26DS/BtIxduzXY3nRdftRdB6YWFO2YezrvbFi8HihL+VfZF4Id41DEVaRcNkp8cXeSWXHupmRwmRw60ctSJogvwmo8avI5VxGsI+5Og1tLY= Received: from SJ0PR10MB4605.namprd10.prod.outlook.com (2603:10b6:a03:2d9::24) by SJ0PR10MB4813.namprd10.prod.outlook.com (2603:10b6:a03:2d2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 16 Mar 2021 17:56:38 +0000 Received: from SJ0PR10MB4605.namprd10.prod.outlook.com ([fe80::a021:790:7ce6:6f16]) by SJ0PR10MB4605.namprd10.prod.outlook.com ([fe80::a021:790:7ce6:6f16%6]) with mapi id 15.20.3912.031; Tue, 16 Mar 2021 17:56:38 +0000 Subject: Re: [PATCH v9 00/10] support CPU hot-unplug To: Laszlo Ersek , devel@edk2.groups.io Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com References: <20210312062656.2477515-1-ankur.a.arora@oracle.com> From: "Ankur Arora" Message-ID: Date: Tue, 16 Mar 2021 10:56:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: X-Originating-IP: [148.87.23.11] X-ClientProxiedBy: MW4PR03CA0239.namprd03.prod.outlook.com (2603:10b6:303:b9::34) To SJ0PR10MB4605.namprd10.prod.outlook.com (2603:10b6:a03:2d9::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.108] (148.87.23.11) by MW4PR03CA0239.namprd03.prod.outlook.com (2603:10b6:303:b9::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Tue, 16 Mar 2021 17:56:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52fce6f2-cb81-4d9b-2311-08d8e8a4d881 X-MS-TrafficTypeDiagnostic: SJ0PR10MB4813: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: trwpC1J6kriV2+wgM1mc8axd+AA797CsF5bIg0dmGHfHHkD5cIH217vONTF7E3EKoCUK39m8IgaJBEBQscJNRfq47DVQbHfAWFeXdZAfxB79aO9s8NgBVoOpif66egMxLyd6MyBeb81mgGRO4NMfSr55BIUstA7YozWjLwX8VfFQ7VezOWzKlY4htXYVcuGRz12wHJoPLUmsESv1ud6zgwnYkplkxvvAekKJW2EosZth41zwmx8RTsnLrSRDFzfNo1x+w10y0mKBhxxzlxWh93JHipl/wZQBH4IHHTnq3pn2VdPGr6AHl5xv8QvWWmquuVN6uSACqf8C8HpD+Gcf6sEuDVFSdQMebhhZDShvLPlE21kRPO/D9rwQvJ15mim9yxj8LspBs13FouOJVNaZNdJsAkws9DrLIt42BGwTr60y10T8F9QXGyknIhVTdx4KFbkO4AuzPDXJDqUJuFjWYPeugCvvfGXVPZHf3iSxa9QCAKXC3Wg3ocOQEoAVARTgcHILB48Y/yZ4MMfzD5bv8jw3XzwrbD2KzYgivM+241pAr+IIJO4bQopAIwQFWPgrEg9zLxm14nN+lN/Dam9iyxKC8N0h0yc28BhT5j/M0S4O6U0zRsj535blsfgqU2Qe3lYN2YVkxm9CluzSCwFsqWxa7MMfceaSQRt1bOilLIea9DAdLpx7YhSAG+FS7bFlc5xX1In+mN3gonL0UPVPLCP1p/afvPP/BHs3mUS57f8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4605.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(346002)(366004)(376002)(26005)(66946007)(66476007)(66556008)(5660300002)(8676002)(16526019)(186003)(478600001)(966005)(2906002)(83380400001)(31696002)(53546011)(6666004)(6486002)(107886003)(4326008)(36756003)(956004)(8936002)(2616005)(86362001)(31686004)(19627235002)(316002)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?amI3aFg4c2NHNkJtMkRrcVlHMDJSbmt2MHFCanhURnJrUUg1MVIwanFGNDRk?= =?utf-8?B?ZllVbGJHWkp6QTFTTHF5dFFQRjZMdXBoVlJoalNhVUhoNXJIakx3V1lPdDE2?= =?utf-8?B?VFgzVG82cnN5YWN2MjJwRi9YK0JuVVFqQ1JjcVdadXloSW9UTUNHZGxlUEw2?= =?utf-8?B?Z01uNDZKY1dlYkxaRUx2enFhUm9HMGJobmIyM3BRaFNMekFEOXZwN3lzWUtI?= =?utf-8?B?NW9EdGlodDBNMFdWS3ZKK2N6MkwwT2pmR1dMa1dOY01Yd1JmNHNyUkhEWDVl?= =?utf-8?B?MzdxTktxZXVpSkRRU3FvNkpJc2ZEVnRqREhBZmRFNG5DK0Z2dVVJdlhoa1Vv?= =?utf-8?B?OXZKOXVGNTZBNXVkQnRFTytHR2FkbzRMZlpDRnpoYy8wcTdIM3k4aFQyU2px?= =?utf-8?B?OGlMMlk0ZTd1TEVRUWFmLzRmY2RUcmUyWEY1OFNkL2VrVXl6WFlzeXYyVHRs?= =?utf-8?B?WjNGT0ZyMHNhSkZRZ0pZNUc4VXdWZzFrSXFrSUZDSmRCb2w3ZHltdHVwRTZV?= =?utf-8?B?a2NMRnRRL2dJYk54eUZheEVHbE1UVDErajNiK0lRQXdGOWVrSmV6Z1diYVR5?= =?utf-8?B?RndNZzRLWDZIeVA5cHhxZlp5cnZOdytNcG5nRHBrbWFkbUhlOTc3SzMwaUlX?= =?utf-8?B?bldOTDkxTGlDTWlaV0o3N05WMTdhWktPM083VzdTSFVwdWwvL0RSdmwrYzV6?= =?utf-8?B?ZEdQd2lKZGRUSFB0LzBKZXRZNGxHb25UZStLbXFlNytYL3hDV2hoTFZ3UXpO?= =?utf-8?B?ekcyUkwzcWE5bUhybG1CNmdKOUxaUkhwV2IvQmhrR3h1YWtBS0xJVVQ2a2d2?= =?utf-8?B?bEJzZ1l2TUlFRlRNdW1JYkc5RkRCWThPN1NEVU5VdExqR09QdHZlN0pmcTJw?= =?utf-8?B?Qzg2b0orS2xHOE1hUDJKVEI2NWV4RVJadTdzMXp2YVhQbTZpYjlvcVNvV2V6?= =?utf-8?B?MEZxMkNScERwbUVLR24xQVp6Z1lxakxldnBUSUdoVThQVHZjOTJkSkhxVUJY?= =?utf-8?B?UVdrL3h2aHlaMEVId0l6QU9JSVQ4T1BpdkRFeTNFTVZpMTVTWno5V2s2M1VX?= =?utf-8?B?ang1bE5CZFpqSGFSRlZmL1BDMWhya1h4SXlZci9Od3RhUHNVbmt1dzBSSEdB?= =?utf-8?B?eEwwZzJnaUJ4ZTJOOHR4cXk3aG9PTE5TTGdreVluM282UHcyN0RTa044cWRz?= =?utf-8?B?OHN0MWJqbkRHMEFxaHNNaWRKcytMYnJjMmMvZFQ2bGp3WmdrQVpsbkZ0MU9u?= =?utf-8?B?dGVVTHA5bVp3ZEZINXByTnlHZWFZQy9FK0REaWFzNVNocnI1WExDZFNGTW16?= =?utf-8?B?dDB2dENMd1VUSjQ0bVpVWHdnMlF5MmlYRGh0aE9pMkRFeUI1dEg5RnRJcUEx?= =?utf-8?B?SHBmZWJKN1B0bnJpY2orOUpieUt5UlN1SEpYS1YzOG01Znp6NThOVzJYdDlD?= =?utf-8?B?bGl3S2E2WkdvaXNtbjhiOTNVRXVtM282ZHlUTGh1czZMK21zMndMSEptOWpO?= =?utf-8?B?ZjVXdjdleUZFUnNjeG5TUStTRWdTdFpIaGoyOVgwajR6clNMM1VSam84U1NJ?= =?utf-8?B?WVlMN05Obit1QzRsTzgxWVB2MHBsSnBrK2llbFE4ek94R3l6Wnl3OHd5LzJW?= =?utf-8?B?cWZMMWo5bStIMWVlQjRqbmVmM1BaenhBS1RhWGhTbGxRVnNhdzBiYmh6NFdz?= =?utf-8?B?dFlicmMzY2JpMkIwbzM2WlZNMkoyaTZ2RC9qT0xrWFk4Wis5SnRtUWdwODQx?= =?utf-8?Q?mJkBh8uM8dtauvY857cxOi0oLkucvMFnCg7R+1y?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52fce6f2-cb81-4d9b-2311-08d8e8a4d881 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4605.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 17:56:38.1311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: asTIk1T4InBN+hiQncpWwx3nWg3zQJ2emdiQiXK/0DoqtLufmBKn8ga1kLwvF9y4Ta924AaaFVOXBal5bim7Accdrd4islNVx1ErNBOV9p0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4813 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160114 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160114 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2021-03-16 7:07 a.m., Laszlo Ersek wrote: > On 03/12/21 07:26, Ankur Arora wrote: >> Hi, >> >> This series adds OVMF support for CPU hot-unplug. >> >> QEMU secureboot hot-unplug logic corresponding to this is in upstream. >> Also posted here: >> https://lore.kernel.org/qemu-devel/20201207140739.3829993-1-imammedo@redhat.com/ >> >> Testing (with QEMU 5.2.50): >> - Stable with randomized CPU plug/unplug (guest maxcpus=33,128) >> - Synthetic tests with simultaneous multi CPU hot-unplug >> >> Also at: >> github.com/terminus/edk2/ hot-unplug-v9 >> >> Changelog: >> >> v9: >> - Rebased on top of edd46cd407ea >> - Clarify comments around memory-barriers in patches 7, 8, 9 >> - Address other review comments from v8 > > Merged as commit range 4751a48aeb2a..f3bdfc41866e, via > , with the following R-b's > / comments / light tweaks added: Awesome! Thanks Laszlo. And, thanks especially for the thorough reviews. Ankur > >> 1: 4b4466ed7c44 = 1: 0cb242e33693 OvmfPkg/CpuHotplugSmm: refactor hotplug logic >> 2: 719828efdebe ! 2: a752dd07466c OvmfPkg/CpuHotplugSmm: collect hot-unplug events >> @@ -20,6 +20,7 @@ >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 >> Signed-off-by: Ankur Arora >> Message-Id: <20210312062656.2477515-3-ankur.a.arora@oracle.com> >> + Reviewed-by: Laszlo Ersek >> >> diff --git a/OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h b/OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h >> --- a/OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h >> 3: 7d732efcb7af = 3: 2d92e052c3af OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper >> 4: 64649eeeee42 = 4: 15e6ae8ea400 OvmfPkg/CpuHotplugSmm: introduce UnplugCpus() >> 5: 7190a5d134a7 ! 5: 8ade9d425a6e OvmfPkg: define CPU_HOT_EJECT_DATA >> @@ -15,6 +15,7 @@ >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 >> Signed-off-by: Ankur Arora >> Message-Id: <20210312062656.2477515-6-ankur.a.arora@oracle.com> >> + Reviewed-by: Laszlo Ersek >> >> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec >> --- a/OvmfPkg/OvmfPkg.dec >> 6: 1fd019dac476 ! 6: b6d5996706dd OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state >> @@ -22,6 +22,7 @@ >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 >> Signed-off-by: Ankur Arora >> Message-Id: <20210312062656.2477515-7-ankur.a.arora@oracle.com> >> + Reviewed-by: Laszlo Ersek >> >> diff --git a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf b/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf >> --- a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf >> 7: c8758d9b9764 ! 7: af9c77e151fa OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler >> @@ -19,6 +19,7 @@ >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 >> Signed-off-by: Ankur Arora >> Message-Id: <20210312062656.2477515-8-ankur.a.arora@oracle.com> >> + Reviewed-by: Laszlo Ersek >> >> diff --git a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c >> --- a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c >> 8: 5ff8e8700678 ! 8: 30c69d2cfa63 OvmfPkg/CpuHotplugSmm: add EjectCpu() >> @@ -19,6 +19,7 @@ >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 >> Signed-off-by: Ankur Arora >> Message-Id: <20210312062656.2477515-9-ankur.a.arora@oracle.com> >> + Reviewed-by: Laszlo Ersek >> >> diff --git a/OvmfPkg/CpuHotplugSmm/CpuHotplugSmm.inf b/OvmfPkg/CpuHotplugSmm/CpuHotplugSmm.inf >> --- a/OvmfPkg/CpuHotplugSmm/CpuHotplugSmm.inf >> 9: d6660f8f2f14 ! 9: f05328886302 OvmfPkg/CpuHotplugSmm: do actual CPU hot-eject >> @@ -27,6 +27,9 @@ >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 >> Signed-off-by: Ankur Arora >> Message-Id: <20210312062656.2477515-10-ankur.a.arora@oracle.com> >> + Reviewed-by: Laszlo Ersek >> + [lersek@redhat.com: unneeded inner QemuSelector declaration in EjectCpu() >> + triggers VS warning #4456 (local variable shadowed); remove it] >> >> diff --git a/OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h b/OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h >> --- a/OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h >> @@ -102,8 +105,6 @@ >> + UINT32 Idx; >> + >> + for (Idx = 0; Idx < mCpuHotEjectData->ArrayLength; Idx++) { >> -+ UINT64 QemuSelector; >> -+ >> + QemuSelector = mCpuHotEjectData->QemuSelectorMap[Idx]; >> + >> + if (QemuSelector != CPU_EJECT_QEMU_SELECTOR_INVALID) { >> 10: 0a9a1cd40b98 ! 10: f3bdfc41866e OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug >> @@ -14,6 +14,9 @@ >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 >> Signed-off-by: Ankur Arora >> Message-Id: <20210312062656.2477515-11-ankur.a.arora@oracle.com> >> + [lersek@redhat.com: preserve the empty line between the ICH9_LPC_SMI_F_* >> + group of macro definitions and the SCRATCH_BUFFER type definition] >> + Reviewed-by: Laszlo Ersek >> >> diff --git a/OvmfPkg/SmmControl2Dxe/SmiFeatures.c b/OvmfPkg/SmmControl2Dxe/SmiFeatures.c >> --- a/OvmfPkg/SmmControl2Dxe/SmiFeatures.c >> @@ -22,16 +25,15 @@ >> // "etc/smi/supported-features" and "etc/smi/requested-features" fw_cfg files. >> // >> #define ICH9_LPC_SMI_F_CPU_HOTPLUG BIT1 >> -- >> +// >> +// The following bit value stands for "enable CPU hot-unplug, and inject an SMI >> +// with control value ICH9_APM_CNT_CPU_HOTPLUG upon hot-unplug", in the >> +// "etc/smi/supported-features" and "etc/smi/requested-features" fw_cfg files. >> +// >> +#define ICH9_LPC_SMI_F_CPU_HOT_UNPLUG BIT2 >> + >> // >> // Provides a scratch buffer (allocated in EfiReservedMemoryType type memory) >> - // for the S3 boot script fragment to write to and read from. >> @@ >> QemuFwCfgReadBytes (sizeof mSmiFeatures, &mSmiFeatures); >> > > Thanks for the contribution, > Laszlo >