From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.26770.1611144886932374249 for ; Wed, 20 Jan 2021 04:14:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=boAkwbhv; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611144886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=veorwg3aqUO7kCOKToCen43qaCWdvcW3PLwjaO91kYw=; b=boAkwbhvHYUhWEwbTH40TFrJkqwtTK7jcTxrg0Gg3Mn6kMzT7iEhs+XsoZg/iIqyPrruHN TDJbFunksASK0pkwJTd0OThY4R3qak4450dNzevPTOSBeaz6fMDrj30RuSHytgKRTi5+mj /sFSyt6b+dwtIOPrEU/HeLDoG6+Hn9s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-186-rGUxbSF7P3KXCJFSfOZxOw-1; Wed, 20 Jan 2021 07:14:42 -0500 X-MC-Unique: rGUxbSF7P3KXCJFSfOZxOw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 589291005504; Wed, 20 Jan 2021 12:14:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-96.ams2.redhat.com [10.36.115.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7C33C60C69; Wed, 20 Jan 2021 12:14:37 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v6 03/11] OvmfPkg/PciHostBridgeLib: List missing PcdLib dependency To: devel@edk2.groups.io, cenjiahui@huawei.com Cc: Jordan Justen , Ard Biesheuvel , Rebecca Cran , Peter Grehan , Anthony Perard , Julien Grall , Leif Lindholm , Sami Mujawar , xieyingtai@huawei.com, wu.wubin@huawei.com References: <20210119011302.10908-1-cenjiahui@huawei.com> <20210119011302.10908-4-cenjiahui@huawei.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 20 Jan 2021 13:14:36 +0100 MIME-Version: 1.0 In-Reply-To: <20210119011302.10908-4-cenjiahui@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > OvmfPkg/PciHostBridgeLib instance fails to list its PcdLib dependency, > both between the #include directives, and in the INF file. So let's list > the dependency. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Jiahui Cen > --- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 1 + > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > index 4c56f3c90b3b..cec3f1631a72 100644 > --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > @@ -39,6 +39,7 @@ [LibraryClasses] > DebugLib > DevicePathLib > MemoryAllocationLib > + PcdLib > PciHostBridgeUtilityLib > PciLib > QemuFwCfgLib > diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > index 4a176347fd49..bf32455b9f0d 100644 > --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > index e161f14375ca..95ed0a280b9b 100644 > --- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > +++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include "PciHostBridge.h" > At this stage, "XenSupport.c" doesn't seem to call any PcdLib API. But, it's not a big deal. Reviewed-by: Laszlo Ersek Thanks, Laszlo