Re: [PATCH v2 1/6] OvmfPkg/Amdsev: Base commit to build encrypted boot specific OVMF

["Laszlo Ersek" <lersek@redhat.com>]

On 11/24/20 00:25, James Bottomley wrote:
> On Mon, 2020-11-23 at 19:01 +0100, Laszlo Ersek wrote:
>> On 11/20/20 19:45, James Bottomley wrote:

>>> +[PcdsFixedAtBuild]
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationCh
>>> ange|FALSE
>>> +  gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
>>> +!if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048)
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
>>> +  # match PcdFlashNvStorageVariableSize purely for convenience
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000
>>> +!endif
>>> +!if $(FD_SIZE_IN_KB) == 4096
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x8400
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x8400
>>> +  # match PcdFlashNvStorageVariableSize purely for convenience
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x40000
>>> +!endif
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x80000
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVolatileVariableSize|0x4000
>>> 0
>>
>> (3) The above two PCD settings are conditional on NETWORK_TLS_ENABLE
>> being TRUE, so please remove them together with the condition.
> 
> I removed them and assumed "with the condition" meant with the
> condition you removed in the first iteration.

Right, I meant that the entirety of:

!if $(NETWORK_TLS_ENABLE) == TRUE
  gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x80000
  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVolatileVariableSize|0x40000
!endif

should be removed.

Thanks!
Laszlo