From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web09.44647.1606175014074447486
 for <devel@edk2.groups.io>;
 Mon, 23 Nov 2020 15:43:34 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F7DyqWi5;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1606175013;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UmYBoGJZ+xgXycGZ2xD1PRHhWHRVIM0ctH4xZxzTjB0=;
	b=F7DyqWi5tlZ3x7Q+FaiKDK3VGvp8CYHyDOkQEHC8dgD0Rg3dHxN/nXfb0Pf1Olve5FhXge
	FLCwT0LxTmpgKfy7E1gA1I4rotrNvwBsYHQwhsceD7YpIrsgKftaIiJbZa5gCKkdPq920k
	08h1j3dtaNWDESIqHDRyCNIgVrPGugo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-203-qNgrXSgcODWD5uvEqqno7Q-1; Mon, 23 Nov 2020 18:43:29 -0500
X-MC-Unique: qNgrXSgcODWD5uvEqqno7Q-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85B221858E23;
	Mon, 23 Nov 2020 23:43:27 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-230.ams2.redhat.com [10.36.112.230])
	by smtp.corp.redhat.com (Postfix) with ESMTP id B51655C1A3;
	Mon, 23 Nov 2020 23:43:24 +0000 (UTC)
Subject: Re: [PATCH v2 1/6] OvmfPkg/Amdsev: Base commit to build encrypted boot specific OVMF
To: jejb@linux.ibm.com, devel@edk2.groups.io
Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com,
 brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com,
 jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com,
 "Dr . David Alan Gilbert" <dgilbert@redhat.com>
References: <20201120184521.19437-1-jejb@linux.ibm.com>
 <20201120184521.19437-2-jejb@linux.ibm.com>
 <608a264b-b284-2512-a786-cab14a6a1237@redhat.com>
 <dbdada7f35ffa6b360b965ac431a5682e28837ea.camel@linux.ibm.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <b0a76303-5c0e-f9ff-731c-e3f1f549bd52@redhat.com>
Date: Tue, 24 Nov 2020 00:43:23 +0100
MIME-Version: 1.0
In-Reply-To: <dbdada7f35ffa6b360b965ac431a5682e28837ea.camel@linux.ibm.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 11/24/20 00:25, James Bottomley wrote:
> On Mon, 2020-11-23 at 19:01 +0100, Laszlo Ersek wrote:
>> On 11/20/20 19:45, James Bottomley wrote:

>>> +[PcdsFixedAtBuild]
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationCh
>>> ange|FALSE
>>> +  gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
>>> +!if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048)
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
>>> +  # match PcdFlashNvStorageVariableSize purely for convenience
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000
>>> +!endif
>>> +!if $(FD_SIZE_IN_KB) == 4096
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x8400
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x8400
>>> +  # match PcdFlashNvStorageVariableSize purely for convenience
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x40000
>>> +!endif
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x80000
>>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVolatileVariableSize|0x4000
>>> 0
>>
>> (3) The above two PCD settings are conditional on NETWORK_TLS_ENABLE
>> being TRUE, so please remove them together with the condition.
> 
> I removed them and assumed "with the condition" meant with the
> condition you removed in the first iteration.

Right, I meant that the entirety of:

!if $(NETWORK_TLS_ENABLE) == TRUE
  gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x80000
  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVolatileVariableSize|0x40000
!endif

should be removed.

Thanks!
Laszlo