From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.8069.1575973636093702774 for ; Tue, 10 Dec 2019 02:27:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V7mTJAJa; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575973635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+tp8A0q9zDTUCTmft06GxksUXDjtEOCYlVuH4FlBpNQ=; b=V7mTJAJaL6iCBxF8ptVOVW6ln6WdnxaGKB8Ec8grXnKsnwzbKvC5r2oLx5Yo/ntwmpUJSp 0LwZn587Mv/EenALgj/HZy0MzXQt8xzeKxASjITVcL7y2ECzDYFrm589XQJgvbuQXVacvo VfQQnJrixIXsMJigfvVHjhh5d39jg9k= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-sHip0mg6OC-9B96nL3Tv9Q-1; Tue, 10 Dec 2019 05:27:13 -0500 Received: by mail-wm1-f72.google.com with SMTP id g1so837692wmg.4 for ; Tue, 10 Dec 2019 02:27:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+tp8A0q9zDTUCTmft06GxksUXDjtEOCYlVuH4FlBpNQ=; b=QkBJPwLEVzg2fvDkFk2WGoiVMCStT5E8sXKP4sl1BLfl6Rzwxg7qRIU6xWoDUaDjcf S7feF4vPBnyQXT9lFDuw5znrjPPw1lTTWhogOEyJ8U8PkHw1del4WzyC7TlljuVaCjSe AaOFNP0CWThTw09LmA5x9eJj8G72kBnBzqO6QWhqknaBnydoDLTWNjOaDpyrd2zXoJQS B0922RHEz9Ovdo3CP9SRqRvCdItOOzShcQtfncfaMqOEQae0YXWi2LX+EGunXFfWfapW eUKSnRGbXp3KDwrMWovUZfi7m47nq8anGgdMAZWbiFDFdnL7Ko6//e5NAbrWn5sxOGmP GAwQ== X-Gm-Message-State: APjAAAUv6V4b6D4zT1lU92n3FS4jNwq3ExEJcCYhxoONB1UsXkQsG8G6 SmTBULXky51S9cYoXK3scO0pXYRJNEknuAMVp07DZC0udR428wILM+u/l+ga4gqsja+lVdVPGIF g+h6pJy6L2jtVpQ== X-Received: by 2002:adf:ea8a:: with SMTP id s10mr2315028wrm.278.1575973632370; Tue, 10 Dec 2019 02:27:12 -0800 (PST) X-Google-Smtp-Source: APXvYqyhGJEXArJVbitoEIPZtVXsd+hi3BVUhMlGwRCyNKeqe+EjIasG18l0OYzz4vA71imZf7/8Qw== X-Received: by 2002:adf:ea8a:: with SMTP id s10mr2315004wrm.278.1575973632120; Tue, 10 Dec 2019 02:27:12 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id i81sm2569648wma.10.2019.12.10.02.27.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2019 02:27:11 -0800 (PST) Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address To: devel@edk2.groups.io, lersek@redhat.com, "Rabeda, Maciej" , "Wu, Jiaxin" , Maciej Rabeda , "Kinney, Michael D" , "Gao, Liming" Cc: "Fu, Siyuan" References: <20191206162855.2155-1-maciej.rabeda@linux.intel.com> <895558F6EA4E3B41AC93A00D163B727416FBF2B4@SHSMSX107.ccr.corp.intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 10 Dec 2019 11:27:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: sHip0mg6OC-9B96nL3Tv9Q-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 12/10/19 10:10 AM, Laszlo Ersek wrote: > On 12/10/19 09:35, Rabeda, Maciej wrote: >> Ok, Jiaxin :) >> >> Mike, Laszlo, Liming, >> >> Do you know who I should contact in regards to maintainership role >> transition (edk2 write access etc.)? > > Write access directly to the edk2 repo has been revoked from > maintainers. > > Documentation updates are underway by Mike, to my understanding. Please > see the following threads: > > - [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master > http://mid.mail-archive.com/E92EE9817A31E24EB0585FDF735412F5B9E173A1@ORSMSX113.amr.corp.intel.com > https://edk2.groups.io/g/devel/message/50407 > > - [edk2-devel] [Patch wiki v2] EDK II CI: Update Phase 1 details and admin settings > http://mid.mail-archive.com/20191202175630.12788-1-michael.d.kinney@intel.com > https://edk2.groups.io/g/devel/message/51556 > > - [edk2-devel] [Patch wiki v2] EDK II Dev Process: Change push to GitHub pull request > http://mid.mail-archive.com/20191202180131.876-1-michael.d.kinney@intel.com > https://edk2.groups.io/g/devel/message/51557 > > > For a brief (personal, informal) summary, I can offer (quoting an email > I sent earlier): > > - prepare a local topic branch, on top of master, with the review tags > in place, such that (per the earlier method) you'd ff-push that topic > branch as the new edk2 master. > > - instead of pushing it to edk2, push it to your personal edk2 repo on > github.com > > - log in to github.com, and initiate a pull request against edk2/master, > from your personal topic branch You should be able to work without browser, using the hub tool such: $ sudo dnf install hub $ hub pull-request \ --base tianocore:master \ --head lersek:next \ --edit \ -F - < pull-request-template.md (see https://hub.github.com/hub-pull-request.1.html) I haven't audited the tool, so if you are worried about using it on your workstation, the web interface is certainly safer :) There is a Docker image based on Debian: https://hub.docker.com/r/tianon/github-hub/dockerfile $ podman pull tianon/github-hub ~/source/edk2$ podman run -v $PWD:$PWD -w $PWD tianon/github-hub usage: git [--version] [--help] [-C ] [-c name=value] [--exec-path[=]] [--html-path] [--man-path] [--info-path] [-p | --paginate | --no-pager] [--no-replace-objects] [--bare] [--git-dir=] [--work-tree=] [--namespace=] [] However it seems still incomplete: ~/source/edk2$ docker run \ --rm \ --volume $PWD:$PWD \ --volume $HOME/.gitconfig:$HOME/.gitconfig:ro \ --volume $HOME/.config/edk2:$HOME/.config/edk2:ro \ --volume $HOME/.config:/config:ro \ --workdir $PWD \ --user $UID \ tianon/github-hub \ hub issue mkdir /.config: permission denied So apparently this expects root privileges within container meaning it will access host files with that privileges too, which I'm not ready to accept. > - as soon as the pull request has been filed, locate the "labels" box to > the right, and apply the "push" label. > > Once the CI tests complete, the branch will be merged (fast-forwarded). > > > The official description will be in the wiki, containing even > screenshots. See the third reference above, from Mike. For now, those > updates can be seen rendered in Mike's clone of the Wiki, namely at > . > > Thanks > Laszlo