public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] SecurityPkg: Add ARM/AARCH64 arch to enable RngTest module build.
@ 2017-08-29  8:17 Long Qin
  2017-08-29  9:47 ` Ard Biesheuvel
  2017-08-29 16:42 ` Laszlo Ersek
  0 siblings, 2 replies; 3+ messages in thread
From: Long Qin @ 2017-08-29  8:17 UTC (permalink / raw)
  To: chao.b.zhang, lersek; +Cc: edk2-devel, Qin Long

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=680

Adding ARM and AARCH64 to SUPPORTED_ARCHITECTURES in SecurityPkg.dsc
to enable RngTest module build, since this is one platform-independent
application.

Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long <qin.long@intel.com>
---
 SecurityPkg/Application/RngTest/RngTest.inf | 2 +-
 SecurityPkg/SecurityPkg.dsc                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/SecurityPkg/Application/RngTest/RngTest.inf b/SecurityPkg/Application/RngTest/RngTest.inf
index 334cff45b0..55510f709a 100644
--- a/SecurityPkg/Application/RngTest/RngTest.inf
+++ b/SecurityPkg/Application/RngTest/RngTest.inf
@@ -27,7 +27,7 @@
 #
 # The following information is for reference only and not required by the build tools.
 #
-#  VALID_ARCHITECTURES           = IA32 X64
+#  VALID_ARCHITECTURES           = IA32 X64 ARM AARCH64
 #
 
 [Sources]
diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
index 8b9240374c..bb7147ec75 100644
--- a/SecurityPkg/SecurityPkg.dsc
+++ b/SecurityPkg/SecurityPkg.dsc
@@ -19,7 +19,7 @@
   PLATFORM_VERSION               = 0.97
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/SecurityPkg
-  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC
+  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC|ARM|AARCH64
   BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT
 
-- 
2.14.1.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] SecurityPkg: Add ARM/AARCH64 arch to enable RngTest module build.
  2017-08-29  8:17 [PATCH] SecurityPkg: Add ARM/AARCH64 arch to enable RngTest module build Long Qin
@ 2017-08-29  9:47 ` Ard Biesheuvel
  2017-08-29 16:42 ` Laszlo Ersek
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-08-29  9:47 UTC (permalink / raw)
  To: Long Qin; +Cc: Zhang, Chao B, Laszlo Ersek, edk2-devel@lists.01.org

On 29 August 2017 at 09:17, Long Qin <qin.long@intel.com> wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=680
>
> Adding ARM and AARCH64 to SUPPORTED_ARCHITECTURES in SecurityPkg.dsc
> to enable RngTest module build, since this is one platform-independent
> application.
>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qin Long <qin.long@intel.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  SecurityPkg/Application/RngTest/RngTest.inf | 2 +-
>  SecurityPkg/SecurityPkg.dsc                 | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/SecurityPkg/Application/RngTest/RngTest.inf b/SecurityPkg/Application/RngTest/RngTest.inf
> index 334cff45b0..55510f709a 100644
> --- a/SecurityPkg/Application/RngTest/RngTest.inf
> +++ b/SecurityPkg/Application/RngTest/RngTest.inf
> @@ -27,7 +27,7 @@
>  #
>  # The following information is for reference only and not required by the build tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64
> +#  VALID_ARCHITECTURES           = IA32 X64 ARM AARCH64
>  #
>
>  [Sources]
> diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
> index 8b9240374c..bb7147ec75 100644
> --- a/SecurityPkg/SecurityPkg.dsc
> +++ b/SecurityPkg/SecurityPkg.dsc
> @@ -19,7 +19,7 @@
>    PLATFORM_VERSION               = 0.97
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               = Build/SecurityPkg
> -  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC
> +  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC|ARM|AARCH64
>    BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER               = DEFAULT
>
> --
> 2.14.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] SecurityPkg: Add ARM/AARCH64 arch to enable RngTest module build.
  2017-08-29  8:17 [PATCH] SecurityPkg: Add ARM/AARCH64 arch to enable RngTest module build Long Qin
  2017-08-29  9:47 ` Ard Biesheuvel
@ 2017-08-29 16:42 ` Laszlo Ersek
  1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2017-08-29 16:42 UTC (permalink / raw)
  To: Long Qin, chao.b.zhang; +Cc: edk2-devel

On 08/29/17 10:17, Long Qin wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=680
> 
> Adding ARM and AARCH64 to SUPPORTED_ARCHITECTURES in SecurityPkg.dsc
> to enable RngTest module build, since this is one platform-independent
> application.
> 
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qin Long <qin.long@intel.com>
> ---
>  SecurityPkg/Application/RngTest/RngTest.inf | 2 +-
>  SecurityPkg/SecurityPkg.dsc                 | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/SecurityPkg/Application/RngTest/RngTest.inf b/SecurityPkg/Application/RngTest/RngTest.inf
> index 334cff45b0..55510f709a 100644
> --- a/SecurityPkg/Application/RngTest/RngTest.inf
> +++ b/SecurityPkg/Application/RngTest/RngTest.inf
> @@ -27,7 +27,7 @@
>  #
>  # The following information is for reference only and not required by the build tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64
> +#  VALID_ARCHITECTURES           = IA32 X64 ARM AARCH64
>  #
>  
>  [Sources]
> diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
> index 8b9240374c..bb7147ec75 100644
> --- a/SecurityPkg/SecurityPkg.dsc
> +++ b/SecurityPkg/SecurityPkg.dsc
> @@ -19,7 +19,7 @@
>    PLATFORM_VERSION               = 0.97
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               = Build/SecurityPkg
> -  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC
> +  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC|ARM|AARCH64
>    BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER               = DEFAULT
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thank you!
Laszlo


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-29 16:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-29  8:17 [PATCH] SecurityPkg: Add ARM/AARCH64 arch to enable RngTest module build Long Qin
2017-08-29  9:47 ` Ard Biesheuvel
2017-08-29 16:42 ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox