From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.58]) by mx.groups.io with SMTP id smtpd.web09.9170.1631789392477864805 for ; Thu, 16 Sep 2021 03:49:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Lhhku7h+; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.58, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tp2qB4kB4KtALaFrKonPQ9G+hlE+WJ2uX1q7P4zaajQpuH7XxG5Ki6aO1H7zqJq3RpDgy9zCam6iBNaY03Md8lqPgg9/QYXad6KZPV7gSHHyBB1DK4k83axjsGMf12iXc92JeiigCqgoACMczijnfCzy4CgzhN7mMCyf406xSL+m6EPnP0CXspKFTDKiJfCssaRsk+S8tYjuP812PXnI9PEFJ6AKvrnOBUkWwcvZuLxdZWM5esWE/z0QFjDMIBz847U0ngJHyPHfCKhndjZrz8+WFK27EJ/HlMG8SaFFAw0fuhyNsoicHxU3/7a8E35w3+/q0E8htu4SjGVHTJvEdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wVhhGx1qoKVg1ZSrF1/G9iIrpntR3nIxy/9mY13vLP8=; b=V0dDNeT2lwUYO/7CuonMm9cVxCPKS7u9cfqSpoVdRnfLi5qmhKUnPXepGHSJ6mRLpYdU014J+uqDGLOJ2ffL52jxoJol9F4n9QyPO0zQUNixpNTX17sqa6XfTsq8NF2LCHOcQxCGgG5/scSqdf7HJBecZ25adjQJSPxS5wabOEzCXwZCVx0PrhJYZAF66gUvua0flqABwlKQpQEiXVA6hp3BvrAkbL9GHmKMpqmPhKxX+oxM7BXFOQ8USlvJ1L+uZ3IfglOGUI0HX7kZAekNijmTvgxyp58dfglEH2txWjF6l4yuWwqIIqUYcFdizGcmyWlpT4HpUMVenI2sBVf8Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wVhhGx1qoKVg1ZSrF1/G9iIrpntR3nIxy/9mY13vLP8=; b=Lhhku7h+ztcwaLKQ6trOHqCoRulw4PZE0yk6/E0XB3nFUGEXaEQgvhOEzrLO6vlgZ5GNCFoU1lJpKgKTUNKFANCtkrDHAZnzH2wcoxTi4KqnElL4uvn3pdXOvd0i5crIPNxe5e0cUeeF9NRiFrZaY3RyS+FuZwVO2yP+nSDGWtg= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Thu, 16 Sep 2021 10:49:50 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4500.020; Thu, 16 Sep 2021 10:49:50 +0000 Subject: Re: [PATCH v7 09/31] OvmfPkg/SecMain: register GHCB gpa for the SEV-SNP guest To: Gerd Hoffmann Cc: Erdem Aktas , edk2-devel-groups-io , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Michael Roth References: <20210913181941.23405-1-brijesh.singh@amd.com> <20210913181941.23405-10-brijesh.singh@amd.com> <700b230a-88d0-2174-7235-6c633f2affac@amd.com> <20210916083037.cpkr2xo6ukpokfun@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: Date: Thu, 16 Sep 2021 05:49:48 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210916083037.cpkr2xo6ukpokfun@sirius.home.kraxel.org> X-ClientProxiedBy: SN1PR12CA0076.namprd12.prod.outlook.com (2603:10b6:802:20::47) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SN1PR12CA0076.namprd12.prod.outlook.com (2603:10b6:802:20::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 10:49:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbea8305-3d02-4b5b-7620-08d978ffb54e X-MS-TrafficTypeDiagnostic: SN6PR12MB2767: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DZtdFYtrzNqOEmmDTaXYoIx2PsT4Dj0OBS/eppIaW5beSvulOwvxTBQIplLPF9O4Vz2Qlb5aF4JWPDnkKnAoRQbn6CFsGTU5+sBB6i1P6VZAoEtcRgQicYoim2nV145YiTwwEVdcwxUC6poH2L1BatwZLNNxep14D2rrHiV5FhReQdO+FMynmQuTjL5Bx+Vdtdkfk9cm4xrT+rFeBt9e/HtNwaFU7+rFqYPXr1KTLvhjB4tn85LPa3N4dQPDZeOaGnWLOh5pZyZ/YJrn8cl+c1yGXwZTjpbWtugxfYCmf9kj5FD4/hmBmwsGtATeSMNt0EMLf2k4fPnz32x28MFCrwyFpSBA6L+cAHEOwb35dNdTzu6Ll5a59Ea/QlsnINQQWnKLBm9A9Q+Jl8BHOydOqP3bYp+/Eg3U+8FiSMNkjPonPYQxxi4L/D7dfFJZQM/vOdaueC0ZiL/rinjCljfawWk4E8NAUamlRe61jn/JyESPwwVpjTF6dZpby+rG5VZMhybyCevhf1YvB6HhDUAn86aafvhDwDpRKKG2ANxzUgjMec1GdnkcRZEqdWYw22Mq9zDo8Tb2QQDqL+79ShcdMNuV1ySRAQaVlB2m72DRonzy37yjAcjROQp4/Wqp4alQkqW7pwYyDvIQ6hAedgAv6ixOpu3OyccpjOWHC3OM8E0SOggkLG266YYWYDXfEtdil+/Coo34XVLGEXuKt8Vphlbk5lAcxw7HHXFMBjCCInqwp9LZ/WO+dE5jEXODZQ+c/qtgSoj1r0NqloVtUL8QPQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(136003)(396003)(366004)(8676002)(66946007)(956004)(53546011)(66476007)(52116002)(31696002)(8936002)(2616005)(66556008)(186003)(4326008)(54906003)(83380400001)(26005)(86362001)(478600001)(2906002)(6506007)(5660300002)(6486002)(4744005)(38350700002)(38100700002)(44832011)(6512007)(316002)(6916009)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWlFZXZmaGdmSFFxczVqamRRVk0zWTdONVIxZUhkekxpWHJMb1MyUFFERUFT?= =?utf-8?B?VW5wV1dQWVhrb011NWNuM1B1M2JwMU41MHlHOFRHQ21wdFJiWExGQVNYbkJ1?= =?utf-8?B?YVVNVkFYb2l3TzV6N2M5UW1jV0FYaHlmQ3hpRVVNbzFndTdaK2J3MDBQVU9G?= =?utf-8?B?eERvQVFEUEJHVkpCQjVEWHBvcnlUeXhZL2RvempEY1o5L3pEZ0xWcTI0dUMr?= =?utf-8?B?OHhGWnZpN05Yc3R4OGNzUlJQd2d2bHZodGFib0NSNjJXa3JHbDB4SzZVQzc3?= =?utf-8?B?alM3UjhpOGlKRElEOEdUUGZCSFErSGxzNjRONGJ2YkZmTFcrL3VOUGh6SE5X?= =?utf-8?B?dmQ4R0hSTmRQMzdPelVyL3hHeWNQVU1MMXdrYVNwcUFYdWdXSllFZEFtc1RF?= =?utf-8?B?bmVTVGlqMWJYRTFpaXJMd0lEcXo4N3hMTFpJdEh0aXpJVG9TZUcrZWE2cHRI?= =?utf-8?B?bWljZzJCeU9WN3N4djZFVXB4UmVUZko3Z0swRmhmMlJYRGpEZU45dTF6dnVr?= =?utf-8?B?TzMyNUpkeEF6MUs0cTJmZ3FXbG0raVFtUTR0S1ZreXZLSzV0YUIydjlaeWhm?= =?utf-8?B?RktGUVY0ckxQdE9qbzJtYkNwZzZ4ZEtJSmo2UFUvZit4RVZLa1ZNSnlPb3I4?= =?utf-8?B?ODF0R1NpOUYrT0ZWMFhtQ2xUVDEzd3U1VzhxcjhGUjRoK0FkaEp5WHhjTHF6?= =?utf-8?B?eXZLOVh1blN0NHFrU3NycHRtRWU2Wjc5ZTVqMXVxbk5MSnVwcE1lZUJkWEZx?= =?utf-8?B?a3dSNUw5bDhGSUorNkgrb1pYa0h4V0VPMzYxVDg4WldvTktCYk1nc1dUSEVo?= =?utf-8?B?anhhVnVReXZJYVk4ZmptdW9ubHVTcTJDRS8wK1lubXJLWCs3QXY1K2d2ZjJh?= =?utf-8?B?M3V3RXJyeFhTdUx4Mi9FelRZVm5pcGc4dHIwdm1yczh6Tmg4ZEFVWnhnT3R2?= =?utf-8?B?Q2dNOXMyMW4xNGRlZk1yam9ZU0gzaWd6SDZ1ZVFTMWdQYisxNTkycTVGSlk3?= =?utf-8?B?dmNOdDRoc2pycFVPMlFaK0tQeWtGbmNoa3pMQXdBa25uK2psWmVHVnFHRmFz?= =?utf-8?B?cEVCODd3c1N4dFMyOU41RkN5dkZzakNxcnJBTHhUZVk1Y2Q2Y3l3Zm9VYXJI?= =?utf-8?B?T0hDcmpmcnp6WWZad2diZXFjRGhnSmJwS2FUU3BuTDlwUERTUVFRMFdFNjhs?= =?utf-8?B?YTdjS0tJWjZxTmVaTnFZb0ZhU3U4NGFKaW5JcUtCNUMrS1BGcVBEaWcrekc2?= =?utf-8?B?UUt6djZUYjYvU3hMc1Q5dnArTEI1OTJuZXpJYmJiS1MwdVRTV1hBb09WK1JJ?= =?utf-8?B?aTJiOTBUdVZzQ0ZVeHUwMlpLekVCaEV4b3pvbDg5WnNEK2xiT3l1ZzZpVWYz?= =?utf-8?B?K0F6TlZ0UE9HK0VsRUQzaW1iMUpLWWplUDlZTVBqN0RwU3VpNzRXd2k2cnd4?= =?utf-8?B?RWsrdnJWK0YzRXYvVEgzMEU0c0doOXA0N3JJQjRGY1Y4YW1MMHhvMFZ1eGpa?= =?utf-8?B?bHNxeUozV2JHVVlMTmJEY3hMZ1pZa2FnYlhMUFhTVitVZGV4U1hpdmdSNTZO?= =?utf-8?B?UUp1K1FtMFgxeHFSMm1zUjlsaytFTitaa3IvUG1pS1ZFYXFTRy9VOVNvR2cx?= =?utf-8?B?SXZUaDdndnBReGQ0cHlhUTI5QVUwVWFtQmlLQ3V0VWlCQUZDaEhWSGMvV1RS?= =?utf-8?B?OFlVVzc4TTNDVFNrSUtTdElmUGpqbEd3TGJVcSs0VVVadGZpMEYycTluNHlG?= =?utf-8?Q?xBubfde6l19n8DRT+j8hfnVmDvi82A44H6Zaass?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbea8305-3d02-4b5b-7620-08d978ffb54e X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 10:49:50.5056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c8a1eDvxn4jOaG1/pbUJ8Mj/u/OANU5bEeJWLbT4/USuZMSd2lxA3CZ7qeEnvMR3iTugCSIxZZuPHv/1yvBCUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2767 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 9/16/21 3:30 AM, Gerd Hoffmann wrote: > Hi, > >> Good point, there is no reason to read and restore the old GHCB, I will >> remove it in next version. The function does not set this as a GHCB address, >> it send request to hypervisor saying that it would like to use this address. >> If hypervisor is not okay with the address then it may recommend something >> else. We don't support working with the hypervisor preferred address. >> Setting the GHCB address code is common between Snp and Es but checking with >> hypervisor whether its okay to use is new in the GHCBv2 and is SNP specific. > A comment explaining those GHCBv1 vs. GHCBv2 differences would be great. Sure, I will add comment. thanks