From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web10.297.1685121175175445308 for ; Fri, 26 May 2023 10:12:55 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=QM5omer7; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 61AE95C013B; Fri, 26 May 2023 13:12:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 26 May 2023 13:12:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1685121174; x=1685207574; bh=oWM4HSEhP/4vJi8uqSOj4NHPJqGRFvfpS9O z/40Ji64=; b=QM5omer73GLl5WyheqRGIH4Jk8dhd+u3HxqB826CY3OenLlY2qr +Ebok835fHHynuQWUMuO77inmr4Vp81l5D8yAeg5Wz1wOWZyaiIHb45wVqMS99aR sPGRMIiIDa0J8FYo+rrjrtH9NmK9xkV6ELZjx0sCWroN+3IuyYNQgGzR3u2LYfqM 5q+NyCy0rN5ma3EZhqABOThzF9pE/whAsSXKBa3GZg9f5e0M+FL13VyMyhO3zK2v toPbh1JxSX4WAhPEIy0bP35FwJpYTqCO3ukyH64rry4sZWMNM/o8lyZQZHiHND9E hcmVH6VvLau82jftLywjx4WC8Idg37tz6zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685121174; x=1685207574; bh=oWM4HSEhP/4vJi8uqSOj4NHPJqGRFvfpS9O z/40Ji64=; b=FOkZ9V2p0VsdWGli4GMr5I/nbFxV9asDcoUyBNodmWit/xUc+c2 z9/mrDvr64G6iEtdMXXkO9vu/jnL+/9VVB0VonNWBrhDfZDRweS2V25t2q8T86pF UFnJYJ6dVv/SyQ0OGFUVlugIaDiBrpNc/hW80J4ec4Q/gwhbVj/BSbb8bV2oh6WS Yv3+j1OMCSMl46bWhmvgU92DcMAue7VnC+tfgqr69LZGiGw6cIv+qQvozhEeUkCE fyLnpJ4isbrusNLZaQaV4NLTwrEceRS+dhM6g6DQfnuw5zMJ5GQUXOpzRDrc0w9A ImuWo8Y1SCCQhyUOyoaMN3UMdzMhT37jauQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejledguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepueegffduhedtffeileegledvheduhefgkeeuvedvuedulefftdehheei geejieelnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgt ohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 May 2023 13:12:52 -0400 (EDT) Message-ID: Date: Fri, 26 May 2023 11:12:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH v1] BaseTools: toolsetup.bat always execute PYTHON_HOME To: "Guo, Gua" , "devel@edk2.groups.io" Cc: "Gao, Liming" , "Feng, Bob C" , "Chen, Christine" References: <20230526000948.1862-1-gua.guo@intel.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit That looks good. Thanks! -- Rebecca Cran On 5/26/23 10:56 AM, Guo, Gua wrote: > @Rebecca Cran > > I update v2 patch on the PR https://github.com/tianocore/edk2/pull/4431 > > Could you help to check about whether meet your expectation ? > > Thanks, > Gua > > -----Original Message----- > From: Rebecca Cran > Sent: Saturday, May 27, 2023 12:30 AM > To: Guo, Gua ; devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; Chen, Christine > Subject: Re: [PATCH v1] BaseTools: toolsetup.bat always execute PYTHON_HOME > > On 5/25/23 6:09 PM, gua.guo@intel.com wrote: > >> >> -%PYTHON_COMMAND% %BASE_TOOLS_PATH%\Tests\PythonTest.py >> %PYTHON_VER_MAJOR% %PYTHON_VER_MINOR% >NUL 2>NUL -if %ERRORLEVEL% EQU >> 1 ( >> - echo. >> - echo !!! ERROR !!! Python %PYTHON_VER_MAJOR%.%PYTHON_VER_MINOR% or newer is required. >> - echo. >> - goto end >> + %PYTHON_COMMAND% %BASE_TOOLS_PATH%\Tests\PythonTest.py >> + %PYTHON_VER_MAJOR% %PYTHON_VER_MINOR% >NUL 2>NUL if %ERRORLEVEL% EQU 1 ( >> + echo. >> + echo !!! ERROR !!! Python %PYTHON_VER_MAJOR%.%PYTHON_VER_MINOR% or newer is required. >> + echo. >> + goto end >> + ) >> ) > If PYTHON_COMMAND is already defined we do still want to check it's a version we can use. So I don't think this part of the change is correct. > >