From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 26 Jun 2019 06:19:39 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1927A10C6E; Wed, 26 Jun 2019 13:19:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-47.ams2.redhat.com [10.36.117.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id 39ACA6012D; Wed, 26 Jun 2019 13:19:36 +0000 (UTC) Subject: Re: [PATCH v3 0/4] OvmfPkg: CSM boot fixes To: David Woodhouse , devel@edk2.groups.io References: <20190626113742.819933-1-dwmw2@infradead.org> From: "Laszlo Ersek" Message-ID: Date: Wed, 26 Jun 2019 15:19:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190626113742.819933-1-dwmw2@infradead.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 26 Jun 2019 13:19:39 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/26/19 13:37, David Woodhouse wrote: > For v3, leaving out the cosmetic parts that touch code outside OvmfPkg. > This series is now purely the correctness fixes within OvmfPkg which are > required to make CSM boots work properly again. > > The first two patches allow NVMe and VirtIO disks to be used as Legacy > boot targets, since nobody really uses IDE any more. > > The third avoids using QemuVideoDxe when we have CSM, as the INT 10h > shim installed by QemuVideoDxe conflicts with a real legacy video BIOS > being installed. > > Finally, avoid placing PCI BARs above 4GiB. Strictly speaking we only > need this for PCI devices which might be natively supported by the CSM > BIOS, like NVMe. Devices with an OpRom already get special-cased to stay > below 4GiB. But an IncompatiblePciDeviceSupportProtocol implementation > doesn't get to see the PCI device class; only the vendor/device IDs so > we can't use it for that purpose to downgrade more selectively. Instead, > just default to putting everything below 4GiB. > > > David Woodhouse (4): > OvmfPkg/LegacyBios: set NumberBbsEntries to the size of BbsTable > OvmfPkg/LegacyBbs: Add boot entries for VirtIO and NVME devices > OvmfPkg: Don't build in QemuVideoDxe when we have CSM > OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled > > OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c | 157 ++++++++++++++++++++++++- > OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 7 +- > OvmfPkg/OvmfPkgIa32.dsc | 2 + > OvmfPkg/OvmfPkgIa32.fdf | 5 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 6 + > OvmfPkg/OvmfPkgIa32X64.fdf | 5 +- > OvmfPkg/OvmfPkgX64.dsc | 6 + > OvmfPkg/OvmfPkgX64.fdf | 5 +- > 8 files changed, 179 insertions(+), 14 deletions(-) > Series pushed as commit range 2f3435c2343f..c7341877f695. Thank you! Laszlo