From: "Liming Gao" <liming.gao@intel.com>
To: Krzysztof Koch <krzysztof.koch@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Matteo.Carlini@arm.com" <Matteo.Carlini@arm.com>,
"Sami.Mujawar@arm.com" <Sami.Mujawar@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH v2 1/1] MdePkg: Add PCCT table signature definition
Date: Thu, 13 Feb 2020 00:58:37 +0000 [thread overview]
Message-ID: <b0fc1a3e53434f678f8b2b253b2601f4@intel.com> (raw)
In-Reply-To: <20200212172739.20240-1-krzysztof.koch@arm.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Krzysztof Koch <krzysztof.koch@arm.com>
> Sent: Thursday, February 13, 2020 1:28 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Matteo.Carlini@arm.com;
> Sami.Mujawar@arm.com; nd@arm.com
> Subject: [PATCH v2 1/1] MdePkg: Add PCCT table signature definition
>
> The Platform Communications Channel Table (PCCT) was defined in:
> ACPI Specification Version 5.0, Errata A - Published Nov. 13, 2013.
>
> Starting from the Acpi50.h header file, there are definitions
> describing the table but a macro with the table's signature is missing.
>
> This patch adds the definition of Platform Communications Channel
> Table's signature to the relevant ACPI header files.
>
> Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
> ---
>
> Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def_v2
>
> Notes:
> v2:
> - Replicate the definition from Acpi50.h onwards [Liming]
>
> v1:
> - Add definition of PCCT table signature [Krzysztof]
>
> MdePkg/Include/IndustryStandard/Acpi50.h | 6 ++++++
> MdePkg/Include/IndustryStandard/Acpi51.h | 6 ++++++
> MdePkg/Include/IndustryStandard/Acpi60.h | 6 ++++++
> MdePkg/Include/IndustryStandard/Acpi61.h | 6 ++++++
> MdePkg/Include/IndustryStandard/Acpi62.h | 6 ++++++
> MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++-
> 6 files changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/IndustryStandard/Acpi50.h
> index 46dcdb950741020420a5695a8577dde5ac409ed7..31a47e6a2c4276d5b1ad7b834af84844090b64c5 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi50.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h
> @@ -3,6 +3,7 @@
>
> Copyright (c) 2014 Hewlett-Packard Development Company, L.P.<BR>
> Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2020, ARM Ltd. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> @@ -2057,6 +2058,11 @@ typedef struct {
> ///
> #define EFI_ACPI_5_0_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
>
> +///
> +/// "PCCT" Platform Communications Channel Table
> +///
> +#define EFI_ACPI_5_0_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SIGNATURE_32('P', 'C', 'C', 'T')
> +
> ///
> /// "SLIC" MS Software Licensing Table Specification
> ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/IndustryStandard/Acpi51.h
> index 0132f25de8ce945135714e59b4b9e5bd286b2c22..fc28ffa18fc6a22e52fda88fade6ad80b2817cc3 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi51.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h
> @@ -4,6 +4,7 @@
> Copyright (c) 2014 Hewlett-Packard Development Company, L.P.<BR>
> Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> + Copyright (c) 2020, ARM Ltd. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> @@ -2078,6 +2079,11 @@ typedef struct {
> ///
> #define EFI_ACPI_5_1_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
>
> +///
> +/// "PCCT" Platform Communications Channel Table
> +///
> +#define EFI_ACPI_5_1_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SIGNATURE_32('P', 'C', 'C', 'T')
> +
> ///
> /// "SLIC" MS Software Licensing Table Specification
> ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/IndustryStandard/Acpi60.h
> index 94a30a81b369d96dc83dce7aa1e274ef54b315aa..5dcd73b6f1ec4bccc7fdae7d56c2963ab58764f9 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi60.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi60.h
> @@ -3,6 +3,7 @@
>
> Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
> + Copyright (c) 2020, ARM Ltd. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> @@ -2321,6 +2322,11 @@ typedef struct {
> ///
> #define EFI_ACPI_6_0_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
>
> +///
> +/// "PCCT" Platform Communications Channel Table
> +///
> +#define EFI_ACPI_6_0_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SIGNATURE_32('P', 'C', 'C', 'T')
> +
> ///
> /// "SLIC" MS Software Licensing Table Specification
> ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h
> index 985c8273ce61c86d445e61d0d5c1d8ae7c00cb8d..8626833a794dfb4a6f19d459d5214c6caefdbbee 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi61.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi61.h
> @@ -3,6 +3,7 @@
>
> Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> + Copyright (c) 2020, ARM Ltd. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> @@ -2353,6 +2354,11 @@ typedef struct {
> ///
> #define EFI_ACPI_6_1_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
>
> +///
> +/// "PCCT" Platform Communications Channel Table
> +///
> +#define EFI_ACPI_6_1_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SIGNATURE_32('P', 'C', 'C', 'T')
> +
> ///
> /// "SLIC" MS Software Licensing Table Specification
> ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h
> index 5a5e9b811247e11b7ba3c998fb1bd6419c67980f..1b2704e98e3703a4405075247432ec842e45021b 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -2,6 +2,7 @@
> ACPI 6.2 definitions from the ACPI Specification Revision 6.2 May, 2017.
>
> Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2020, ARM Ltd. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> @@ -2879,6 +2880,11 @@ typedef struct {
> ///
> #define EFI_ACPI_6_2_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
>
> +///
> +/// "PCCT" Platform Communications Channel Table
> +///
> +#define EFI_ACPI_6_2_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SIGNATURE_32('P', 'C', 'C', 'T')
> +
> ///
> /// "SDEI" Software Delegated Exceptions Interface Table
> ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
> index eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc39bde9a3379e3b7005 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi63.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi63.h
> @@ -2,7 +2,7 @@
> ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, 2019.
>
> Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> - Copyright (c) 2019, ARM Ltd. All rights reserved.<BR>
> + Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
> @@ -2880,6 +2880,11 @@ typedef struct {
> ///
> #define EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
>
> +///
> +/// "PCCT" Platform Communications Channel Table
> +///
> +#define EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SIGNATURE_32('P', 'C', 'C', 'T')
> +
> ///
> /// "SDEI" Software Delegated Exceptions Interface Table
> ///
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2020-02-13 0:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 17:27 [PATCH v2 1/1] MdePkg: Add PCCT table signature definition Krzysztof Koch
2020-02-13 0:58 ` Liming Gao [this message]
[not found] ` <15F2D05E08B7669A.10188@groups.io>
2020-02-13 11:58 ` [edk2-devel] " Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0fc1a3e53434f678f8b2b253b2601f4@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox