From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.2223.1581555521216551677 for ; Wed, 12 Feb 2020 16:58:41 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 16:58:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,434,1574150400"; d="scan'208";a="434248103" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 12 Feb 2020 16:58:39 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 12 Feb 2020 16:58:39 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 13 Feb 2020 08:58:37 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Thu, 13 Feb 2020 08:58:37 +0800 From: "Liming Gao" To: Krzysztof Koch , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Matteo.Carlini@arm.com" , "Sami.Mujawar@arm.com" , "nd@arm.com" Subject: Re: [PATCH v2 1/1] MdePkg: Add PCCT table signature definition Thread-Topic: [PATCH v2 1/1] MdePkg: Add PCCT table signature definition Thread-Index: AQHV4cnNsG30QW/e0kGp1YyZAjlMJqgYTdtQ Date: Thu, 13 Feb 2020 00:58:37 +0000 Message-ID: References: <20200212172739.20240-1-krzysztof.koch@arm.com> In-Reply-To: <20200212172739.20240-1-krzysztof.koch@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Krzysztof Koch > Sent: Thursday, February 13, 2020 1:28 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming ; Matteo.Carlini@arm.com; > Sami.Mujawar@arm.com; nd@arm.com > Subject: [PATCH v2 1/1] MdePkg: Add PCCT table signature definition >=20 > The Platform Communications Channel Table (PCCT) was defined in: > ACPI Specification Version 5.0, Errata A - Published Nov. 13, 2013. >=20 > Starting from the Acpi50.h header file, there are definitions > describing the table but a macro with the table's signature is missing. >=20 > This patch adds the definition of Platform Communications Channel > Table's signature to the relevant ACPI header files. >=20 > Signed-off-by: Krzysztof Koch > --- >=20 > Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/617_a= dd_pcct_signature_def_v2 >=20 > Notes: > v2: > - Replicate the definition from Acpi50.h onwards [Liming] >=20 > v1: > - Add definition of PCCT table signature [Krzysztof] >=20 > MdePkg/Include/IndustryStandard/Acpi50.h | 6 ++++++ > MdePkg/Include/IndustryStandard/Acpi51.h | 6 ++++++ > MdePkg/Include/IndustryStandard/Acpi60.h | 6 ++++++ > MdePkg/Include/IndustryStandard/Acpi61.h | 6 ++++++ > MdePkg/Include/IndustryStandard/Acpi62.h | 6 ++++++ > MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++- > 6 files changed, 36 insertions(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/In= dustryStandard/Acpi50.h > index 46dcdb950741020420a5695a8577dde5ac409ed7..31a47e6a2c4276d5b1ad7b834= af84844090b64c5 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi50.h > +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > @@ -3,6 +3,7 @@ >=20 > Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
> Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2020, ARM Ltd. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > @@ -2057,6 +2058,11 @@ typedef struct { > /// > #define EFI_ACPI_5_0_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', = 'S', 'D', 'M') >=20 > +/// > +/// "PCCT" Platform Communications Channel Table > +/// > +#define EFI_ACPI_5_0_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SI= GNATURE_32('P', 'C', 'C', 'T') > + > /// > /// "SLIC" MS Software Licensing Table Specification > /// > diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/In= dustryStandard/Acpi51.h > index 0132f25de8ce945135714e59b4b9e5bd286b2c22..fc28ffa18fc6a22e52fda88fa= de6ad80b2817cc3 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi51.h > +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > @@ -4,6 +4,7 @@ > Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
> Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.
> (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2020, ARM Ltd. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > @@ -2078,6 +2079,11 @@ typedef struct { > /// > #define EFI_ACPI_5_1_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', = 'S', 'D', 'M') >=20 > +/// > +/// "PCCT" Platform Communications Channel Table > +/// > +#define EFI_ACPI_5_1_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SI= GNATURE_32('P', 'C', 'C', 'T') > + > /// > /// "SLIC" MS Software Licensing Table Specification > /// > diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/In= dustryStandard/Acpi60.h > index 94a30a81b369d96dc83dce7aa1e274ef54b315aa..5dcd73b6f1ec4bccc7fdae7d5= 6c2963ab58764f9 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi60.h > +++ b/MdePkg/Include/IndustryStandard/Acpi60.h > @@ -3,6 +3,7 @@ >=20 > Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
> (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2020, ARM Ltd. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > @@ -2321,6 +2322,11 @@ typedef struct { > /// > #define EFI_ACPI_6_0_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', = 'S', 'D', 'M') >=20 > +/// > +/// "PCCT" Platform Communications Channel Table > +/// > +#define EFI_ACPI_6_0_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SI= GNATURE_32('P', 'C', 'C', 'T') > + > /// > /// "SLIC" MS Software Licensing Table Specification > /// > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/In= dustryStandard/Acpi61.h > index 985c8273ce61c86d445e61d0d5c1d8ae7c00cb8d..8626833a794dfb4a6f19d459d= 5214c6caefdbbee 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > @@ -3,6 +3,7 @@ >=20 > Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2020, ARM Ltd. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > @@ -2353,6 +2354,11 @@ typedef struct { > /// > #define EFI_ACPI_6_1_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', = 'S', 'D', 'M') >=20 > +/// > +/// "PCCT" Platform Communications Channel Table > +/// > +#define EFI_ACPI_6_1_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SI= GNATURE_32('P', 'C', 'C', 'T') > + > /// > /// "SLIC" MS Software Licensing Table Specification > /// > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/In= dustryStandard/Acpi62.h > index 5a5e9b811247e11b7ba3c998fb1bd6419c67980f..1b2704e98e3703a4405075247= 432ec842e45021b 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -2,6 +2,7 @@ > ACPI 6.2 definitions from the ACPI Specification Revision 6.2 May, 201= 7. >=20 > Copyright (c) 2017, Intel Corporation. All rights reserved.
> + Copyright (c) 2020, ARM Ltd. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > @@ -2879,6 +2880,11 @@ typedef struct { > /// > #define EFI_ACPI_6_2_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', = 'S', 'D', 'M') >=20 > +/// > +/// "PCCT" Platform Communications Channel Table > +/// > +#define EFI_ACPI_6_2_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SI= GNATURE_32('P', 'C', 'C', 'T') > + > /// > /// "SDEI" Software Delegated Exceptions Interface Table > /// > diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/In= dustryStandard/Acpi63.h > index eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc39b= de9a3379e3b7005 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi63.h > +++ b/MdePkg/Include/IndustryStandard/Acpi63.h > @@ -2,7 +2,7 @@ > ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, 201= 9. >=20 > Copyright (c) 2017, Intel Corporation. All rights reserved.
> - Copyright (c) 2019, ARM Ltd. All rights reserved.
> + Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -2880,6 +2880,11 @@ typedef struct { > /// > #define EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', = 'S', 'D', 'M') >=20 > +/// > +/// "PCCT" Platform Communications Channel Table > +/// > +#define EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SI= GNATURE_32('P', 'C', 'C', 'T') > + > /// > /// "SDEI" Software Delegated Exceptions Interface Table > /// > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'